[RESOLVED] Parse error: parse error ???

kostis12345

HI I am trying to get something from my database using the code below but I get this error:

Parse error: parse error in C:\wamp\www\members.php on line 8

Here's my code:
I've noted line 8

<?php
include ('database/connect.php');
/**
 * @author kostis
 * @copyright 2008
 */
$user = $_POST["username"];
$target = mysql_query("SELECT * FROM players WHERE alias = "$_SESSION['Alias']); // That's line 8



$result = mysql_fetch_array($target);

echo "<center>";
echo "<br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/>";
echo "Next Target : ";
echo $result['Target'];

echo "</center>";

?>

And can you please tell me if this is correct :

$_SESSION['Alias'] = $user;

$user is defined here

$user = $_POST["username"];

Thanks in advance

NogDog

Need a concatenation operator ("."):

$target = mysql_query("SELECT * FROM players WHERE alias = " . $_SESSION['Alias']);
//                                                           ^

Also, if alias is not a numeric type, then you'll need to quote the value:

$target = mysql_query("SELECT * FROM players WHERE alias = '" . $_SESSION['Alias'] . "'");

Lastly, you should probably escape the value to prevent SQL injection problems:

$target = mysql_query("SELECT * FROM players WHERE alias = '" . 
mysql_real_escape_string($_SESSION['Alias']) . "'");

kostis12345

Ok,I'm going to try as soon as I get home.Thanks a lot !

kostis12345

The error is gone but "echo $result['Target']; " returns blank :?

Here is the part of login.php that sets the Session

if ($result!=1) echo "Login failure!";
		else
		{
            $_SESSION['Alias'] = $user;
			header( 'Location: http://localhost/loginsuccess.php' ) ;
		}

and here is where $user is set

$user = $_POST["username"];
$pass = $_POST["password"];
$login = $_GET["login"];

EDIT: After changing some lines I found that it's like the session is never set .Specifically I changed :

$_SESSION['Alias'] = $user;

 $_SESSION['Alias'] = "test";

and then I commented the lines that have to do with the DB and changed this line:

echo "Next Target :";
echo $result['target'];

to

echo "Next Target :".$_SESSION['Alias'];

and it still returned blank.

So can someone please tell me where is the error in my session ?

Thanks in advance

Weedpacket

kostis12345 wrote:
So can someone please tell me where is the error in my session ?

Do you ever start the session with [man]session_start/man? (In connect.php, perhaps?) You need to do that before you can use anything in $_SESSION.

kostis12345

I have it both on login.php (where I set the session) and on members.php (where I request the session)

do you want me to post my whole code ?

kostis12345

First,I'm sorry for double posting but I can't edit my post since there have been more than 60 minutes since I posted.
Now to the problem.
After doing some more tests it turned out that the problem is that the session is not set.
I'm going to post all of my code for both login.php and members.php

<? session_start(); ?>
<html>
<body>
<form action="login.php?login=yes" method="post">
Username <input type=text name="username"><br />
Password <input type=password name="password"><br />
<input type="submit" value="Go!">
</form>
<?php

$user = $_POST["username"];
$pass = $_POST["password"];
$login = $_GET["login"];

if ($login=='yes')
{
    include ('database/connect.php');
	$get=mysql_query("SELECT count(id) FROM players WHERE alias='$user' and password='$pass'");
		$result=mysql_result($get, 0);

	mysql_close($con);


	if ($result!=1) echo "Login failure!";
	else
	{
        $_SESSION['Alias'] = $_POST['username'];
		header( 'Location: http://localhost/loginsuccess.php' ) ;
	}
}
?>
</body>
</html>

Members.php

<?php
session_start();

include ('database/connect.php');

echo "<center>";
if (isset($_SESSION['Alias']))
{
$user = $_POST["username"];
$target = mysql_query("SELECT target FROM players WHERE alias = '" .$_SESSION['Alias'] . "'");
mysql_real_escape_string($_SESSION['Alias'] . "'");
$result = mysql_fetch_array($target);


echo "<br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/>";
echo "Next Target :".$_SESSION['Alias'];
//echo $result['target'];
}
else
{
	echo "Session isn't working";
}


echo "</center>";

?>

Thanks in advance

NogDog

Could it be something as simple as using "<?php" instead of "<?" at the start of your login script? ("<?" only works if then short_open_tags setting is enabled.)

kostis12345

Man I feel so dumb ...
A <?php instead of <?

Thanks a lot 🙂.