[RESOLVED] Simple Log in

zenix

Hi, I am creating a log in page so I can learn more about the programming. It's a very, very simple one containing just a username, password1 and password2. Once I can make this work I will understand enough to go to the next step (I think). I have made and re-made this several times and have decided I need to have some help before I get a concussion from banging my head into this wall. When I submit the simple form I keep getting the error "enter a user name and password" There are only 3 text fields in the form right now, they are filled. Thank you so much in advance for your help.

<html><head><title>List Directory!</title></head><body>

<?php
//Address errors
ini_set('display_errors', 1);
error_reporting(E_ALL & ~E_NOTICE);

//This script allows users to register and store the log in info in a txt file
if(isset($_POST['submit']))
//Handle form
{
    $problem = FALSE;

//Check for values
if(empty($_POST['username']))
{
    $problem = TRUE;
    print 'Please enter a user name';
}
if(empty($_POST['password1']))
{
    $problem = TRUE;
    print 'Please enter a password';
}
if (empty($_POST['password2']))
{
    $problem = TRUE;
    print 'Please confirm your password';
}
if(!$problem)
{
    if($fp = fopen('..users//users.txt', 'ab'))
    {
        //create data to be written
        fwrite($fp, $data);
        fclose($fp);
        //create directory
        mkdir("..//users//$dir");
        //print message
        print 'You are now registered!';
    }
    else
    {
        //forgot a field
        print 'Please make sure all fields are filled in';
    }
}
}
   else
{
        //display the form


   ?>

<form action = "reguser2.php" method="post">
Username: <input type ="text" name ="username" size ="20" /><br/><br/>
Password: <input type ="password" name ="password1" size="20" /><br/><br/>
Confirm password: <input type="password" name="password2 size=20" /><br/><br/>
<input type="submit" name="submit" value="REGISTER ME!!" />
</form>
<?php
}
?>
</body></html>

walterquez

According to the code you posted, I don't see anywhere where it would print "enter a user name and password".

Also, if this code is true

if(!$problem)

then there is no reason for this code in the else part of the statement, unless $dir also needs to be included in the form.

print 'Please make sure all fields are filled in';

Where is $dir getting its value from?

zenix

I have copied and pasted the message I get. Thank you for your time!

Please enter a user namePlease confirm your password

djjjozsi

if you want to check if the password1 is equal with password2,
build an if condition:

    if ($_POST['password1']!=$_POST['password2']))
    {
        $problem = TRUE;
        print 'Please confirm your password!';
    }

....

But this script you posted is not a good way to register a user/password.
Why don't you store these data in a database?

If this is a register page, then you have to check if that username has already registered by another user.

Hello,
jjozsi

zenix

Thanks a lot for your time and for answering my query. I am going to go the database route. I am just REALLY new to this and am attempting to learn the programming piece by piece. I plan to use MySQL of course and should be starting on that course by later this week or next.

The problem isn't that I can't verify password1 = password2, it's that I keep getting the message Please enter a user namePlease confirm your password when I attempt "logging in". It doesn't make sense to me because the fields are not empty. Kinda frustrating.

You have helped me a few times in the past, I EALLY appreciate it and believe it or not AM getting better at this.

zenix

Here is my changed code, I was hoping it would help me....it didn't.

<html><head><title>List Directory!</title></head><body>

<?php
//Address errors
ini_set('display_errors', 1);
error_reporting(E_ALL & ~E_NOTICE);
?>


<?php
//This script allows users to register and store the log in info in a txt file
if(isset($_POST['submit']))
//Handle form
{
   $problem = FALSE;

//Check for values
if(empty($_POST['username']))
{
    $problem = TRUE;
    print 'Please enter username<br/>';
}

if(empty($_POST['password1']))
{
    $problem = TRUE;
    print 'Please enter a password<br/>';
}
if (empty($_POST['password2']))
{
    $problem = TRUE;
    print 'Please confirm your password<br/>';
}
if(!$problem)
{
    //open file
    if($fp = fopen('..users//users.txt', 'ab'))
    {
        //create data to be written
        $dir = time() . rand(0, 4596);
        $data = $_POST['username'] . "\t" . crypt($_POST['password1']) . "\t" . $dir . "\r\n";    
        //write data and close file
        fwrite($fp, $data);
        fclose($fp);
        //create directory
        mkdir("..//users//$dir");
        //print message
        print 'You are now registered!';
    //}
    }
    else
    {
        //Couldn't write to file
        print 'You could not be registered because of a technical error';
    }
    //else
    //{


}
else
{
                //forgot a field
        print 'Please make sure all fields are filled in';
}
}
   else
{
        //display the form


   ?>


<?php
}
?>
<form action = "reguser2.php" method="post">
Username: <input type ="text" name ="username" size ="20" /><br/><br/>
Password: <input type ="password" name ="password1" size="20" /><br/><br/>
Confirm password: <input type="password" name="password2" "size=20" /><br/><br/>
<input type="submit" name="submit" value="REGISTER ME!!" />
</form>
</body></html>