[RESOLVED] images not showing on browser

roikes

i am a complete newbie to php and trying to learn it myself
been trying to build a simple php page that loads all pictures files on a directory
and display them in a table
on the browser i get only image icons and not the pictures. (attached is a jpg file with the result)
the source file from the browser seems good
and if i copy the whole source and paste it as an new html file it opens all the images.
what am i doing wrong?
here is the php part that suppose to do the work:

<?php
$dir = "c:/wamp/www/my/images/";
$dh = opendir($dir);
while ($filename = readdir($dh))
{
$filepath = $dir.$filename;
if(is_file($filepath) and ereg(".jpg$",$filename))
{
$gallery[] = $filepath;
}
}
foreach($gallery as $image)
{
echo "<img src= '$image'><br>";
}
?>

planetsim

Please in future wrap you php code in [php][/php] tags.

Your getting the issue with images not showing up because your using the server file system path rather than the HTTP Path to fix the issue you could do something like this

<?php
$dir = "c:/wamp/www/my/images/";
$dh = opendir($dir);
while ($filename = readdir($dh))
{
$filepath = $dir.$filename;
if(is_file($filepath) and ereg("\.jpg$",$filename))
{
$gallery[] = $filepath;
}
}
foreach($gallery as $image)
{
echo "<img src= '" . str_replace( $_SERVER["DOCUMENT_ROOT"], "", $image ) . "'><br>";
}
?>

What the str_replace( $_SERVER["DOCUMENT_ROOT"], "", $image ) does is removes the Document Root path assuming c:/wamp/www/ is in fact the document root it should change the string to be e.g.

/my/images/somefilename.jpg

Hope this helps.

nrg_alpha

I am basing this code on the assumption that the value of $_SERVER['DOCUMENT_ROOT'] = c:/wamp/www, and that the images are found in /my/images/

You can simplify things by using glob():

$dir = $_SERVER['DOCUMENT_ROOT'].'/my/images/';
foreach (glob($dir."*.jpg") as $filename){
   echo '<img src="/my/images/' . basename($filename) . '" alt="" />' . "\r\n";
}

Output format:

<img src="/my/images/***.jpg" alt="" />
<img src="/my/images/***.jpg" alt="" />
<img src="/my/images/***.jpg" alt="" />
...

where *** is the filename. If the file paths are incorrect, adjust them to match what they need to be to work.

Cheers (and happy new year)

NRG

EDIT: Looking at the original code snippet, do not use ereg (which is part of POSIX, which will no longer be included within the PHP core as of version 6). So I recommend learning PCRE (preg functions) instead.

roikes

thank you very much
you solved my problem
happy new year

nrg_alpha

Perfect!
Please flag this thread as resolved (top menu under 'Thread Tools > Mark thread resolved').