[RESOLVED] logging someone out based in inactivity

harmor

I'm trying to write a code that will check if an user has been inactive for one hour.
If so log him or her out when page is updated.

class_user.php

var $logtime;

function setLogTime($logtime)
{
	$this->logtime = $logtime;
}


function updateTime($session_user)
{
	$checklogtime = $this->logtime + 1;

echo $checklogtime;

if(date('g') >= $checklogtime && $session_user)
	header('Location: login.php?do=logout');
else	
	$this->logtime = date('g');
}

When I echo out '$checklogtime' it's value is always '1' which is not what is supposed to happen. Where I live '$this->logtime' should output '3' so '$checklogtime' should output '4'.

$mgpuser->setLogTime(date('g'));

includes.php

$mgpuser->updateTime($_SESSION['userid']);

What should be happening is when the user logs in it'll set the hour the user logged in. The 'logtime' variable will keep updating if the user is browsing the site within the one hour time frame. If the user doesn't browse the site for one hour the user will be logged out.

What's happening now is that as soon as an user logs in he or she will be immediately logged out.

trained_monkey

When I echo out '$checklogtime' it's value is always '1' which is not what is supposed to happen.

if $checklogtime is always '1' then $this->logtime is always '0' and if $this->logtime is always '0' then date('g') is always '0'.....so you might want to check date('g')

Weedpacket

I think it would be better if you recorded the actual time (using time()) that the user last did something; log them out when the current time is more than 3600 seconds after that. Just recording a number from 1 to 12 isn't going to work for more than one reason (one of them being that 1 comes after 12, but 1 is less than 12).

harmor

I got it to work but I used the database.

class_user.php

function initLogTime($ltime, $session_userid)
{

mysql_query("UPDATE users SET lastlogtime='$ltime'
WHERE userid='$session_userid' ")
or die(mysql_error()); 
}

function checkTime($session_userid)
{

$query = mysql_query("SELECT lastlogtime FROM users WHERE userid='$session_userid' ")or die(mysql_error());
$row = mysql_fetch_array($query);

$ltime = time() - $row['lastlogtime'];

if($ltime >= 900)
	session_destroy();
}

$mgpuser->initLogTime(time(), $_SESSION['userid']);

includes.php

if($_SESSION['userid'])
{
	$mgpuser->checkTime($_SESSION['userid']);
	$mgpuser->initLogTime(time(), $_SESSION['userid']);
}