while ( $row = mysql_fetch_object($result) ) has syntax error: where?

[marcnyc]

I wrote this function (below) and I am getting the following error

Parse error: syntax error, unexpected T_STRING in /home4/www/public_html/reviews/lib/class_reviews.inc.php on line 27

	function get_last_id_from_db( )
	{
			if ( !$this->num_Error() ) {
				$query = "SELECT id FROM reviews2_category WHERE category NOT LIKE 'book_%'
										       && category NOT LIKE 'magazine_%'
											   ORDER BY id LIMIT 1";
			}
			$result = mysql_query($query);
			while ( $row = mysql_fetch_object($result) ){
			echo $row->id;
			}
			mysql_free_result($result);
	}

Line 27 is this:
while ( $row = mysql_fetch_object($result) ) {

I can't figure out what is wrong and I was hoping somebody could point me in the right direction

[laserlight]

At a glance, it looks syntactically correct to me. However, it is more accurately written as:

function get_last_id_from_db( )
{
    if ( !$this->num_Error() ) {
        $query = "SELECT id FROM reviews2_category WHERE category NOT LIKE 'book_%'
                               && category NOT LIKE 'magazine_%'
                               ORDER BY id LIMIT 1";

    $result = mysql_query($query);
    while ( $row = mysql_fetch_object($result) ){
        echo $row->id;
    }
    mysql_free_result($result);
}
}

[djjjozsi]

i'm not an OOP expert, but i can see a missing DESC in your sql query (if you need the last ID):

                $query = "SELECT id FROM reviews2_category WHERE category NOT LIKE 'book_%'
                                               AND category NOT LIKE 'magazine_%'
                                               ORDER BY id DESC LIMIT 1"; 

And lets see this condition:

if ( empty($this->num_Error()) )

but, lets test the logic:

if(empty)
{
$query='xxxxxxxxx';
}
run this $query // but if error_num is not empty your $query has not set.

[marcnyc]

excuse me but what is the difference?
I might be blind but except for the indentation I am not seeing what's different

also, why do you think I am getting that syntax error?

[laserlight]

marcnyc wrote:

excuse me but what is the difference?
I might be blind but except for the indentation I am not seeing what's different

The difference is that the scope of the if statement extends to the code that relies on $query. At the moment if the if condition is not satisfied, you will get an undefined variable notice.

marcnyc wrote:

also, why do you think I am getting that syntax error?

As I said, your code looks syntactically correct.

[marcnyc]

both your suggestions pointed me in the right direction
thank you so much!
this forum is great, it helped me so many times after I was stuck!