my sql insert not inserting

CodeMama

Could someone look at this it isn't inserting:

<?php 
error_reporting(E_ALL);
ini_set('display_errors', '1');
include("../inc/dbConnect.php"); 
if (isset($_POST['UserName'])) {$UserName = $_POST['UserName'];} else {$UserName = "";}
if (isset($_POST['salesperson'])){$salesperson = $_POST['salesperson'];} else {$salesperson = "";}
if (isset($_POST['salesID'])){$salesID = $_POST['salesID'];} else {$salesID = "";}
if (isset($_POST['salesEmail'])){$salesEmail = $_POST['salesEmail'];} else {$salesEmail = "";}
if (isset ($_POST['bizName'])){$bizName = $_POST['bizName'];} else {$bizName = "";}
if (isset ($_POST['bizType' ])) {$bizType = $_POST['bizType'];} else {$bizType = "";}
if (isset ($_POST['badgeImg'])) {$badgeImg = $_POST['badgeImg'];} else {$badgeImg = "";}

$sql = "INSERT INTO faceBadge  (salesperson, salesID, salesEmail, bizName, bizType, badgeImg) VALUES  ('"$salesperson"', '"$salesID"', '"$salesEmail"', '"$bizName"', '"$bizType"', ' "$badgeImg"') ";
?>

Thanks😕

coldwerturkey

you're missing the . after '" ie; '".$var."'

examancer

and it looks like you have an extra space in the last value of your SQL query

coldwerturkey

just another note, you may want to look into mysql_real_escape_string() to escape the posted data before insertion.

(This isn't really necessary but I'm rather bored this week) -assuming this is all your $_POST data, you can use the following to make your code a lot similar since your form names match that of your variables. additionally you may want to look into preforming a verification / validation / checking or the posted data, ie; make sure fields aren't blank, etc

<?php 
error_reporting(E_ALL); 
ini_set('display_errors', '1'); 
include("../inc/dbConnect.php"); 

if(isset($_POST['salesperson'])) { 
	foreach ($_POST as $k => $v) { 
	    ${$k} = (isset($v)) ? mysql_real_escape_string($v) : ''; 
	} 

$sql = "INSERT INTO 
faceBadge 
(salesperson, salesID, salesEmail, bizName, bizType, badgeImg) 
VALUES 
('".$salesperson."', '".$salesID."', '".$salesEmail."', '".$bizName."', '".$bizType."', '".$badgeImg."')"; 
}
?>

bradgrafelman

Doing a foreach() on the $_POST array itself is never recommended because you destroy the data's original format.

What if you also wanted to output the data on the webpage as well? You'd see something like: Thanks for submitting something about John\'s Soup Kitchen!