works in php4 but not 5

jupiter163

This was working fine on PHP 4. I can't seem to figure out why this isn't working with PHP 5. It is a simple login that is supposed to set a cookie. I appreciate any help.

This is the code at the top of the page:

<?php
// write form data to a text file (with login) by Ryan Wells


// this is the cookie to check for to see if they are logged in
$formuser = $_POST["formuser"];
$formpass = $_POST["formpass"];
$formpass = md5($formpass);

// if the corect login info. is present in the form fields
if($formuser && $formpass) {
    setcookie("cookuser");  

    setcookie("cookpass"); 

// write the login data to the cookie
setcookie("cookuser", $formuser); 
setcookie("cookpass", $formpass); 

// after logging in, move to this page
header("Location: ens_form.php");
}
else { 
// not logged in
include("includes/config.php");
?>

This is the code in the body of the page:

<?php
    echo($no_pass_or_user_error_message);
    }?>

<div id="loginbox">
<form id="form1" name="form1" method="post" action="login.php">
<p>Username:<br>
<input name="formuser" type="text" id="formuser" class="input" size="20">
</p>
<p>Password:<br>
<input name="formpass" type="password" id="formpass" class="input" size="20">
<br>
<input type="submit" name="Submit" value="Login"> </p>
</form>
</div>

This is the code for the config.php file:

<?php
// write form data to a text file (with login) by Ryan Wells


// Admin Username and password
$adminuser = "demo";
$adminpass = "test";

// error message variables
$not_logged_in_message_error_message = "<p>Error: You Are not logged in. Go back and try again.</p>"; 
$incorrect_error_message = "<p>Incorrect Username and/or Password. Please go back and try again.</p>"; 
$no_pass_or_user_error_message = "<p>Incorrect username and/or password. Please try again.</p>";

// The first page you want the script to go to after logging in.
$first_page = "ens_form.php";
?>

dagon

what exactly is not working? what happens? what do you expect to happen?

jupiter163

dagon;10898482 wrote:
what exactly is not working? what happens? what do you expect to happen?

It should set a cookie (login) and redirect to the page ens_form.php.

dagon

well at a guess its failing here:

if($formuser && $formpass) {

so either $formuser or $formpass is not true

jupiter163

dagon;10898489 wrote:
well at a guess its failing here:

if($formuser && $formpass) {

so either $formuser or $formpass is not true

Would there be a reason that the above code runs smoothly with PHP 4 but not with 5?

Thanks.

dagon

not that i can think of, are those vars being set?

NogDog

Start each script with the following to see if PHP has anything useful it's trying to tell you:

<?php
ini_set('display_errors', 1); // set to zero in production version
display_errors(E_ALL);

Weedpacket

Well, $formpass will certainly be set when that test is reached, but it may be to d41d8cd98f00b204e9800998ecf8427e (and yes, you can stick that into Google to find out why - one more reason not to use MD5).

jupiter163

The error reporting showed:

Notice: Undefined index: formuser in D:\Inetpub\wwwroot\ens\login.php on line 8

Notice: Undefined index: formpass in D:\Inetpub\wwwroot\ens\login.php on line 9

Which is:

$formuser = $_POST["formuser"];
$formpass = $_POST["formpass"];

NogDog

So the good news is we know where the problem is. Now the question is, "Why?".

Try sticking this at the top if the script that is failing, and let's see what $POST values -- if any -- are actually being received by the script:

<?php
// debug code, comment out or delete when done debuggning:
echo "<pre>".print_r($_POST, 1)."</pre>";
exit;
// end debug code

If there is data, make sure the array indexes match what you are using in your code, including upper-/lower-case letters.

If the $_POST data is empty, then the problem is either in the form that is submitting to this page, or something in the web server. (I suppose it could be something in the PHP installation, too, though I have no idea what that would be.)

If the $_POST data looks correct, then make sure you're not blowing it away somehow before those lines in question are executed (though based on the code you've shown so far I don't see where that would happen).