[RESOLVED] Error in line 52 of my code

[Talonos]

Parse error: syntax error, unexpected T_STRING, expecting ',' or ';' in roster.php on line 52

which is the line that includes

echo "<td align=left bgcolor=#040404 id='title'> <a href=\"" . $network  . $title . "\" class="wat_tip wat_auto_icons" rel="char" title="stormrage:$title">$title</border=0></td>";

echo "<tr >";
echo "<td align=left bgcolor=#040404 id='title'> <a href=\"" . $network  . $title . "\" class="wat_tip wat_auto_icons" rel="char" title="stormrage:$title">$title</border=0></td>";
echo "<td align=left bgcolor=#040404 id='title'>&nbsp;<font face='arial,verdana,helvetica' color='#56571b' size='2'>$role</font></td>";
echo "<td align=left bgcolor=#040404 id='title'>&nbsp;<font face='arial,verdana,helvetica' color='#56571b' size='2'>$normal</font></td>";
echo "<td align=left bgcolor=#040404 id='title'>&nbsp;<font face='arial,verdana,helvetica' color='#56571b' size='2'>$best</font></td>";
echo "<td align=left bgcolor=#040404 id='title'>&nbsp;<font face='arial,verdana,helvetica' color='#56571b' size='2'>$warnings</font></td>";
echo "<td align=left bgcolor=#040404 id='title'>&nbsp;<a href=http://be.imba.hu/?zone=EU&realm=stormrage&character=$title><img src="imba.bmp" border=0 alt="Imba"></td>";
echo "<td align=left bgcolor=#040404 id='title'>&nbsp;<a href=http://www.wowjuju.com/index.php?page=6#EU_stormrage_$title > <img src="wowjuju.bmp" border=0 alt="Wowjuju "></td>";
echo "<td align=left bgcolor=#040404 id='title'>&nbsp;<a href=http://www.wow-heroes.com/><img src="wow.bmp" border=0 alt="Wow-Heroes"></td>";
echo "<td align=left bgcolor=#040404 id='title'>&nbsp;<a href=http://stormrage-eu.warcrafter.net/$title ><img src="warcrafter.bmp" border=0 alt="Warcrafter"></td>";
echo "</tr>";

could anyone please help me resolve this issue

[laserlight]

Good to see that you posted using the php bbcode tags. Now, take a look at the syntax highlighting. It should become obvious that you forgot to concatenate the strings correctly, e.g., you have "wat_tip wat_auto_icons" appearing out of nowhere.

[Talonos]

ok so i've cleaned the line up a little but the class part i hav to keep in for a java script include to work but to no prevail once again 😕

i'll type out how the line is actually meant look without the vars in it

echo "<td align=left bgcolor=#040404 id='title'> <a href="" class="wat_tip" rel="char" title="stormrage:talonos">talonos</border=0></td>";

echo "<td align=left bgcolor=#040404 id='title'> <a href="" class="wat_tip" rel="char" title="stormrage:$title">$title</border=0></td>";

if u could explain a little more into detail that would be appreciated allot as i'm a real php newb thank you

[laserlight]

I would write it this way:

echo '<td align="left" bgcolor="#040404" id="title"> <a href="" class="wat_tip" rel="char" title="stormrage:' . htmlspecialchars($title) . '">' . htmlspecialchars($title) . '</a></td>';

Note that I used single quotes to delimit the strings with double quotes to quote the attribute values in HTML, then I used [man]htmlspecialchars/man to escape the variable values for printing. I also corrected your </border=0> to </a>.

[Talonos]

sorry to disturb you once again but i've tried incorperating your fix into another line but now i'm getting the same error as before but this time a var is including a web address

current code

echo "<td align=left bgcolor=#040404 id='title'> <a href=" . htmlspecialchars($imba) . htmlspecialchars($title) . "</a><img src="imba.bmp" alt="Imba"</img></td>";

outcome should be

echo "<td align=left bgcolor=#040404 id='title'> <a href="http://be.imba.hu/?zone=EU&realm=stormrage&character=Talonos"</a><img src="imba.bmp" alt="Imba"</img></td>";

or a working outcome as this line is used a few times in my table just diffrent address's

n hopefully once this is done i should stop being a newbie for some while as it should be working then

[laserlight]

hmm... looks like you still did not get the crux of the problem. Consider this part of the code:

htmlspecialchars($title) . "</a><img src="imba.bmp" alt="Imba"</img></td>"

So, you have the output of a function, htmlspecialchars($title). This is concatenated with the string literal "</a><img src=". Then out of nowhere you have this piece of code: imba.bmp

Can you see that imba.bmp is not within a string literal? It is out of place, and hence results in a parse error.

Personal taste aside, I recommend using double quotes to quote your HTML element attribute values because htmlspecialchars() does not escape single quotes by default. If you use double quotes to quote your HTML element attribute values, then it follows that using single quotes to quote the PHP strings that contain the HTML code makes things easier (and vice versa).

In your case, you are inconsistently not quoting your HTML element attribute values (a Bad Thing), quoting them with single quotes, and quoting them with double quotes. This gets you into trouble when you fail to correctly escape the quotes in the PHP string.

[Talonos]

THANK YOU laserlight got my script working brilliant now all because of you kudo to you 🙂

[laserlight]

No problem and you're welcome 🙂
The code is actually working mostly because you wrote it 😉
Remember to mark this thread as resolved (if it is) using the thread tools.