[RESOLVED] Parse Error

Dragoon1

I'm trying to make a registration script, but when I try to add the new user to the database I get a parse error

Parse error: parse error in C:\wamp\www\big_sports\Register.php on line 23

heres the page of code

<?php

session_start();

require("./Database.php");
require("./functions.php");

	if(isset($_POST['submit'])) {

		$db = new Database();

		$User = 'username';
		$Password = encrypt('password');
		$RePassword = encrypt('repassword');

		$result = $db-> query('SELECT * FROM big_sports.Customers');
		while($row = mysql_fetch_array($result) ) {
			if($User == $row['username'] ) {
			echo "That username is already taken";
				} 
			else if('$Password' == '$RePassword') {
					mysql_query('INSERT INTO `Customers` (`Username`,`Email`,`Password`) VALUES($User,'email',$Password)'));
					echo "You've Been registered";
				}
			//else { echo 'your passwords do not match';}
	}
}

//If logged in the redirect back to the admin page
/*else if($_SESSION['LoggedIn'] == TRUE) {
	//Redirect with javascript

	echo('<script type="text/javascript">
			<!--
				window.location = "../"
			//-->
		</script>');

}*/

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Register</title>
</head>

<body>

<h3>Register</h3>
<br />
		&nbsp;
		<br />

		<form id="Register" name="Register" method="post" action="<?php $_SERVER['PHP_SELF'];?>">
			<table>
				<tr>
					<td>Username </td>

					<td><input type="text" name="username" id="username" /></td>
				</tr><tr>
					<td>Email </td>

					<td><input type="text" name="email" id="email" /></td>
				</tr>
				<tr>
					<td>Password </td>

					<td><input type="password" name="password" id="password" /></td>
				</tr>
                <tr>
					<td>Re-Type Password </td>

					<td><input type="password" name="repassword" id="repassword" /></td>
				</tr>
				<tr>
					<td colspan="2" align="right"><input type="submit" name="submit" id="submit" value="Submit" /></td>
				</tr>
			</table>
		</form>

</body>
</html>

Line 23 is

mysql_query('INSERT INTO Customers (Username,Email,Password) VALUES($User,'email',$Password)'));

Weedpacket

Using the forum's [php]...[/code] tags (which do the same syntax highlighting as PHP's own [man]highlight_string[/man] function) gives line 23 as:

mysql_query('INSERT INTO `Customers` (`Username`,`Email`,`Password`) VALUES($User,'email',$Password)'));

And the problem immediately leaps out as being the quotes around 'email'. The extra ")" would also cause trouble.

Because you've got variables in the string, you'll want to use double quotes around it. And because (I'm guessing) $User and $Password aren't plain numbers, you'll want single quotes around them so the database doesn't choke.

mysql_query("INSERT INTO `Customers` (`Username`,`Email`,`Password`) VALUES('$User','email','$Password')");

Dragoon1

thank you, that fixed it.