The if statement - again

[dcjones]

hi all,

I have a script that read the content of a SESSION var. depending on the content one of three pages are displayed.

My code is:

if($_SESSION['coupondis'] = "1") {
$t->display("thanks_1.html");
} elseif($_SESSION['coupondis'] = "2") {
$t->display("thanks_2.html");
} else {
$t->display("thanks_3.html");
}

My problem is:

If the SESSION var contains "1" thanks_1.html is displayed.

If the var contains 2, the thanks_1.html page is displayed.

If the var contains 3, the thanks_3.html page is displayed.

If I remove the first IF STATEMENT it work fine.

Can anyone see where I am going wrong, I have been playing around for hours on such a simple if statement.

[djjjozsi]

if you use if , then use double = signs in IF conditions!

if you want to make complicated IF's, then use SWITCH case.

hy, jjozsi.

[bradgrafelman]

To elaborate, this statement:

if($_SESSION['coupondis'] = "1")

First assigns a value to the $_SESSION['coupondis'] variable, and then evaluates that value as a boolean (so pretty much anything other than a 0, '0', false, '', NULL, etc. results in boolean true and thus the if() block is executed).

If what you instead intended to do was compare the value that the variable already contains, then djjozsi is correct in suggesting the '==' comparison operator, NOT the '=' assignment operator.

For more information about the different operators and what they mean, see this manual page: [man]operators[/man].

[ixalmida]

To elaborate further, better yet would be:

switch($_SESSION['coupondis'])
  {
  case "1":
    $t->display("thanks_1.html");
    break;
  case "2":
    $t->display("thanks_2.html");
    break;
  default:
    $t->display("thanks_3.html");
  }

Why? Because switch() is generally faster than if(), and because it makes sense if you have mutually exclusive values to test for.