[RESOLVED] NEED HELP WITH THE DUMBEST SCRIPT EVER

spire_bt

this script should select from DB max 2500 users who have email like
$theHosts array and insert them into another table but it is not selecting the email that i have specified it just takes random emails

<?php

$host = "*****";
$database = "******";
$user = "*****";
$password = "*******";

$connection = mysql_connect ( $host, $user, $password ) or die ( 'Error connecting' . mysql_error () );
mysql_select_db ( $database, $connection ) or die ( "Error conecting to database" );



$theHosts = array ("talktalk.net", "hotmail.co.uk", "yahoo.com", "aol.com", "hotmail.co.uk", "sneakemail.com", "hotmail.com", "yahoo.co.uk", "gmail.com");
$a = array ( );
for($i = 0; $i < sizeof ( $theHosts[$i] ); $i ++) {


$query = mysql_query ( "SELECT * FROM `mdraw_users_all` WHERE `email` LIKE '%$theHosts[i]%' LIMIT 2500" );

}


while ( $row = mysql_fetch_array ( $query ) ) {


print_r($row);
$row[uniqid]= md5($row[uniqid].time());

$query1 = mysql_query ( "INSERT INTO `martin_server`.`mdraw_users_all_2000` (`uniqid` ,`age_bracket` ,
`status` ,`owners` ,`firstname` ,`lastname` ,`hometel` ,`mobile` ,`email` ,`postnumber` ,`regdate` ,`password` ,
`address` ,`dob` ,`gender` ,`cosignup` ,`source` ,`bounce_type` ,`days` ,`signup_date` ,`parked_user` ,`microtemp_id` ,
`questionairtemp_id` ,`hard_bounce` ,`bounce_date`) VALUES ('addslashes($row[uniqid])','addslashes($row[age_bracket])',
'addslashes($row[status])',addslashes('$row[owners])','addslashes($row[firstname])','addslashes($row[lastname])','addslashes($row[hometel])','addslashes($row[mobile])','addslashes($row[email])',
'addslashes($row[postnumber])','addslashes($row[regdate])','addslashes($row[password])','addslashes($row[address])','addslashes($row[dob])','addslashes($row[gender])','addslashes($row[cosignup])',
'addslashes($row[source])','addslashes($row[bounce_type])','addslashes($row[days])','addslashes($row[signup_date])','addslashes($row[parked_user])','addslashes($row[microtemp_id])',
'addslashes($row[questionairtemp_id])','addslashes($row[hard_bounce])','addslashes($row[bounce_date])')");

}


?>

😕😕😕

Elad_Nava

First, instead of that pointless for() loop, why not loop over the entire array with foreach()? You don't have to mess with any index, you just set up a handle for the key or value of each element.

foreach ( $theHosts as $host )
{
    $query = mysql_query ( "SELECT * FROM `mdraw_users_all` WHERE `email` LIKE '%{$host}%' LIMIT 2500" );
}

What is the purpose of the $a variable?
What is $row[uniqid]? Are you trying to access a value in a column that was returned by the query? But you haven't given mysql_fetch_array() the second parameter of MYSQL_ASSOC to return an array of column => value.

djjjozsi

this script will select your array index number * 2500 email ...

its incorrect:

'addslashes($row[status])',addslashes('$row[owners])','addslashes($row[firstname])'

use this:

$row=array_map("addslashes",$row);

see the manual how that's work..

Weedpacket

Also note that the first loop (either way it's written, though Elad Nava's is cleaner and fixes one of your mistakes)

foreach ( $theHosts as $host )
{
    $query = mysql_query ( "SELECT ..." );
}

Each time you go through the loop, you overwrite the value of $query with whatever was there before - without doing anything with it. You make all those selects but you just throw all of the results but the last one away. The loop controlling the insert should be inside the loop doing the select so that you do all the necessary inserts for each select.

In fact all this is a massive waste of time, processing and coding, and both loops are unnecessary. You can write both statements together and put the results of the SELECT directly into the INSERT. Check MySQL's documentation about how to use "INSERT INTO ... SELECT".

hypernol

I am just learning all of this, but I have a question. Where you have $a = array ();

I noticed that you have $i everywhere, but $a is nowhere to be found? Could it be as simple as that?

spire_bt

$a is used in other part of the code that i have if u want i can send u the full code
but that part works perfectly it is used to read emails from a txt file and insert them in the same TABLE as the previous
THX for the help to all

Piranha

Why do you use PHP to handle the insert? I would do it in the database:

INSERT INTO new_table (id, name, email)
SELECT id, name, email
FROM old_table
WHERE something

Look in the MySQL manual to find out more about INSERT INTO ... SELECT.

spire_bt

$row[uniqid] is a field that I am taking from the first table and inserting it's value in the second but it is given like a integer and I have to make it md5 before inserting it in the second table
I can't test the foreach until 26th so I will send my next post then

spire_bt

Piranha;10900550 wrote:
Why do you use PHP to handle the insert? I would do it in the database:
INSERT INTO new_table (id, name, email)
SELECT id, name, email
FROM old_table
WHERE something
Look in the MySQL manual to find out more about INSERT INTO ... SELECT.

because there are a lot of emails and i have to use only those who i want, that will be later put from a textbox and the script will work on submit button

its like this u want to select specific emails and limit there number and copy them in other table also u want to read email from a file and do the same so u put something in the textbox field limit there number or upload a file and just click submit ... process finishes

Piranha

spire_bt;10900551 wrote:
$row[uniqid] is a field that I am taking from the first table and inserting it's value in the second but it is given like a integer and I have to make it md5 before inserting it in the second table
I can't test the foreach until 26th so I will send my next post then

Why do you want to use md5? From wikipedia:

However, flaws in MD5 have been used to break real-world systems which rely on it, which argues strongly against using or supporting the algorithm in new applications.

spire_bt

man i only do what i am told to if they want md5 field then i have to make ti

Piranha

spire_bt;10900552 wrote:
because there are a lot of emails and i have to use only those who i want, that will be later put from a textbox and the script will work on submit button

its like this u want to select specific emails and limit there number and copy them in other table also u want to read email from a file and do the same so u put something in the textbox field limit there number or upload a file and just click submit ... process finishes

I didn't mean why you use PHP, it is a good way to handle input.

I ment why don't do you the copying between tables in the database, with a SQL question created in PHP. The only thing I can see that you do is using md5, you can do that in the database as well as in PHP. If you even want it, look at my other answer for that.

Piranha

spire_bt;10900554 wrote:
man i only do what i am told to if they want md5 field then i have to make ti

If I got that assignment I would point out the problems with md5 and offer an alternative. If they still want md5 it is their problem.

spire_bt

Piranha;10900556 wrote:
If I got that assignment I would point out the problems with md5 and offer an alternative. If they still want md5 it is their problem.

well that's the case here so the cryptographic will not be my problem:queasy:

Weedpacket

spire_bt;10900552 wrote:
because there are a lot of emails and i have to use only those who i want, that will be later put from a textbox and the script will work on submit button

Yes; so you put the conditions that that state which emails you want into the SELECT query. Have a look at the MySQL manual to see what it says about INSERT ... SELECT.

spire_bt

thx dudes for all your help only thing was the foreach 😃