[RESOLVED] Just wanted a second opinion

[hypernol]

I was hoping someone may tell me what is missing, or what may be wrong.

if ($player->rank == `Member`);

{
	$query = $db->execute("update `players` set `turns`=turns + 15");
	brake;
{

else if ($player->rank == `Ghetto`);
{
	$query = $db->execute("update `players` set `turns`=turns + 30");
	brake;
{

else if ($player->rank == `Player`);
{
	$query = $db->execute("update `players` set `turns`=turns + 45");
	brake;
}

else if ($player->rank == `Pimp`);
{
	$query = $db->execute("update `players` set `turns`=turns + 60");
	brake;
}

else if ($player->rank == `OG`);
{
	$query = $db->execute("update `players` set `turns`=turns + 100");
	brake;
{  /PHP]

[dagon]

Switch would be a preferable structure, and you should have some sort of default if $player->rank is none of thoses listed

[hypernol]

So you think this would be better?

$sub = ($player->rank);

switch ($sub)
{

case ($sub == 'Member')

	$query = $db->execute("update `players` set `turns`=turns + 15");

	brake;

case ($sub == 'Ghetto');

	$query = $db->execute("update `players` set `turns`=turns + 30");

	brake;

case ($sub == 'Player');

	$query = $db->execute("update `players` set `turns`=turns +45");

	brake;

case ($sub == 'Pimp');

	$query = $db->execute("update `players` set `turns`=tunrs + 60");

	brake;

case ($sub == 'OG');

	$query = $db->execute("update `players` set `turns`=turns + 100");

	brake;

default :

	echo "Well hell, that didn't work! What's next?"

	brake;

}	

[hypernol]

Something in that code is flawed. Anyone feel like playing Where's Waldo? If you could point out my mistake, I would be glad to figure out how to go about fixing it 😃

[hypernol]

Just so everyone knows, I did notice the lack of the ";" after the echo on the default section. However, I was unable to correct this once I found it due to the edit limit had already passed.

I have already fixed this in my script, but unfortunately it did not help solve the issue.

[dagon]

check the manual page again that's not the correct switch syntax

[djjjozsi]

with switch case example

switch($player->rank)
{
case "value1":
$query = $db->execute("update `players` set `turns`=turns + 100");
break;

case "value2":
$query = $db->execute("update `players` set `turns`=turns + 100");
break;

default:
$query = $db->execute("update `players` set `turns`=turns + 100");
}

AND check the queries!
turns=tunrs

[hypernol]

Ok, so what you are suggesting is more like this?

switch ($player->rank)

{
case "Ghetto":

$query = $db->execute("update `players` set `turns`=turns + 30");
brake;

case "Player":

$query = $db->execute("update `players` set `turns`=turns + 45");
brake;

case "Pimp":

$query = $db->execute("update `players` set `turns`=turns + 60");
brake;

case "OG":

$query = $db->execute("update `players` set `turns`=turns + 100");
brake;

default:

$query = $db->execute("update `players` set `turns`=turns + 15");
brake;
}

[hypernol]

Ok, the above actually works. Well, kind of. For some reason it is only pulling the default.

I have several test accounts set up. One with each value in the rank table. But, the script is only adding the default turns amount to each account. Any suggestions?

[coldwerturkey]

solution: learn how to spell break.

[hypernol]

Wow, lol. Brain fart. Must have had something to do with me having to change my brakes yesterday..lol

However, that still does not solve the issue. Even after changing all of the brakes to breaks, I the default is the only query that will execute.

[Piranha]

If you echo the value of $player->rank before the switch, what do you get?

[hypernol]

Well, after a lot of trial and error...

I am proud to say that I found a solution that works.

Even though I have it figured out, I would still like for anyone that thinks it can be refined please add your input.

$query = $db->execute("select * from `players` where `id`");

$player1 = $query->fetchrow();
foreach($player1 as $key=>$value)
{
	$player->$key = $value;
}

switch ($player->rank) 

{ 
case "Ghetto": 

$query = $db->execute("update `players` set `turns`=turns + 30"); 
break; 

case "Player": 

$query = $db->execute("update `players` set `turns`=turns + 45"); 
break; 

case "Pimp": 

$query = $db->execute("update `players` set `turns`=turns + 60"); 
break; 

case "OG": 

$query = $db->execute("update `players` set `turns`=turns + 100"); 
break; 

default: 

$query = $db->execute("update `players` set `turns`=turns + 15"); 
break; 
} 

I am grinning from ear to ear right now..lol

[hypernol]

Well, I thought I had it. When I tested it I thought it worked correctly. However, it is still only adding 15 points to all players.

I tried taking out the:

 

default: 

$query = $db->execute("update `players` set `turns`=turns + 15"); 
break;

with:

case "Member";

$query = $db->execute("update `players` set `turns`=turns + 15"); 
break;

 

Trying to see if taking out the default aspect. Thinking that either it would die or pick a case.

Well it picked a case, but it is still defaulting to the + 15.

Piranha, when you say echo prior to the switch, could you possibly clerify?

I tried

echo ($player->rank);

But that didn't do anything. It actually killed the script.

[hypernol]

I thought that maybe the script was just executing the last query in the script. So, I moved the case "member" to the top, then to the middle, and there is not any change it still only executes the member case..

[Weedpacket]

hypernol wrote:

$query = $db->execute("select * from `players` where `id`"); 

Where id is what?

Question: do you know all the possible ranks that the player may have? If so, then the default: is unnecessary - list explicitly all of the possible ranks.

In fact, if you know all of the ranks then, because the code is so similar, the switch is just extra work.

$turn_increases = array(
'Ghetto' => 30,
'Player' => 45,
//...
);

$query = $db->execute("update `players` set `turns`=turns + ".$turn_increases[$player->rank]);

In fact, that array could be stored as a table in the database as well. Calling the table ranks, make the "rank" column the primary key, set up a foreign key relationship between it and the "rank" column of the players table. Add a column for "increase" (and other columns if desired to store other information about each rank).

Then all your code would be replaced with:

$query = $db->execute("update players set turns=turns+(select increase from ranks where players.rank=ranks.rank");

[hypernol]

Well, weed. You got me all excited. Both of the solutions seemed like simple compact solutions.

Since I didn't know anything about setting up foreign keys, I decided to first try your initial proposal.

My first attempt being:

<?php
$config_server = "******"; //Database host
$config_database = "********"; //Database name
$config_username = "********"; //Database username
$config_password = "********"; //Database password
$secret_key = "*******"; //Secret key, make it a random word/sentence/whatever



include('../adodb/adodb.inc.php'); //Include adodb files
$db = &ADONewConnection('mysql'); //Connect to database
$db->Connect($config_server, $config_username, $config_password, $config_database); //Select table

$db->SetFetchMode(ADODB_FETCH_ASSOC); //Fetch associative arrays
$ADODB_FETCH_MODE = ADODB_FETCH_ASSOC; //Fetch associative arrays
//$db->debug = true; //Debug

$turn_increases = array(
'Member' => 15,
'Ghetto' => 30,
'Player' => 45,
'Pimp' => 60,
'OG' => 100,
//...
);

$query = $db->execute("update `players` set `turns`=turns + ".$turn_increases[$player->rank]);

?>

Well, that returned no results at all. My script was at least adding something to the turns, this did nothing.

So, I then decided to go and learn a bit about setting up foreign keys in phpmyadmin.

After about 5 articles on the subject and then one video tutorial, I was able to figure out how that worked. So, I set up the table 'ranks' added both 'rank' and 'increase' to the table while making 'rank' the primary.

I then inserted 5 new values to each row, 1 for each rank. Setting "Member" as the default. Once I had all of those done, I went and set the foreign key relationship between <b>players->rank </b>and <b>ranks->rank</b>.

Once I had all of the tables setup, I created to php script like so....

<?php
$config_server = "******"; //Database host
$config_database = "******"; //Database name
$config_username = "*******"; //Database username
$config_password = "********"; //Database password
$secret_key = "********"; //Secret key, make it a random word/sentence/whatever



include('../adodb/adodb.inc.php'); //Include adodb files
$db = &ADONewConnection('mysql'); //Connect to database
$db->Connect($config_server, $config_username, $config_password, $config_database); //Select table

$db->SetFetchMode(ADODB_FETCH_ASSOC); //Fetch associative arrays
$ADODB_FETCH_MODE = ADODB_FETCH_ASSOC; //Fetch associative arrays
//$db->debug = true; //Debug



$query = $db->execute("update players set turns=turns+(select increase from ranks where players.rank=ranks.rank");

?>

I was sure to check and recheck everything before bringing it back here. I made sure that the foreign keys were set, the ranks in each 'rank' table matched to the letter.

And yet, I couldn't get that to work either.

My current update script looks like this.

<?php
$config_server = ""; //Database host
$config_database = ""; //Database name
$config_username = ""; //Database username
$config_password = ""; //Database password
$secret_key = ""; //Secret key, make it a random word/sentence/whatever



include('../adodb/adodb.inc.php'); //Include adodb files
$db = &ADONewConnection('mysql'); //Connect to database
$db->Connect($config_server, $config_username, $config_password, $config_database); //Select table

$db->SetFetchMode(ADODB_FETCH_ASSOC); //Fetch associative arrays
$ADODB_FETCH_MODE = ADODB_FETCH_ASSOC; //Fetch associative arrays
//$db->debug = true; //Debug



$query = $db->execute("update `players` set `turns`=turns + 15");





?>

I have it set on a cronjob to execute every 10 minutes and it works like a champ. I just got it working yesterday. I have since got my subscriptions set up and it is time to get the turns to update each rank respectively.

I will not let it beat me, I will keep working on it. If someone see's something they think can resolve the issue, please add your input.

[Piranha]

hypernol;10900485 wrote:

Piranha, when you say echo prior to the switch, could you possibly clerify?

I tried

echo ($player->rank);

But that didn't do anything. It actually killed the script.

I think that maybe you don't have a value in the variable you use switch on. The idea is to place the echo just before the switch, checking if you actually have a value in the variable. If you have it, fine. If you don't have a value then the error is somewhere else in the code.

[hypernol]

Ok Piranha, you were right. I took everything out and checked if echo would produce any thing.

It did not.

So, I started thinking of how i could get this to work right. I tried a few things, but nothing worked. So, I shut the computer and decided to just leave it alone for a while. Then all of a sudden it hit me.

What I did was just set another row in players called increase. Then went and inserted the proper increase for each player.

Then I wrote:

<?php
$config_server = "*******"; //Database host
$config_database = "*******"; //Database name
$config_username = "*******"; //Database username
$config_password = "********"; //Database password
$secret_key = "********"; //Secret key, make it a random word/sentence/whatever



include('../adodb/adodb.inc.php'); //Include adodb files
$db = &ADONewConnection('mysql'); //Connect to database
$db->Connect($config_server, $config_username, $config_password, $config_database); //Select table

$db->SetFetchMode(ADODB_FETCH_ASSOC); //Fetch associative arrays
$ADODB_FETCH_MODE = ADODB_FETCH_ASSOC; //Fetch associative arrays
//$db->debug = true; //Debug


$query = $db->execute("update `players` set `turns`=turns + increase");

?>

This actually works perfect. Now, I will just set up my subscription scrip to set both rank and increase to the proper setting for the purchased subscription.

Thank you all very much for your help.

Weed, I think it was your last idea that got me where I am. I know I did it different than what you said, but this is what worked for me. Thank you for your guidance.