Commision Script

PierreL

Hi Guys

I'm pretty new to PHP and need desperate help to modify a function. This function calculates commision for an auction.


   function vbccalc_commission($vbc_finalprice, $vbcomm_increments){
      settype($vbc_finalprice, "float");

  // Build the Commissions Structure
  $vbcomm_inc = explode("\n", $vbcomm_increments);
  $vbccomm_index = '0';
  foreach($vbcomm_inc AS $vbcomm_inc_bit){
     $vbccomm_bit = explode("|", $vbcomm_inc_bit);
     $vbccomm_index++;
     $vbccomm_level[$vbccomm_index] = $vbccomm_index;
     settype($vbccomm_bit[0], "float");
     $vbccomm_price[$vbccomm_index] = $vbccomm_bit[0];
     settype($vbccomm_bit[1], "float");
     $vbccomm_fee[$vbccomm_index] = $vbccomm_bit[1];
     $max = $vbccomm_index;
  }

  $count = $max;
  $vbcomm_sum = '0';
  while ($count > 0) {
     if($vbc_finalprice >= $vbccomm_price[$count]){
        $vbcomm_step = $vbc_finalprice - $vbccomm_price[$count];
        $vbcomm_bit = $vbcomm_step * $vbccomm_fee[$count];
        $vbcomm_sum = $vbcomm_sum + $vbcomm_bit;
        $vbc_finalprice = $vbc_finalprice - $vbcomm_step;
     }
     $count--;
  }
  $vbc_commission = $vbcomm_sum;
  return $vbc_commission;
}

The $vbcomm_increments is not needed anymore. The new commision structure can be hard coded. $vbcomm_increments allowed you to modify the script but the modifier can not do what i want the script to do. Below is an example of what i want this script to do

Listing fee for all items is R 15.00
Goods listed from R 0.01 - R 500.00, only the listing fee has to be paid.
From R 500.01 - R 10 000.00, listing fee + 5%
From R 10 000.01 and above, listing fee + 3%

Examples

You sell a fly box with flies for R 200.00, the fee is the listing fee of R 15.00
You sell a rod for R 600.00, the fee is the listing fee (R 15.00) + 5% of R 600.00 (R 30.00) = R 45.00
You sell a Sage for R 1200.00, the fee is the listing fee (R 15.00) + 5% of R 1200.00 (R60.00) = R 75.00
You sell your vehicle for R 50 000.00, the fee is the listing fee (R15.00) + 3% of R 50 000.00 (R 1500.00) = R 1515.00

The guy that wrote this mod for an auction scripts is not supporting this anymore and is un available which leaves me in a bad spot not being able to launch. :mad:

I would be really gratefull if someone can help me out.

Thanks in advance

All the best

Pierre

Krik

That script seems a bit over complicated.

A simple if, elseif, else with some basic math would do the trick.

Now I do get the sense that the form submitting the data is submitting multiple entries. And if that is the case it will require a bit of looping through the submitted info with "foreach" or "while" loop to get the all the commission values. And that requires a bit more info on how the data is entered and sent to the function to guide you towards a good solution.

But no matter what that function you have there is doing more work than it needs to or there is something else it does as well.

PierreL

Hi Krik

This is how the fee structure is managed. But this is not needed anymore and can be removed from the script.

0|0.0500
250|0.0400
5000|0.0350

For example, the default fee structure is set up as follows:

0|0.0600
50|0.0375
1000|0.0100

$0.01 - $50.00
6.00% of the closing value

$50.01 - $1,000.00
6.00% of the initial $50.00, plus 3.75% of the remaining closing value balance ($50.01-$1,000.00)

Equal to or Over $1,000.01
6.00% of the initial $50.00, plus 3.75% of the initial $50.01-$1,000.00, plus 1% of the remaining closing value balance ($1,000.01 - closing value)

That is what the top part of the script does, the bottom paret calculates the value.

I'm going to give this a bash and post my code here for if you guys can comment.

PierreL

HI Guys

Ok i've tried to nail this. But how do you place two >< in one if statement ?


$vbc_finalprice = 200.00;

		if($vbc_finalprice <= 500.00)
		     {
               $vbcomm_sum = 15.00;

			    }else if ($vbc_finalprice >= 500.01 && $vbc_finalprice <= 10000.00){

			       $vbcomm_sum = $vbc_finalprice * (1 - 0.05) + 15.00;

			     }else($vbc_finalprice >= 10000.01){

                   $vbcomm_sum = $vbc_finalprice * (1 - 0.03) + 15.00;

			     }

			   $vbc_commission = $vbcomm_sum;
			   return $vbc_commission;

			   print "$vbc_commission";

PHP does not seem to like this, but you get what i am trying to do here


else if ($vbc_finalprice >= 500.01 && $vbc_finalprice <= 10000.00)

Cheers

PierreL

ok i think i've cracked it


if(($vbc_finalprice >= 0.01) and ($vbc_finalprice <= 500.00))
			     {
                   $vbcomm_sum = 15.00;

			    }else if (($vbc_finalprice >= 500.01) and ($vbc_finalprice <= 10000.00)){

			       $vbcomm_sum = $vbc_finalprice * 0.05 + 15.00;

			     }else if($vbc_finalprice >= 10000.01){

                   $vbcomm_sum = $vbc_finalprice * 0.03 + 15.00;

			     }else{

				 $vbcomm_sum = 0;

				 }

			   $vbc_commission = $vbcomm_sum;
			   return $vbc_commission;

Krik

Couple tweaks to what you did there.

if(($vbc_finalprice >= 0.01) && ($vbc_finalprice <= 500.00)) {

 $vbcomm_sum = 15.00;

}
elseif (($vbc_finalprice >= 500.01) && ($vbc_finalprice <= 10000.00)) {

 $vbcomm_sum = ($vbc_finalprice * 0.05) + 15.00;

}
elseif ($vbc_finalprice >= 10000.01) {

 $vbcomm_sum = ($vbc_finalprice * 0.03) + 15.00;

}else{

 $vbcomm_sum = 0;

}

$vbc_commission = round($vbcomm_sum, 2);

Mostly just made changes for readability. Nothing worse than coming back a year or 2 down the road and it looks like you just threw something in place.

I did swap the "and" for "&&" there is a difference and if I am not mistaken it is generally better to use "&&".

Also in the math equations I placed (..) around the commission multiplication part as you will want that calculated done before the 15.00 is added. Also I believe it is a proper math formula to do it that way.

Also note I made the "else if" into "elseif" now php will just ignore whitespaces but the latter is the better syntax I believe.

As well notice I added the "round()" to the "$vbcomm_sum" so it rounds it off at the second decimal points. There is a few more options available for how it rounds the numbers off, for more information I would say take a look at php.net.

Lastly I removed the last line that had "return $vbc_commission" as it is not needed unless all that is inside a function.

But for the most part that is exactly what I was thinking you could do.