or die()

ignext

I have to build an application in which, until now I've used allot of mysql_query() or die().

Give me an idea/link/sample about how to replace this approach. I was thinking to save those errors as a log file or write them in a database.

Did you see something like this? I really don't know where/how to start

many thx

LiamBailey

I wrote a function to do that:

function error_file($the_error)

{

$handle = fopen('/files/home3/warpages/errors/errors.txt','w');

fwrite($handle,$the_error);

fclose($handle);

$mailto = "support@your-domain.com";

$subject = "error occured";

$headers = "From: errors@ptn-ccgi01.plus.net";

mail($mailto, $subject, $headers);

}

You then do:

$result = mysql_query($query) or die("Could not run query on database or whatever" . error_file(mysql_error()));

NogDog

You can check the result, and if false branch to however you want to handle it. For fatal errors you might want some sort of "system error" page to which you can redirect or simply include at the applicable point of failure.

$result = mysql_query($query);
if($result == false)
{
   error_log(mysql_error()."\n".$sql);
   $error = "There was a database error, which has been logged.";
   include 'path/to/error_page.php';
   exit;
}
// ...rest of script...
//

error_page.php:

<html><head>etc...
<body>
<h1>Some reassuring page title</h1>
<p class='error'><?php echo $error; ?></p>
<p>Stuff about how sorry you are, please try again, etc....</p>
</body>
</html>

LiamBailey

Thanks Nogdog, I didn't know about using false as a method of determining the failure of a query.

NogDog

LiamBailey;10900475 wrote:
Thanks Nogdog, I didn't know about using false as a method of determining the failure of a query.

That is actually what the or die() idiom is doing. "or" is a very low precedence operator, so everything to the left of it gets evaluated first. If it evaluates to something considered "true" (e.g. the mysql_query() returns a result resource), then there is no need to evaluate what is on the right of the "or" since an "or" condition is true if either side is true, and thus the die() is never executed. But, if the left side evaluates as false, then it looks at the right side to see what it evaluates to, which in this case is your die() expression.

ignext

wow
thx allot for the valuable replays.....are gold for beginners as I am

ignext

NogDog;10900472 wrote:
You can check the result, and if false branch to however you want to handle it. For fatal errors you might want some sort of "system error" page to which you can redirect or simply include at the applicable point of failure.
$result = mysql_query($query);
if($result == false)
{
   error_log(mysql_error()."\n".$sql);
   $error = "There was a database error, which has been logged.";
   include 'path/to/error_page.php';
   exit;
}
// ...rest of script...
//

hi there

that mysql_error() from error_log() is the same as in "or die(myqsl_error());"

NogDog

ignext;10901012 wrote:
hi there

that mysql_error() from error_log() is the same as in "or die(myqsl_error());"

Yes, it is. A function is a function no matter where you put it.