[RESOLVED] Output results in columns from MySQL using PHP, Nearly cracked it!!

[ade234uk]

I have managed to output the results in columns. I have nearly cracked it, but the part that is really stumping me here is being able to close the table properly at the end of while loop.

Any ideas what I am doing wrong here. It works fine apart from when the final result is outputted the code ends in <tr></tr></table>

// Output results in columns
echo "<table border=1 align=center><tr>";

$number_of_cols = 0;

// Request results from tables
$result = mysql_query("SELECT * FROM names");

while ( $row = mysql_fetch_array($result) )
{

// increment the counter
$number_of_cols++;

echo "<td width=\"200\">". $row['name'] ."</td>";

if ($number_of_cols == 2)
{
echo"<tr>";
$number_of_cols=0;
}

}
echo"</tr></table>";

[sneakyimp]

You need to put the logic for inserting <tr> and </tr> inside your while loop. You should also indent your code and use [ PHP ] tags around it so it gets formatted:

// Output results in columns
echo "<table border=1 align=center>";

$number_of_cols = 0;

// Request results from tables
$result = mysql_query("SELECT * FROM names");

while ( $row = mysql_fetch_array($result) )
{


  if ($number_of_cols == 0)
  {
    echo"<tr>";
  }

  echo "<td width=\"200\">". $row['name'] ."</td>";

  if ($number_of_cols == 2)
  {
    echo"</tr>";
    $number_of_cols=0;
  }

  // increment the counter
  $number_of_cols++;


}
echo"</table>";

EDIT: moved the number_of_cols++ line to the end of the while loop. You may need to check that.

[ade234uk]

I moved the following code below, and now it works perfectly.
I can see how it works now. I don't know why the hell I could not see it in the first place as regard checking $number_of_cols==0;

Thank you very much for your help.

<?php
// increment the counter
$number_of_cols++;
?>