Populate text box with existing info from database to then update and submit

kjdix

So I have a menu which rotates every 21 days. They need to be able to edit each individually. On the admin menu I have a drop down box where they can select which day to edit. Once they select which one a screen displays a list of text boxes on the left which i want to populate with existing info so the user can update the info and click submit to insert into database. Heres my code for the diaplaying the text boxes, at present they display but are not populated.

echo "<table width=1500><tr><td>";
echo "<p><h1>Change the $DayWeek menu</h1>";
echo "<form action=postrequest.php method=post>";
echo "<p>Breakfast Title: <input type=text name=btitle value=$row[btitle]>";
echo "<p>Breakfast Option 1: <input type=text name=bopt1 value=$row[bopt1]>";
echo "<p>Breakfast Option 2: <input type=text name=bopt2 value=$row[bopt2]>";
echo "<p>Breakfast Option 3: <input type=text name=bopt3 value=$row[bopt3]>";
echo "<p>Breakfast Option 4: <input type=text name=bopt4 value=$row[bopt4]>";
echo "<p>Breakfast Desert: <input type=text name=bdesert value=$row[bdesert]>";
echo "<p>Lunch Title: <input type=text name=ltitle value=$row[ltitle]>";
echo "<p>Lunch Option 1: <input type=text name=lopt1 value=$row[lopt1]>";
echo "<p>Lunch Option 2: <input type=text name=lopt2 value=$row[lopt2]>";
echo "<p>Lunch Option 3: <input type=text name=lopt3 value=$row[lopt3]>";
echo "<p>Lunch Option 4: <input type=text name=lopt4 value=$row[lopt4]>";
echo "<p>Lunch Option 5: <input type=text name=lopt5 value=$row[lopt5]>";
echo "<p>Lunch Option 6: <input type=text name=lopt6 value=$row[lopt6]>";
echo "<p>Lunch Desert: <input type=text name=ldesert value=$row[ldesert]>";
echo "<p>Supper Title: <input type=text name=stitle value=$row[stitle]>";
echo "<p>Supper Option 1: <input type=text name=sopt1 value=$row[sopt1]>";
echo "<p>Supper Option 2: <input type=text name=sopt2 value=$row[sopt2]>";
echo "<p>Supper Option 3: <input type=text name=sopt3 value=$row[sopt3]>";
echo "<p>Supper Option 4: <input type=text name=sopt4 value=$row[sopt4]>";
echo "<p>Supper Option 5: <input type=text name=sopt5 value=$row[sopt5]>";
echo "<p>Supper Option 6: <input type=text name=sopt6 value=$row[sopt6]>";
echo "<p>Supper Desert: <input type=text name=sdesert value=$row[sdesert]>";
echo "<p><input type=submit value=Submit>";

Any ideas as i need to somehow enclose the variable i think so it displays.
Cheers

paulnaj

Hi,

You might be having problems with embedding the variables in strings ... try re-writing lines as follows:

echo '<p>Breakfast Option 1: <input type="text" name="bopt1" value="'.$row['bopt1'].'">';

Using single-quotes is easier for echo-ing HTML, since you can use the double-quotes around the HTML values in the string.

Also, embedding variables in strings is v. hard to read and debug.

Paul

kjdix

Still not luck. The boxes appear and allow you to enter text but they do not popluate with current data so you can update and submit. Ive tried both the following

echo "<table width=1500><tr><td>";
echo "<p><h1>Change the $DayWeek menu</h1>";
echo "<form action=postrequest.php method=post>";
echo "<p>Breakfast Title: <input type=text name=btitle value=$row[btitle]>";
echo "<p>Breakfast Option 1: <input type=text name=bopt1 value=$row[bopt1]>";

and

echo "<table width=1500><tr><td>";
echo "<p><h1>Change the $DayWeek menu</h1>";
echo "<form action=postrequest.php method=post>";
echo '<p>Breakfast Title: <input type="text" name="btitle" value="'.$row['btitle']'">';
echo '<p>Breakfast Option 1: <input type="text" name="bopt1" value="'.$row['bopt1'].'">';

any ideas?

paulnaj

Hi again,

A couple of things to try and close down any bugs...

Follow through with code that is unambiguously clean. Rather than ...

echo "<table width=1500><tr><td>";
echo "<p><h1>Change the $DayWeek menu</h1>";
echo "<form action=postrequest.php method=post>";
echo '<p>Breakfast Title: <input type="text" name="btitle" value="'.$row['btitle']'">';
echo '<p>Breakfast Option 1: <input type="text" name="bopt1" value="'.$row['bopt1'].'">';

... try ...

echo '<table width="1500"><tr><td>';
echo '<p><h1>Change the '.$DayWeek.' menu</h1>';
echo '<form action="postrequest.php" method="post">';
echo '<p>Breakfast Title: <input type="text" name="btitle" value="'.$row['btitle'].'">';
echo '<p>Breakfast Option 1: <input type="text" name="bopt1" value="'.$row['bopt1'].'">';

As a test, try echo-ing out the contents of the $row to the browser before using it. Something like ...
```
echo '<pre>'; var_dump($row); echo '</pre>';
```
... to make it easy to read.

kjdix

Thanks for your help. Here is my code. Basically on the left will be a table with all the text boxes listed and hopefully populated with current data. Then on the right will be another table which shows the information as it will be presented properly. So the information is being gathered from the database correctly as it displays on the right. The table on the left lists the boxes but there are no values in the boxes.

echo '<table width="1500"><tr><td>';
echo '<p><h1>Change the '.$DayWeek.' menu</h1>';
echo '<form action="postrequest.php" method="post">';
echo '<p>Breakfast Title: <input type="text" name="btitle" value="'.$row['btitle'].'">';
echo '<p>Breakfast Option 1: <input type="text" name="bopt1" value="'.$row['bopt1'].'">';
echo '<p>Breakfast Option 2: <input type="text" name="bopt2" value="'.$row['bopt2'].'">';
echo '<p>Breakfast Option 3: <input type="text" name="bopt3" value="'.$row['bopt3'].'">';
echo '<p>Breakfast Option 4: <input type="text" name="bopt4" value="'.$row['bopt4'].'">';
echo '<p>Breakfast Desert: <input type="text" name="bdesert" value="'.$row['bdesert'].'">';
echo '<p>Lunch Title: <input type="text" name="ltitle" value="'.$row['ltitle'].'">';
echo '<p>Lunch Option 1: <input type="text" name="lopt1" value="'.$row['lopt1'].'">';
echo '<p>Lunch Option 2: <input type="text" name="lopt2" value="'.$row['lopt2'].'">';
echo '<p>Lunch Option 3: <input type="text" name="lopt3" value="'.$row['lopt3'].'">';
echo '<p>Lunch Option 4: <input type="text" name="lopt4" value="'.$row['lopt4'].'">';
echo '<p>Lunch Option 5: <input type="text" name="lopt5" value="'.$row['lopt5'].'">';
echo '<p>Lunch Option 6: <input type="text" name="lopt6" value="'.$row['lopt6'].'">';
echo '<p>Lunch Desert: <input type="text" name="ldesert" value="'.$row['ldesert'].'">';
echo '<p>Supper Title: <input type="text" name="stitle" value="'.$row['stitle'].'">';
echo '<p>Supper Option 1: <input type="text" name="sopt1" value="'.$row['sopt1'].'">';
echo '<p>Supper Option 2: <input type="text" name="sopt2" value="'.$row['sopt2'].'">';
echo '<p>Supper Option 3: <input type="text" name="sopt3" value="'.$row['sopt3'].'">';
echo '<p>Supper Option 4: <input type="text" name="sopt4" value="'.$row['sopt4'].'">';
echo '<p>Supper Option 5: <input type="text" name="sopt5" value="'.$row['sopt5'].'">';
echo '<p>Supper Option 6: <input type="text" name="sopt6" value="'.$row['sopt6'].'">';
echo '<p>Supper Desert: <input type="text" name="sdesert" value="'.$row['sdesert'].'">';
echo '<p><input type="submit" value="Submit">';
echo '</td>';
echo '<td valign=top>';
	echo "<table><tr><td><h1>Meals information for $DayWeek</h1>";
	$query="select * from meals where WD='$DayWeek' ";
	$result=mysql_query($query);
	echo mysql_error();
if ($result!="") {
	while ($row=mysql_fetch_array($result)) {
	echo "<tr><td colspan ='2'><center><font color=#ff0000 size=6>Breakfast</font></td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[btitle]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[bopt1]</td></tr>";
	  echo "<tr><td><center><font color=#000000 size=5>$row[bopt2]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[bopt3]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[bopt4]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[bdesert]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=2>&nbsp;</td></tr>";
		echo "<tr><td colspan ='2'><center><font color=#ff0000 size=6>Lunch</font></td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[ltitle]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[lopt1]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[lopt2]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[lopt3]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[lopt4]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[lopt5]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[lopt6]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=2>&nbsp;</td></tr>";
		echo "<tr><td colspan ='2'><center><font color=#ff0000 size=6>Supper</font></td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[stitle]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[sopt1]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[sopt2]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[sopt3]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[sopt4]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[sopt5]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[sopt6]</td></tr>";
		echo "<tr><td><center><font color=#000000 size=5>$row[sdesert]</td></tr>";
		echo "</table>";

paulnaj

Hi Kj

Not sure you're hearing what I'm saying - for one thing the second half of your code is still embedding the variables, not properly quoting the HTML variables, etc.

And putting the test I suggested at the top of this code will probably show that the $row is empty, or even undefined.

Lastly, I think your html skills need a bit of updating, you aren't 'closing' the paragraph tags, and are using deprecated tags like 'center' and 'font' - not that this will affect the $row variable, though.

Try following through with my earlier suggestions.

Paul.

kjdix

I feel very silly, I have corrected the issue and you were right it was returning a null value as i wasnt running the first query to gather the results. Thankyou.
Are you able to assist me with another issue. I then want to submit this modified info into the database to update it. So the code for the text boxes to enter info is

echo '<table width="1500"><tr><td>';
$query="select * from meals where WD='$DayWeek' ";
	$result=mysql_query($query);
	echo mysql_error();
if ($result!="") {
	while ($row=mysql_fetch_array($result)) {
echo '<p><h1>Change the '.$DayWeek.' menu</h1>';
echo '<form action="postrequest.php" method="post">';
echo '<p>Breakfast Title: <input type="text" name="btitle" value="'.$row['btitle'].'">';
echo '<p>Breakfast Option 1: <input type="text" name="bopt1" value="'.$row['bopt1'].'">';
echo '<p>Breakfast Option 2: <input type="text" name="bopt2" value="'.$row['bopt2'].'">';
echo '<p>Breakfast Option 3: <input type="text" name="bopt3" value="'.$row['bopt3'].'">';
echo '<p>Breakfast Option 4: <input type="text" name="bopt4" value="'.$row['bopt4'].'">';
echo '<p>Breakfast Option 5: <input type="text" name="bopt5" value="'.$row['bopt5'].'">';
echo '<p>Breakfast Desert: <input type="text" name="bdesert" value="'.$row['bdesert'].'">';
echo '<p>Lunch Title: <input type="text" name="ltitle" value="'.$row['ltitle'].'">';
echo '<p>Lunch Option 1: <input type="text" name="lopt1" value="'.$row['lopt1'].'">';
echo '<p>Lunch Option 2: <input type="text" name="lopt2" value="'.$row['lopt2'].'">';
echo '<p>Lunch Option 3: <input type="text" name="lopt3" value="'.$row['lopt3'].'">';
echo '<p>Lunch Option 4: <input type="text" name="lopt4" value="'.$row['lopt4'].'">';
echo '<p>Lunch Option 5: <input type="text" name="lopt5" value="'.$row['lopt5'].'">';
echo '<p>Lunch Option 6: <input type="text" name="lopt6" value="'.$row['lopt6'].'">';
echo '<p>Lunch Desert: <input type="text" name="ldesert" value="'.$row['ldesert'].'">';
echo '<p>Supper Title: <input type="text" name="stitle" value="'.$row['stitle'].'">';
echo '<p>Supper Option 1: <input type="text" name="sopt1" value="'.$row['sopt1'].'">';
echo '<p>Supper Option 2: <input type="text" name="sopt2" value="'.$row['sopt2'].'">';
echo '<p>Supper Option 3: <input type="text" name="sopt3" value="'.$row['sopt3'].'">';
echo '<p>Supper Option 4: <input type="text" name="sopt4" value="'.$row['sopt4'].'">';
echo '<p>Supper Option 5: <input type="text" name="sopt5" value="'.$row['sopt5'].'">';
echo '<p>Supper Option 6: <input type="text" name="sopt6" value="'.$row['sopt6'].'">';
echo '<p>Supper Desert: <input type="text" name="sdesert" value="'.$row['sdesert'].'">';
echo '<p><input type="submit" value="Submit">';
echo '</td>';
}
}

and then the post request is as follows

$server=mysql_connect($dbhostname,$dbusername,$dbpassword) or die ("Couldnt connect to server");
$db=mysql_select_db('menu',$server) or die ("Couldnt select DB");

$time=date("Y-m-d H:i:s");
$day=($_POST[day]);
$week=($_POST[week]);
$btitle=($_POST[btitle]);
$bopt1=($_POST[bopt1]);
$bopt2=($_POST[bopt2]);
$bopt3=($_POST[bopt3]);
$bopt4=($_POST[bopt4]);
$bopt5=($_POST[bopt5]);
$bdesert=($_POST[bdesert]);
$ltitle=($_POST[ltitle]);
$lopt1=($_POST[lopt1]);
$lopt2=($_POST[lopt2]);
$lopt3=($_POST[lopt3]);
$lopt4=($_POST[lopt4]);
$lopt5=($_POST[lopt5]);
$lopt6=($_POST[lopt6]);
$ldesert=($_POST[ldesert]);
$stitle=($_POST[stitle]);
$sopt1=($_POST[sopt1]);
$sopt2=($_POST[sopt2]);
$sopt3=($_POST[sopt3]);
$sopt4=($_POST[sopt4]);
$sopt5=($_POST[sopt5]);
$sopt6=($_POST[sopt6]);
$sdesert=($_POST[sdesert]);
$query="UPDATE meals SET btitle='$btitle', bopt1='$bopt1', bopt2='$bopt2', bopt3='$bopt3', bopt4='$bopt4', bopt5='$bopt5', bdesert='$bdesert', ltitle='$ltitle', lopt1='$lopt1', lopt2='$lopt2', lopt3='$lopt3', lopt4='$lopt4', lopt5='$lopt5', lopt6='$lopt6', ldesert'$ldesert', stitle='$stitle', sopt1='$sopt1', sopt2='$sopt2', sopt3='$sopt3', sopt4='$sopt4', sopt5='$sopt5', sopt6='$sopt6', sdesert='$sdesert' WHERE WD='$DayWeek'";

$result=mysql_query($query);
echo mysql_error();

The error I recieve is as follows

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''Freshly made Muffins, Warm Bakers Basket', stitle='ENGLISH NIGHT', sopt1='SWEDE' at line 1

Any ideas?

paulnaj

Glad you sorted it out.

Just a note on forum etiquette - first mark this issue resolved and then start any new issues in a separate thread, otherwise it will lose it's usefulness to other users.

Haven't got time to help now, but will look out for it again a bit later.

cyberlew15

Okay you were told to start using single quotes with variables in strings right but still you are using double quotes try taking advice when it is given to you

if you will insist on using double quotes try this

$query="UPDATE meals SET btitle='".$btitle."',".
" bopt1='".$bopt1."',".
"bopt2='".$bopt2."',".
"bopt3='".$bopt3."',".
"bopt4='".$bopt4."',".
"bopt5='".$bopt5."',".
"bdesert='".$bdesert."',".
"ltitle='".$ltitle."',".
"lopt1='".$lopt1."',".
"lopt2='".$lopt2."',".
"lopt3='".$lopt3."',".
"lopt4='".$lopt4."',".
"lopt5='".$lopt5."',".
"lopt6='".$lopt6."',".
"ldesert'".$ldesert."',".
"stitle='".$stitle."',".
"sopt1='".$sopt1."',".
"sopt2='".$sopt2."',".
"sopt3='".$sopt3."',".
"sopt4='".$sopt4."',".
"sopt5='".$sopt5."',".
"sopt6='".$sopt6."',".
"sdesert='".$sdesert."'".
" WHERE WD='".$DayWeek."'";

also try using ajax with LIMIT=25 or something in the sql for a nice progress bar if this is going to be acting on a large number of records it all adds to the user experience.