[RESOLVED] Optimizing select menu of users

[Teach]

Hi again!

After a bit of advice and help please...

I've just finished a private messaging php script, and on my "send message" page I have a select menu of users they can send to, along with a hidden div with a further 9 of those select menus to allow multi-recipient.

It loads pretty slow as each select menu I do this for:

                <tr>
                  <th class="intro"><label>To:</label></th>
                  <td class="forminput"><select name="to[]" class="formwidth">
<?php
if ($frm1=='')
 echo "                    <option value=\"\" selected=\"selected\">--- Please select the recipient ---</option>\n";
 $users=mysql_query2("SELECT * FROM user WHERE deleted=0 ORDER BY account");
 while ($user=mysql_fetch_array($users))

 if ($user['account']!=$_SESSION['account']) {
   echo "                    <option value=\"".$user['account']."\"".($user['account']==$frm1 ? ' selected="selected"' : "")."".($user['account']==$_POST['to'][0] ? ' selected="selected"' : "").">".$user['account']." &nbsp;&nbsp; (".bestGroup($user['account']).")</option>\n";
 }
 ?>
                  </select><br /><br />

Is there a way just to select them once, but be able to echo them out 9 times where I want? Maybe something like an array? Unfortunately, a bit beyond me...!

The thing concerning me with that is that we keep the [0], [1] etc to put selected="selected" if there's an error to save the person having to select that person again.

Thank you in advance.

[djjjozsi]

do not print the list, just add into a string (or an array), and print that where its needed.

Multiple select don't solve this project?
Or checkboxes.

[Teach]

Hi there, thanks for your reply!

Can you explain what you mean? I didn't understand... 🙂

I need to try and keep the certain array endings, i.e. [0], [1] and so on to keep our self-populating options.

[djjjozsi]

here is an example, to make a list box allowing the multiple selects:

  <select name="select[]" size="1" multiple>
    <option value="value1">label1</option>
    <option value="value2">label2</option>
  </select>

And make an SQL select like this:

$users=mysql_query2("SELECT * FROM user WHERE deleted=0 AND account !='". int($_SESSION['account'])."'  ORDER BY account");

what is mysql_query2 ? 🙂

[Teach]

Hi there 🙂 Thanks for the reply.

Still a bit confused...

Basically, that code I posted on my first post is repeated 10 times, and the page is pretty slow to load. I was wondering if there's a way to speed it up and get the users once, but be able to echo them out when I want, but without running the queries again.

As mentioned though, it's difficult because of the array endings, i.e. the first recipient has [0], second [1] and so on, this is so that if there's an error in submission, the person doesn't have to select the user again.

mysql_query2() is just a custom query which counts database queries and sends a SQL queries to our webmasters if there is one, nothing else.

Thanks!

[djjjozsi]

what's you opinion about a function like this:

<form name="form1" method="post" action="">

<?php

include("connect.php");

function select()
{
/*  lets select from the database */
	$sql = 'SELECT * FROM `users`';
	$result=mysql_query($sql) or die(mysql_error());

while($rows=mysql_fetch_assoc($result))
{
	$r[]=$rows;   
}
//                  return this array
return($r);
}

function s_list($var,$variable)
{
/*   it creates a list with the arrays   */
	print '  <select name="value['.$variable.']">
	<option value=""></option>
	';
	foreach($var AS $key)
	{

/*Check if that POST array has set, if yes, take the SELECTED property */
		if(@$_POST["value"][$variable]==$key["id"])
			$sel=" SELECTED";
		else
			$sel="";
		print "<option value=\"{$key["id"]}\"{$sel}>". htmlspecialchars($key["full_name"]) ."</option>\n";
	}

print '  </select>
';
}

$values=select();

s_list($values,"0");
s_list($values,"1");
s_list($values,"2");
s_list($values,"3");
s_list($values,"4");
s_list($values,"5");
/*    print_r($_POST);    */

?>
<input type="submit" name="submit" value="submit">
</form>

[Teach]

You're a star, thank you!

This is much cleaner and tidier! 😃

[djjjozsi]

And don't forget to set this thread as resolved 🙂

Hello, jjozsi.