ZipArchive Create problem

hyzerfool

I'm trying to zip up a text file but the resulting zip is corrupt. I get different error messages depending on what program I try to use to unzip it, but WinZip gives a Bad CRC message. Note that the ZIP file does open in WinZip (and 7-zip) it just won't extract the contents.

The code looks very straightforward, but it fails for me both on my Vista 64 machine and an XP machine.

I'm using php_zip.dll version 5.2.8.8.

Here's my code:

$strTempFilename = "c:\\work\\lab\\webserver\\data\\ZipTestData.txt";
$strZipFilename = $strTempFilename . ".zip";

$zip = new ZipArchive;

echo "Creating zip file $strZipFilename<BR>";

$res = $zip->open($strZipFilename, ZIPARCHIVE::CREATE); 
if ($res === TRUE) {

if (! $zip->addFile($strTempFilename, basename ($strTempFilename)))
{
echo "Error adding file to zip<BR>";
}
else
echo "Added file $strTempFilename<BR>";

if (! $zip->close())
echo "Unable to close zip file<BR>";
else
echo "Closed file successfully<BR>";

} else {
    echo 'Zip failed';
}

Kudose

What are the errors reported?

This code works fine on Ubuntu x64

<?php
$strTempFilename = "/home/travis/Documents/cpp/bam.cpp";
$strZipFilename = $strTempFilename . ".zip";

$zip = new ZipArchive;

echo "Creating zip file $strZipFilename<BR>";

$res = $zip->open($strZipFilename, ZIPARCHIVE::CREATE); 
if ($res === TRUE) {

if (! $zip->addFile($strTempFilename, basename ($strTempFilename)))
{
echo "Error adding file to zip<BR>";
}
else
echo "Added file $strTempFilename<BR>";

if (! $zip->close())
echo "Unable to close zip file<BR>";
else
echo "Closed file successfully<BR>";

} else {
    echo 'Zip failed';
}

Also, try to unzip it using PHP and post back your results.

hyzerfool

I see that my post was phrased poorly. I don't get any error, the code runs to completion and I get a ZIP file. I can open the ZIP file and see that there are files in it, but when I try to extract the files (well, file, in my case) I get a CRC error in WinZip.

It also fails to extract using Windows' compressed folder tool and using 7-Zip.

I got the same behavior on Vista-64 and on XP Pro (32 bit).

Kudose

Try to narrow the problem down.

See if PHP can open and extract the zip file it created.

hyzerfool

Here's what I get when trying to read the file using PHP and ziparchive

Name: ZipTestData.txt
Actual Filesize: 316846
Compressed Size: 30357
Compression Method: deflated
File Contents: Error reading file

"Error Reading File" meaning zip_entry_read returned false. I haven't seen a way to get a specific error code in case of failure.

hyzerfool

I've been playing around with this and whether it succeeds or not seems to depend on the content of the file. These are all text files I'm testing with and I haven't been able to figure out what it is that breaks it yet. At first I thought that once the file got longer than a particular length it would fail, but that doesn't seem to be the case (at least, I haven't been able to find a tipping point at which a file always fails).

I've hit places where if I changed the file type from Unix to PC (so, LF to CR/LF) it would work / not work (toggling the file contents back and forth had consistently reproducible results).

I've hit places where adding an extra blank line would make it fail and then removing it would make it work again.

Wacky stuff, here.

I'm attaching 3 files, one is my test PHP code that zips and unzips my test file.
The other 2 are versions of the same file, one saved using CR/LF (which fails) and one using just LF (which succeeds).

If anyone is willing to try this on their machine and see if it does the same for them I'd appreciate it.

hyzerfool

I'm attaching 2 more data files. The only difference in them is an extra newline before the last line of text.

In ZipTestData-Works.txt it, well, works correctly.

In ZipTestData-WrongData.txt the output is incorrect, it displays the file contents but you'll see that the last line, "Douglas is " displays as "Douglaata"