[RESOLVED] problems with radio buttons...

[velociraptor106]

so ive been designing this web site for my work and it has been going very smooth untill tryed to get information from my mysql server and display it using radio buttons so basicly this is were im at::

print '<form><table><td width="175">
                  <div align="left">
                    <input type="text" name="TagNumber" value="' . $row['TagNumber'] . '" />
                  </div></td>
            </tr>
            <tr>
              <td><div align="right">Facility Phone:</div></td>
              <td><input type="text" name="FacilityPhone" value="' . $row['FacilityPhone'] . '" /></td>
              <td><div align="right">Active:*</div></td>
              <td><input name="Active" type="radio" value="-1" ' . if($row['Active'] == '-1') print 'checked';  . ' /> Yes
  					<input name="Active" type="radio" value="0" ' . if($row['Active'] == '0') print 'checked';  . ' /> No
				</td></table></form>'

i have no idea why this little part of my code doesn't work so feel free to give me any suggestions.

(this is just the small peice of code that im having problems with i left the part where i connect to the server and all the veriable junk out cuz that stuff has been tested and works fine its just these radio buttons wont do what i want)

[bradgrafelman]

velociraptor106 wrote:

i have no idea why this little part of my code doesn't work

Did you try listening to what PHP is trying to tell you? When developing code, you should have display_errors set to On (or, when the code is implemented, use the error_log directive to log all errors for later review) and error_reporting set to E_ALL so that you can correct any errors PHP detects and attempts to warn you about. For example, your script above has a fatal error (a parse error):

You can't combine an if() control structure in the middle of a bunch of strings. What you might instead try is using the ternary operator (see manual page: [man]language.operators.comparison#language.operators.comparison.ternary[/man]) instead.

[velociraptor106]

yeah i understand its a phrase error i just dont know how to get the string to stop, print the "checked" in the appropriate radio button then have the string continue or am i over thinking this? is there an easier way for me to get the results i want?

[bradgrafelman]

As I suggested in my post above, using the ternary operator appears to be the easiest fix here. Example usage:

$var = TRUE;

echo "foo is: " . ($var == TRUE ? 'bar' : 'not bar') . "!";

[velociraptor106]

yeh sorry i played the "write first read later" game

after reading about what you told me to do i updated the code to

 <td>
<input name="Active" type="radio" value="-1" " . ($row['Active'] == '-1' ? 'checked' : '') . " /> Yes
<input name="Active" type="radio" value="0" " . ($row['Active'] == '0' ? 'checked' : '') . " /> No
</td>

and its still coming up with an error:

Parse error: parse error, expecting ','' or';''...on the 2nd line ( the one that for value='0')

any idea what i did wrong now?

[bradgrafelman]

It's hard to tell with that snippet what the parse error is; looking at your first post, I notice you omitted the ending semicolon after the last single quote for the print command. Could this perhaps be the error?

[velociraptor106]

i fixed it, i forgot to put '' and "" around the whole operator but yeh thanks for your all your help

[bradgrafelman]

No problem. Don't forget to mark this thread resolved (using the link under Thread Tools).