Help with a while loop inside a function

7724

Hi All,

I've written a function and put a while loop inside it like so:

function myFunction(){

$SQL = "SELECT * from tbl order by id desc LIMIT 2";     

$result = mysql_query($SQL) OR die(mysql_error()); 

$active = "active";
$inactive = "inactive";
$n=1;

while ($row = mysql_fetch_assoc($result))  

    {
$headline[] = $row['headline'];

$active = ($active=='active' ? 'inactive' : 'active');
$inactive = ($inactive=='inactive' ? 'active' : 'inactive');

echo '

  <div id="leaderPanel'.$n.'" class="leadContainer" style="display:inline">
	<a class="leader-'.$inactive.'">'.$headline[0].'</a>
	<a class="leader-'.$active.'">.'$headline[1].'</a>
  </div>
	'; 
    $n++; }	
}
?>

However, I get the message [] operator not supported for strings here:

$headline[] = $row['headline'];

Is there a reason why it won't work in a function and how would I get around this?

Thank you.

bradgrafelman

Which version of PHP are you running?

Also, what are you trying to achieve with the whole $headline stuff? It doesn't make sense as you have it presently.

7724

Thanks, sorry posted a snippett and missed editing it properly - have done now (see above).

Am running 5.2.8

What I want to do is get the first and second headlines out of my database. So my final output looks pretty much like so


  <div id="leaderPanel1" class="leadContainer" style="display:inline"> 
    <a class="leader-active">This is the first headline</a> 
    <a class="leader-inactive"">This is the 2nd headline</a> 
  </div> 

  <div id="leaderPanel2" class="leadContainer" style="display:inline"> 
    <a class="leader-inactive">This is the first headline</a> 
    <a class="leader-active">This is the 2nd headline</a> 
  </div>

bradgrafelman

$row['headline'] points to a single column of a single row - the "headline" column. How can there be two different headlines?

7724

Hmm,

Back to the drawing board I think. I'll have to look into what i've done. Thanks for the help though.

Stephen68

Are you only going to have the two headlines? In your query you are selecting the records you want from an id (I assume it is your primary key). I guess you could put our results into a array then run a while loop to put out your display maybe.

<?php

$SQL = "SELECT * from tbl order by id desc LIMIT 2";     

$result = mysql_query($SQL) OR die(mysql_error());

$row = mysql_fetch_array($result);

$n = mysql_num_rows($result);

$active = ($active=='active' ? 'inactive' : 'active');
$inactive = ($inactive=='inactive' ? 'active' : 'inactive');


for ($i = 1; $i <= $n; $i++ ) {

echo '

  <div id="leaderPanel'.$n=i.'" class="leadContainer" style="display:inline">
  <a class="leader-'.$inactive.'">'.$row[0].'</a>
  <a class="leader-'.$active.'">.'$row[1].'</a>
  </div>
 ';
}

?>

Just off the top of my head, hope it helps in some way. Code not tested and I very tired lol

Cheers!
Stephen