Jump menu firing blanks

[JW09]

I've created one form which submits to a sql and another form which lists text entered into first form. Can select data in second form. The problem is the second form doesn't write selected field to sql but I know it writes because it changed from a value to a blank. I think it's resorting to original option which is blank.

This has all been done with a forum. Here's the forum http://www.eoaa.org/entvent.info/forum/index.php

usename
test

password
12345678

Go to Profile, there you see two new sections "Submit vent" and "Choose vent". Only the first field Top five musicians works for Submit vent, put text in there and then go to "Choose vent", your test is included. When you select field from Choose vent and submit it fires a blank to database.

Here's the code for the menu ..

 
include 'ventChoose.php';
<form action="', $scripturl, '?action=profile2" method="post" accept-charset="', $context['character_set'], '" name="creator" id="creator" enctype="multipart/form-data">

<SELECT NAME=T5a_musicians>
<option value="ID"', ($context['member']['T5a_musicians']['name'] == '1' ? ' selected="selected"' : ''), '>', $mus, '</option>
</SELECT>';

And here's ventChoose.php

$sql="SELECT ID, musicians FROM xxxx order by musicians";
$result=mysql_query($sql);

$mus="";

while ($row=mysql_fetch_array($result)) {

$ID=$row["id"];
$musicians=$row["musicians"];
$mus.="<OPTION VALUE=\"$id\">".$musicians;
}
?> 
 

I know there's some mistakes, I think it needs little fine tuning and it's there. Please help, this is the last hurdle and it's been a three day marathon!

[Weedpacket]

If there's a problem with inserting data into the database then it would be nice to see the code that inserts data into the database.

PS: [code]...[/code] for plain code, and [php]...[/code] for PHP. See this FAQ for aditional details.

[JW09]

Damn, thanks for accepting my topic.

The form action inserts data into the database which comes from profile2 array which uses a function called ModifyProfile2, the code for ModifyProfile2 is ..

function ModifyProfile2()
{
	global $txt, $modSettings;
	global $cookiename, $context;
	global $sourcedir, $scripturl, $db_prefix;
	global $ID_MEMBER, $user_info;
	global $context, $newpassemail, $user_profile, $validationCode;

loadLanguage('Profile');

/* Set allowed sub-actions.

 The format of $sa_allowed is as follows:

$sa_allowed = array(
	'sub-action' => array(permission_array_for_editing_OWN_profile, permission_array_for_editing_ANY_profile, session_validation_method[, require_password]),
	...
);

*/

$sa_allowed = array(
	'account' => array(array('manage_membergroups', 'profile_identity_any', 'profile_identity_own'), array('manage_membergroups', 'profile_identity_any'), 'post', true),
	'forumProfile' => array(array('profile_extra_any', 'profile_extra_own'), array('profile_extra_any'), 'post'),
	'ventSubmit' => array(array('profile_extra_any', 'profile_extra_own'), array('profile_extra_any'), 'post'),
	'ventChoose' => array(array('profile_extra_any', 'profile_extra_own'), array('profile_extra_any'), 'post'),
	'theme' => array(array('profile_extra_any', 'profile_extra_own'), array('profile_extra_any'), 'post'),
	'notification' => array(array('profile_extra_any', 'profile_extra_own'), array('profile_extra_any'), 'post'),
	'pmprefs' => array(array('profile_extra_any', 'profile_extra_own'), array('profile_extra_any'), 'post'),
	'deleteAccount' => array(array('profile_remove_any', 'profile_remove_own'), array('profile_remove_any'), 'post', true),
	'activateAccount' => array(array(), array('moderate_forum'), 'get'),
);

// Is the current sub-action allowed?
if (empty($_REQUEST['sa']) || !isset($sa_allowed[$_REQUEST['sa']]))
	fatal_lang_error(453, false);

checkSession($sa_allowed[$_REQUEST['sa']][2]);

// Start with no updates and no errors.
$profile_vars = array();
$post_errors = array();

// Normally, don't send an email.
$newpassemail = false;

// Clean up the POST variables.
$_POST = htmltrim__recursive($_POST);
$_POST = stripslashes__recursive($_POST);
$_POST = htmlspecialchars__recursive($_POST);
$_POST = addslashes__recursive($_POST);

// Search for the member being edited and put the information in $user_profile.
$memberResult = loadMemberData((int) $_REQUEST['userID'], false, 'profile');

if (!is_array($memberResult))
	fatal_lang_error(453, false);

list ($memID) = $memberResult;

// Are you modifying your own, or someone else's?
if ($ID_MEMBER == $memID)
	$context['user']['is_owner'] = true;
else
{
	$context['user']['is_owner'] = false;
	validateSession();
}

// Check profile editing permissions.
isAllowedTo($sa_allowed[$_REQUEST['sa']][$context['user']['is_owner'] ? 0 : 1]);

// If this is yours, check the password.
if ($context['user']['is_owner'] && !empty($sa_allowed[$_REQUEST['sa']][3]))
{
	// You didn't even enter a password!
	if (trim($_POST['oldpasswrd']) == '')
		$post_errors[] = 'no_password';

	// Since the password got modified due to all the $_POST cleaning, lets undo it so we can get the correct password
	$_POST['oldpasswrd'] = addslashes(un_htmlspecialchars(stripslashes($_POST['oldpasswrd'])));

	// Does the integration want to check passwords?
	$good_password = false;
	if (isset($modSettings['integrate_verify_password']) && function_exists($modSettings['integrate_verify_password']))
		if (call_user_func($modSettings['integrate_verify_password'], $user_profile[$memID]['memberName'], $_POST['oldpasswrd'], false) === true)
			$good_password = true;

	// Bad password!!!
	if (!$good_password && $user_info['passwd'] != sha1(strtolower($user_profile[$memID]['memberName']) . $_POST['oldpasswrd']))
		$post_errors[] = 'bad_password';
}

// No need for the sub action array.
unset($sa_allowed);

// If the user is an admin - see if they are resetting someones username.
if ($user_info['is_admin'] && isset($_POST['memberName']))
{
	// We'll need this...
	require_once($sourcedir . '/Subs-Auth.php');

	// Do the reset... this will send them an email too.
	resetPassword($memID, $_POST['memberName']);
}

// Change the IP address in the database.
if ($context['user']['is_owner'])
	$profile_vars['memberIP'] = "'$user_info[ip]'";

// Now call the sub-action function...
if (isset($_POST['sa']) && $_POST['sa'] == 'deleteAccount')
{
	deleteAccount2($profile_vars, $post_errors, $memID);

	if (empty($post_errors))
		redirectexit();
}
else
	saveProfileChanges($profile_vars, $post_errors, $memID);

// There was a problem, let them try to re-enter.
if (!empty($post_errors))
{
	// Load the language file so we can give a nice explanation of the errors.
	loadLanguage('Errors');
	$context['post_errors'] = $post_errors;

	$_REQUEST['sa'] = $_POST['sa'];
	$_REQUEST['u'] = $memID;
	return ModifyProfile($post_errors);
}

if (!empty($profile_vars))
{
	// If we've changed the password, notify any integration that may be listening in.
	if (isset($profile_vars['passwd']) && isset($modSettings['integrate_reset_pass']) && function_exists($modSettings['integrate_reset_pass']))
		call_user_func($modSettings['integrate_reset_pass'], $user_profile[$memID]['memberName'], $user_profile[$memID]['memberName'], $_POST['passwrd1']);

	updateMemberData($memID, $profile_vars);
}

// What if this is the newest member?
if ($modSettings['latestMember'] == $memID)
	updateStats('member');
elseif (isset($profile_vars['realName']))
	updateSettings(array('memberlist_updated' => time()));

// If the member changed his/her birthdate, update calendar statistics.
if (isset($profile_vars['birthdate']) || isset($profile_vars['realName']))
	updateStats('calendar');

// Send an email?
if ($newpassemail)
{
	require_once($sourcedir . '/Subs-Post.php');

	// Send off the email.
	sendmail($_POST['emailAddress'], $txt['activate_reactivate_title'] . ' ' . $context['forum_name'],
		"$txt[activate_reactivate_mail]\n\n" .
		"$scripturl?action=activate;u=$memID;code=$validationCode\n\n" .
		"$txt[activate_code]: $validationCode\n\n" .
		$txt[130]);

	// Log the user out.
	db_query("
		DELETE FROM {$db_prefix}log_online
		WHERE ID_MEMBER = $memID", __FILE__, __LINE__);
	$_SESSION['log_time'] = 0;
	$_SESSION['login_' . $cookiename] = serialize(array(0, '', 0));

	if (isset($_COOKIE[$cookiename]))
		$_COOKIE[$cookiename] = '';

	loadUserSettings();

	$context['user']['is_logged'] = false;
	$context['user']['is_guest'] = true;

	// Send them to the done-with-registration-login screen.
	loadTemplate('Register');
	$context += array(
		'page_title' => &$txt[79],
		'sub_template' => 'after',
		'description' => &$txt['activate_changed_email']
	);
	return;
}
elseif ($context['user']['is_owner'])
{
	// Log them back in.
	if (isset($_POST['passwrd1']) && $_POST['passwrd1'] != '')
	{
		require_once($sourcedir . '/Subs-Auth.php');
		setLoginCookie(60 * $modSettings['cookieTime'], $memID, sha1(sha1(strtolower($user_profile[$memID]['memberName']) . un_htmlspecialchars(stripslashes($_POST['passwrd1']))) . $user_profile[$memID]['passwordSalt']));
	}

	loadUserSettings();
	writeLog();
}

// Back to same subaction page..
redirectexit('action=profile;u=' . $memID . ';sa=' . $_REQUEST['sa'], (isset($_POST['passwrd1']) && $context['server']['needs_login_fix']) || ($context['browser']['is_ie'] && isset($_FILES['attachment'])));
}

That's bog standard from the forum archive. I know it writes to the correct sql field because it deleted an entry or sent a blank entry. That's why I think it's something to do with the form code.

The menu populates with correct data and submits but doesn't submit the selected data.

[JW09]

Let's assume the jump menu is not sticking, how do I make selected stick?

[JW09]

Can anyone say why this produces syntax error, unexpected $end ?

echo'
<select name="T5a_musicians">
<option value="0"', ($row_vcmusicians['musicians']) ? ' selected="selected"' : '', '>', $row_vcmusicians['musicians'], '</option>';

{ while ($row_vcmusicians = mysql_fetch_assoc($vcmusicians));
  $rows = mysql_num_rows($vcmusicians);
  if($rows > 0) {
      mysql_data_seek($vcmusicians, 0);
     $row_vcmusicians = mysql_fetch_assoc($vcmusicians);
  }

echo'
</select>';

[JW09]

Also forgot to mention it's in a function sorry here's the entire function ..

// ventChoose
function template_ventChoose()
{
	global $context, $settings, $options, $scripturl, $modSettings, $txt; 
	include 'ventChoose.php';
	echo'
	<form action="', $scripturl, '?action=profile2" method="post" accept-charset="', $context['character_set'], '" name="creator" id="creator" enctype="multipart/form-data">

<select name="T5a_musicians">
<option value="0"', ($row_vcmusicians['musicians']) ? ' selected="selected"' : '', '>', $row_vcmusicians['musicians'], '</option>';

{ while ($row_vcmusicians = mysql_fetch_assoc($vcmusicians));
  $rows = mysql_num_rows($vcmusicians);
  if($rows > 0) {
      mysql_data_seek($vcmusicians, 0);
	  $row_vcmusicians = mysql_fetch_assoc($vcmusicians);
  }

echo'
</select>';				

template_profile_save();

echo '
					</table>
				</td>
			</tr>
		</table>
	</form>';
}

[JW09]

It was because of { before while. Can anyone say why the <option> code returns a 0 (zero).

function template_ventChoose()
{
	global $context, $settings, $options, $scripturl, $modSettings, $txt, $row_vcmusicians; 
	include 'ventChoose.php';

echo'
<form action="', $scripturl, '?action=profile2" method="post" accept-charset="', $context['character_set'], '" name="creator" id="creator" enctype="multipart/form-data">

<select name="T5a_musicians">
<option value="', $row_vcmusicians['musicians'], '"', $row_vcmusicians['musicians'] == $row_vcmusicians['musicians'] ? ' selected="selected"' : '', '>', $row_vcmusicians['musicians'], '</option>';
  while ($row_vcmusicians = mysql_fetch_assoc($vcmusicians));
  $rows = mysql_num_rows($vcmusicians);
  if($rows > 0) {
      mysql_data_seek($vcmusicians, 0);
      $row_vcmusicians = mysql_fetch_assoc($vcmusicians);
  }

echo'
</select>';  

This is a new method of populating the menu. It works in htm except I had to edit the option a bit because it's within a function. Here's the working code in htm ..

<select name="T5a_musicians" id="T5a_musicians">
  <?php
do {  

?>
  <option value="<?php echo $row_vcmusicians['musicians']?>"><?php echo $row_vcmusicians['musicians']?></option>
  <?php
} while ($row_vcmusicians = mysql_fetch_assoc($vcmusicians));
  $rows = mysql_num_rows($vcmusicians);
  if($rows > 0) {
      mysql_data_seek($vcmusicians, 0);
	  $row_vcmusicians = mysql_fetch_assoc($vcmusicians);
  }
?>
</select>

[Weedpacket]

   while ($row_vcmusicians = mysql_fetch_assoc($vcmusicians));
  $rows = mysql_num_rows($vcmusicians);
  if($rows > 0) {
      mysql_data_seek($vcmusicians, 0);
      $row_vcmusicians = mysql_fetch_assoc($vcmusicians);
  }

I don't think you want that empty while loop there (you certainly don't need to loop through the entire result set just to see how many there are).

Or are you missing a "do"? It might still be wrong depending on what magic happened elsewhere to give $row_vcmusicians a value (assuming it did happen - wanton use of global variables make it hard to tell).

[JW09]

Yes there's no do. Have had help elsewhere, while doesn't work if nothing is doing beforehand. This works, the if enables while as does do lol ..

echo'
<select name="T5a_musicians">';
  if (mysql_num_rows($vcmusicians)) {
          while ($row_vcmusicians = mysql_fetch_assoc($vcmusicians)) {
             echo '<option value="'. $row_vcmusicians['musicians'] .'">'. $row_vcmusicians['musicians'] .'</option>';
          }
       }
       echo'
</select>';