[RESOLVED] do not display last line in while loop

knucklehead

hi.
i have a loop like this;

$selekt = mysql_query("SELECT * FROM `table`") or die(mysql_error());

while ($row = mysql_fetch_array($selekt)) {

	echo "<p>".stripslashes($row['something'])."</p>";		
	echo "<hr>";

}

and everything is displaying correctly, of course =)
but how to make this script to display <HR> tag after each selected row EXCEPT the last one?
so, at the end i want to have html like this

<p>something1</p><hr>
<p>something2</p><hr>
<p>something3</p><hr>
<p>something4</p>

thanks in advance.

Weedpacket

You don't have to echo at the same time you're reading the result set.

$selekt = mysql_query("SELECT something FROM `table`") or die(mysql_error());

   $paragraphs = array();
    while ($row = mysql_fetch_array($selekt)) {

    $paragraphs[] = "<p>".stripslashes($row['something'])."</p>"; // stripslashes? Why would there be slashes?

}

echo join("<hr />", $paragraphs);

knucklehead

ok, this is cool.
i understood you and your vision for this easy script but i just don't understand one small thing... if i do this

	$selekt = mysql_query("SELECT * FROM table") or die(mysql_error());

$krlja = array();

while ($row = mysql_fetch_array($selekt)) {

	$krlja[] = "<p>".$row['something'];

	if ($row['something_else']) {

		$krlja[] .= "<br />".$row['something_else'])."</p>";

	}
}

echo join("<hr"/>", $krlja);

my output is not good... it goes like this

<p>something<hr /><br />something else</p><hr /><p>something2<hr /><br />something else 2</p>

hmmm... how's that??

oh yes, and to answer to your question about stripslashes... well, seems that i will have some strange text inside that column so i will use addslashes and I]stripslashes[/I]. yes =)

Weedpacket

Assuming you properly escaped the data when you were inserting it in the first place, there shouldn't be anything strange about it when it comes back out.
Besides, what you should be passing it through is [man]htmlspecialchars[/man] before embedding it in HTML.

   $krlja[] = "<p>".$row['something'];

    if ($row['something_else']) {

        $krlja[] .= "<br />".$row['something_else'])."</p>";

Because $row['something'] and $row['something_else'] are being put into two consecutive elements of the $krlja array ($krlja[] refers to a different element every time it's used).

   $line = "<p>".$row['something'];

    if ($row['something_else']) {

        $line .= "<br />".$row['something_else'])."</p>";
$krlja[] = $line;

Again, it's a matter of assembling what you want to put somewhere before you put it there.

knucklehead

yes, when i look at it now it seems perfectly simple, basic and logic =)
great, thanks for help, i appreciate it a lot =)

htmlspecialchars you say?? i will check it right now and see if that is what i need =) thanks!