[RESOLVED] Parse error: syntax error, unexpected T_STRING

[big-dog]

Can someone tell me my errors in this code I get the fallowing
Parse error: syntax error, unexpected T_STRING in /home/public_html/ClanApp/set.php on line 101
Ive tried other stuff and I get errors at each CREATE TABLE IF NOT EXISTS. and then at the last echo line
Line 101 is at the first CREATE TABLE IF NOT EXISTS

	// set up tables
 echo '<p>Creating table ClanApps';
CREATE TABLE IF NOT EXISTS ClanApps ( id int(10) unsigned NOT NULL auto_increment, In_game_Name varchar(20) default NULL, GSC_Login_Name varchar(20) default NULL, Date_of_Birth varchar(10) default NULL, Age varchar(2) default NULL, State_Province varchar(25) default NULL, Country varchar(20) default NULL, Hear_About_TB varchar(255) default NULL, Tactical_Realism varchar(255) default NULL, Enjoyable_Gaming varchar(255) default NULL, Join_Tactical_Brotherhood varchar (255) default NULL, Former_CoD_Clan_1 varchar(25) default NULL, Clan_1_Duration varchar(25) default NULL, Former_CoD_Clan_2 varchar(25) default NULL, Clan_2_Duration varchar(25) default NULL, Former_CoD_Clan_3 varchar(25) default NULL, Clan_3 _Duration varchar(25) default NULL, Active_Presence varchar(3) default NULL, EMail varchar(40) default NULL, IP_Address text, Date_Submitted text, Approved text, PRIMARY KEY (id) )')) { echo ' Error creating Table ' . mysql_error(); }

 echo '<p>Creating table logsin';
CREATE TABLE IF NOT EXISTS logsin ( username varchar(100) NOT NULL, `time` varchar(100) NOT NULL, ip varchar(100) NOT NULL )')) { echo ' Error creating Table ' . mysql_error(); }

 echo '<p>Creating table members';
CREATE TABLE IF NOT EXISTS members ( id int(100) NOT NULL auto_increment, email varchar(100) NOT NULL, username varchar(21) NOT NULL, `password` varchar(100) NOT NULL, `date` varchar(100) NOT NULL, confirm varchar(100) NOT NULL, ip varchar(100) NOT NULL, PRIMARY KEY (id)');

echo "<p>Tables installed correctly";

// save MD5
if($fp=@fopen("./setup.md5", "w")){
	fwrite($fp, $thisMD5);
	fclose($fp);
}

// go to index

[coldwerturkey]

your mysql queries aren't in mysql_query()'s .. at least the beginning of the lines aren't

[bradgrafelman]

As coldwerturkey suggests, you can't simply throw a SQL query right in the middle of a PHP script. That's like talking to your banker and suddenly saying "Double cheeseburger with fires and a coke" expecting him to understand that you'd like McDonalds.

Instead, you have to put the query into a string and use a function such as [man]mysql_query/man to execute it (once you've connected to the DBMS and selected a database, that is).

[big-dog]

It was working before I got other php stuff above all this but when I added the echo stuff at the first and at the end it stared giving errors. I also added the 2nd and 3rd creat table.

[coldwerturkey]

big-dog;10903096 wrote:

It was working before I got other php stuff above all this but when I added the echo stuff at the first and at the end it stared giving errors. I also added the 2nd and 3rd creat table.

I assure you with every fiber of my being that those queries would/did not execute without mysql_query().

also those first two queries are ending with ')) { echo ' Error creating Table ' . mysql_error(); } which shows you're missing so much of that line.

It should look something similar to

// set up tables 
echo '<p>Creating table ClanApps'; 
mysql_query('
CREATE TABLE IF NOT EXISTS ClanApps 
(
	id int(10) unsigned NOT NULL auto_increment PRIMARY KEY, 
	In_game_Name varchar(20) default NULL, 
	GSC_Login_Name varchar(20) default NULL, 
	Date_of_Birth varchar(10) default NULL, 
	Age varchar(2) default NULL, 
	State_Province varchar(25) default NULL, 
	Country varchar(20) default NULL, 
	Hear_About_TB varchar(255) default NULL, 
	Tactical_Realism varchar(255) default NULL, 
	Enjoyable_Gaming varchar(255) default NULL, 
	Join_Tactical_Brotherhood varchar (255) default NULL, 
	Former_CoD_Clan_1 varchar(25) default NULL, 
	Clan_1_Duration varchar(25) default NULL, 
	Former_CoD_Clan_2 varchar(25) default NULL, 
	Clan_2_Duration varchar(25) default NULL, 
	Former_CoD_Clan_3 varchar(25) default NULL, 
	Clan_3 _Duration varchar(25) default NULL, 
	Active_Presence varchar(3) default NULL, 
	EMail varchar(40) default NULL, 
	IP_Address text, 
	Date_Submitted text, 
	Approved text, 
)
') or die ('Error creating Table ' . mysql_error());

echo '<p>Creating table logsin'; 
mysql_query('
CREATE TABLE IF NOT EXISTS logsin 
(
	username varchar(100) NOT NULL, 
	`time` varchar(100) NOT NULL, 
	ip varchar(100) NOT NULL
)
') or die ('Error creating Table ' . mysql_error());

echo '<p>Creating table members'; 
mysql_query('
CREATE TABLE IF NOT EXISTS members 
(
	id int(100) NOT NULL auto_increment PRIMARY KEY, 
	email varchar(100) NOT NULL, 
	username varchar(21) NOT NULL, 
	`password` varchar(100) NOT NULL, 
	`date` varchar(100) NOT NULL, 
	confirm varchar(100) NOT NULL, 
	ip varchar(100) NOT NULL, 
)
') or die ('Error creating Table ' . mysql_error());

echo "<p>Tables installed correctly"; 
//...

[big-dog]

Using above code
Parse error: syntax error, unexpected T_STRING in /home/public_html/ClanApp/ClanAppView/set.php on line 129

Active_Presence varchar(3) default NULL, 
    EMail varchar(40) default NULL, 
    IP_Address text, 
    Date_Submitted text, 
    Approved text, 
) 
') or die ('Error creating Table ' . mysql_error()); 
Line 129
echo '<p>Creating table logsin'; 
mysql_query(' 
CREATE TABLE IF NOT EXISTS logsin

[djjjozsi]

Lets learn how to build a string: http://www.tizag.com/phpT/strings.php

Then run that string with mysql_query.

Did you select the database before you run a QUERY ?

If you don't keep the SQL syntax, your query won't create the tables:

is there a reason you add a field name using a space? Clan_3 _Duration

Always test your SQL query in phpmyadmin, and check if they are correct.

Hello, jjozsi.

[big-dog]

Thanks for the help I got it working.

[Weedpacket]

I like this: "Book learning is like reading Moby-Dick upside down in the dark ". If that's how you read books then I'm not surprised you find book learning difficult. 🙂

[djjjozsi]

however, he needs excamples then he will get excamples 🙂
This sounds like a Monty Python sketch 🙂

[big-dog]

Sorry guys if i dont understand the code all the time and I need help, but normally the code I post works till I try to modify something. I dont do this for a living I do it for my own personal site. I spend many hours on somethings trying to figure it out before coming to the forum. Most things I feel are probly very simple for you guys that know the code. It seems rudd to me that you bash me because I ask for help. if you dont want to help then dont reply

[Weedpacket]

Who's bashing you for asking for help? If I was going to bash you it wouldn't be for asking for help, but to poke fun at your misspelling "probably", "rude", and "don't" (and "example" and "newbie") on the grounds that a inline spellchecker like Firefox's would have highlighted them as being incorrect; I would have cheerfully ignored the fact that Firefox's inline spellchecker also doesn't recognise words like "inline", "spellchecker" and "Firefox's", but bashing never had to make sense.

But I didn't. I just had this mental image of you trying to read a book upside down in the dark and complaining that book learning was difficult. Perhaps you need to work on your analogies.

But you can't learn a programming language just from reading a book. Even books that teach programming languages (at least the good ones) don't expect you to. Doesn't mean books aren't useful: the PHP manual has more than eight thousand pages - I can't remember them all and I don't want to because they keep being updated. But what you do need to do is read programs and write programs. Pick interesting examples out of the manual and mess with them. Kind of what it sounds like you're doing. So chill.