Undefined Constant:

Timsoft

Hello,

I have a similar script running on a different server that uses this script to upload images. However, when I tried to use it for a .csv, I got an error for "undefined Constant for 'file_up' (2nd line), and again for every other time file up was used.

$file_upload="true";
$file_up_size=$_FILES['file_up'][size];
echo $_FILES[file_up][name];
if ($_FILES[file_up][size]>1250000){$msg=$msg."Your uploaded file size is more than 1,250KB so please reduce the file size and then upload. Visit the help page to know how to reduce the file size.<BR>";
$file_upload="false";}

if (!($_FILES[file_up][type] =="text/.csv" )){$msg=$msg."Your uploaded file must be a CSV. Other file types are not allowed<BR>";
$file_upload="false";}

$file_name=$_FILES[file_up][name];
$add="upload/$file_name";
 // the path with the file name where the file will be stored, upload is the directory name.
if($file_upload=="true")
{

   if(move_uploaded_file ($_FILES[file_up][tmp_name], $add))
   {
   echo "Your upload has been received...";
   }


   else
   {
   echo "Failed to upload file Contact Site admin to fix the problem";
   }

}
?>

From searching, it sounds like a simple syntax error, but I have done a great deal of tweaking with no luck. Any help would be appreciated....

laserlight

Basically, you are using strings for your array indices, but you did not quote them. So, this:

$file_up_size=$_FILES['file_up'][size];
echo $_FILES[file_up][name];

should be:

$file_up_size=$_FILES['file_up']['size'];
echo $_FILES['file_up']['name'];

and the same applies to other parts of the code.

Timsoft

Thanks for the quick reply, Laserlight.

Okay I tried that, got the following error...

Notice: Undefined index: file_up in C:\Inetpub\wwwroot\upload\uploadit.php on line 9 Notice: Undefined index: file_up in C:\Inetpub\wwwroot\upload\uploadit.php on line 10 Notice: Undefined index: file_up in C:\Inetpub\wwwroot\upload\uploadit.php on line 11 Notice: Undefined index: file_up in C:\Inetpub\wwwroot\upload\uploadit.php on line 14 Notice:


$file_upload="true";
$file_up_size=$_FILES['file_up']['size'];
echo $_FILES['file_up']['name'];
if ($_FILES['file_up']['size']>1250000){$msg="Your uploaded file size is more than 250KB so please reduce the file size and then upload. Visit the help page to know how to reduce the file size.<BR>";
$file_upload="false";}

if (!($_FILES['file_up']['type'] =="text/.csv" )){$msg="Your uploaded file must be a JPG or GIF. Other file types are not allowed<BR>";
$file_upload="false";}

$file_name=$_FILES['file_up']['name'];
$add="upload/$file_name"; // the path with the file name where the file will be stored, upload is the directory name.
if($file_upload=="true"){

if(move_uploaded_file ($_FILES['file_up']['tmp_name'], $add))

{
// do your coding here to give a thanks message or any other thing.

}else{echo "Failed to upload file Contact Site admin to fix the problem";}

}
?>

Do you see anything else wrong...

laserlight

Well, one mistake is that you are not checking to see if incoming variables like $_FILES['file_up'] exist before using them. You should check with [man]isset[/man] or [man]empty[/man].

Timsoft

Will that trigger an undefined index error...?

This is upload is just for two people on our intranet. I'm not too worried about building the perfect application. I just need it to work.

laserlight

Timsoft wrote:
Will that trigger an undefined index error...?

Yes, since $_FILES is an array.

Additionally, you might want to show the code for the form so that it can be verified as correct.

Timsoft

Here's the form..

     <form id="form1" 
name="form1" 
enctype="multipart/form-data"
method="post"
action="/upload/uploadit.php">
<input type="file" name="select_wall" id="select_wall" />
<input type="submit" name="button" id="button" value="Submit" />
    </form>

laserlight

hmm... the name of the file form element is "select_wall". This means that you should be accessing $FILES['select_wall'] instead of $FILES['file_up'].