Is this method acceptable or will it cause problems on a busy site?

[harmor]

I wrote the following piece of code to insert new users into the database.
I want to know if this approach will kill the server on a busy site or not.

class_user.php

	var $userbb = array('userid', 'username', 'password', 'ipaddress', 'email', 'msn', 'aol', 'yim', 'is_admin', 'zipcode', 'state', 'country', 'about', 'city', 'name', 'style', 'lastlogtime','salt');

function setUser($user = array())
{
	foreach ($user as $k => $v) 
	{
		$this->userbb[$k] = $v;
	}


	mysql_query("INSERT INTO users (username, password, ipaddress, email, msn, aol, yim, is_admin, zipcode, state, country, about, city, name, style, logged_in, lastlogtime, salt)
	VALUES ('".$this->userbb['username']."', '".$this->userbb['password']."', '".$this->userbb['ipaddress']."', '".$this->userbb['email']."',
	'".$this->userbb['msn']."', '".$this->userbb['aol']."', '".$this->userbb['yim']."', '".$this->userbb['is_admin']."',
	'".$this->userbb['zipcode']."', '".$this->userbb['state']."', '".$this->userbb['country']."', '".$this->userbb['about']."',
	'".$this->userbb['city']."', '".$this->userbb['name']."', '', '0', '0','".$this->userbb['salt']."')")
	or die(mysql_error());

}

register.php

	$setUser['username'] = $username;
	$setUser['ipaddress'] = $_SERVER['REMOTE_ADDR'];
	$setUser['email'] = $email;
	$setUser['password'] = $mgpuser->hashedpassword;
	$setUser['msn'] = $msn;
	$setUser['aol'] = $aol;
	$setUser['yim'] = $yim;
	$setUser['zipcode'] = $zipcode;
	$setUser['state'] = $state;
	$setUser['country'] = $country;
	$setUser['about'] = $mgpuser->about;
	$setUser['city'] = $city;
	$setUser['name'] = $name;
	$setUser['salt'] = $mgpuser->salt;

$mgpuser->setUser($setUser);

[Weedpacket]

On a live site "die(mysql_error())" is (a) lame, and (b) a security risk.

But all it's doing is throwing a handful of variables about via a reinvention of object properties (why?) and inserting one database record.

[harmor]

Here's my new approach.

register.php

$username = $mgpcom->clean($_POST['username']);
$password = $mgpcom->clean($_POST['password']);
$password2 = $mgpcom->clean($_POST['password2']);
$email = $mgpcom->clean($_POST['email']);
$msn = $mgpcom->clean($_POST['msn']);
$aol = $mgpcom->clean($_POST['aol']);
$yim = $mgpcom->clean($_POST['yim']);
$zipcode = $mgpcom->clean($_POST['zipcode']);
$state = $mgpcom->clean($_POST['state']);
$country = $mgpcom->clean($_POST['country']);
$about = $mgpcom->clean($_POST['about']);
$city = $mgpcom->clean($_POST['city']);
$name = $mgpcom->clean($_POST['name']);

$mgpuser->processUser($username, $password, $password2, '', $email, $msn, $aol, $yim, $zipcode, $state, $country, $about, $city, $name, '', '', "register");

class_user.php

function processUser($username, $password, $password2, $confirmnewpassword, $email, $msn, $aol, $yim, $zipcode, $state, $country, $about, $city, $name, $style = '', $userid = '', $script)
{	
	//code here to check if data is entered correctly



   $this->setUser($username,$password,$email,$msn,$aol,$yim,$city,$country,$state,$name,$zipcode,$this->about,$this->salt,$isadmin);
}

function setUser($username,$password,$email,$msn,$aol,$yim,$city,$country,$state,$name,$zipcode,$about,$salt,$isadmin = 0)
{
	mysql_query("INSERT INTO users (username, password, ipaddress, email, msn, aol, yim, is_admin, zipcode, state, country, about, city, name, style, logged_in, lastlogtime, salt)
	VALUES ('$username', '$password', '".$_SERVER['REMOTE_ADDR']."', '$email','$msn', '$aol', '$yim', '$isadmin','$zipcode', '$state', '$country', '$about','$city', '$name', '', '0', '0','$salt')");

}

[Ryan_Sanders]

Personally, when I do things like this, where you are putting new users into a database, I kind of do the following (basic idea):

Then, when you submit that form, I would make the action of the form either go to a new page like your doing, or just a variable of the page, such as newuser.php?page=submit.

Since you are doing it with 2 pages, I will do that too.

Now we have the other page.. and for the coding on here, it would be really simple really. First I would redo all my posted variables such as:
[code=php]$username = mysql_real_escape_string($_POST['username'];
$password = mysql_real_escape_string($_POST['password']; 

and so on. I guess you could make a shorter named function for mysql_real_escape_string if you wanted.

Anyway, I would go through all of those. And then, when you insert into database, just do like:

mysql_query("INSERT INTO users (username, password, password2, etc) VALUES ('$username', '$password', '$password2', '$etc')");

Now this is basic code and you would have to mess with it to fit your needs within your website or whatever, but I don't see the use of doing all the stuff your doing. Maybe I am doing this wrong, but it works fine. Now, your coding might be more secure, I am not sure. Thats just how I do it.