file upload and form mail

[falseharmonix]

Hello all,

I've acquired a form mailer script, and have written a file upload script. Both scripts function as stand-alone scripts. However, I have a form (name, tel, email) that I am using for my file upload page. The script is intended to both:

1) display a success/thank you page to customer after file has been successfully uploaded.

2) email a notification to my company sharing customer info.

The problem I'm having is that instead of going to the error or success pages, it loads the upload script into the url and displays a blank page (ie...www.mycompany.com/upload.php)

attached is the code. Any suggestions?

<?php // upload_file.php


$mailto = '[e-mail]' ;
$subject = "File Uploaded To Server" ;

$formurl = "http://www.mycompany.com/upload.html" ;
$errorurl = "http://www.mycompany.com/upload_error.html" ;
$thankyouurl = "http://www.mycompany.com/upload_thank_you.html" ;

$email_is_required = 0;
$name_is_required = 0;
$uself = 0;
$use_envsender = 0;
$use_webmaster_email_for_from = 0;
$use_utf8 = 1;

$headersep = (!isset( $uself ) || ($uself == 0)) ? "\r\n" : "\n" ;
$content_type = (!isset( $use_utf8 ) || ($use_utf8 == 0)) ? 'Content-Type: text/plain; charset="iso-8859-1"' : 'Content-Type: text/plain; charset="utf-8"' ;

if (!isset( $use_envsender )) { $use_envsender = 0 ; }
$envsender = "-f$mailto" ;
$name = $_POST['name'] ;
$email = $_POST['email'] ;
$contact = $_POST['contact'];

$http_referrer = getenv( "HTTP_REFERER" );

if (!isset($_POST['email'])) {
	header( "Location: $formurl" );
	exit ;
}
if (($email_is_required && (empty($email) || !ereg("@", $email))) || ($name_is_required && empty($name))) {
	header( "Location: $errorurl" );
	exit ;
}
if ( ereg( "[\r\n]", $name ) || ereg( "[\r\n]", $email ) ) {
	header( "Location: $errorurl" );
	exit ;
}
if (empty($email)) {
	$email = $mailto ;
}
$fromemail = (!isset( $use_webmaster_email_for_from ) || ($use_webmaster_email_for_from == 0)) ? $email : $mailto ;

if (get_magic_quotes_gpc()) {
	$comments = stripslashes( $comments );
}

$messageproper =
	"This message was sent from:\n" .
	"$http_referrer\n" .
	"------------------------------------------------------------\n" .
	"Name of sender: $name\n".
	"Email of sender: $email\n".
	"Contact Via: $contact\n".
	"FIle Uploaded: $thefile\n".;


$headers =
	"From: \"$name\" <$fromemail>" . $headersep . "Reply-To: \"$name\" <$email>" . $headersep . "X-Mailer: chfeedback.php 2.13.0" .
	$headersep . 'MIME-Version: 1.0' . $headersep . $content_type ;


//create customer folder

$dir = $_POST['name'];

mkdir ("../customer_uploads/$dir");  //folder is created for file


if (isset($_POST['submitted'])) { //handle the form

if (move_uploaded_file ($_FILES['thefile']['tmp_name'], "../customer_uploads/$dir/{$_FILES['thefile']['name']}")) {
	mail($mailto, $subject, $messageproper, $headers );
    header( "Location: $thankyouurl" );
    exit ;

}
           	else {// error
	                header( "Location: $errorurl" );
	                exit ;

  } // end error


 } // end of submission if


?>

[falseharmonix]

Here is the form code as well---

<form action="upload_file.php" method="post" enctype="multipart/form-data">
      <p align="right">
        <label>
        <center>
          <span class="body_text">Name:</span>
          <input name="name" type="text" size="30" />
        </center>
        </label>
      </p>
      <p align="right">
        <label>
        <center>
          <span class="body_text">Email:</span>
          <input name="email" type="text" size="30" />
        </center>
        </label>
      </p>
      <p align="right">
        <label>
        <center>
          <span class="body_text">Preferred Method of Contact:</span>
          <select name="contact">
            <option value="phone">Phone</option>
            <option value="email">Email</option>
            </select>
        </center>
        </label>
        </p> 
         <p align="center"><b><font color="#0000FF">Upload your artwork using this form:</font></b></p>
      	 <input type="hidden" name="MAX_FILE_SIZE" value="500000" />
      	 <p align="center"><input id="file" type="file" name="thefile" size="30"/></p>
      	 <p align="center"><input type="submit" name="submit" value="Upload This File" /></p>
      	 <input type="hidden" name="submitted" value="true" />    

      </form> 

[dalecosp]

Well, I'll get things started.

Have you read "Debugging 101" (linkage below). Put in a few tests:

echo "It got this far!"; exit;

and see if you can find where control is being lost.

Also, linting the file (php -l) shows:

PHP Parse error:  parse error in foo.php on line 81
Errors parsing foo.php

Now, line 81 here locally is:

"FIle Uploaded: $thefile\n".;

... and that lil' parse error could very well be the bug we're looking for.

[falseharmonix]

dalecosp;10904562 wrote:

Well, I'll get things started.

Have you read "Debugging 101" (linkage below). Put in a few tests:

echo "It got this far!"; exit;

and see if you can find where control is being lost.

Also, linting the file (php -l) shows:

PHP Parse error:  parse error in foo.php on line 81
Errors parsing foo.php

Now, line 81 here locally is:

"FIle Uploaded: $thefile\n".;

... and that lil' parse error could very well be the bug we're looking for.

Thanks for the reads.

I put multiple echos in the file and couldn't get it to puke anything at all. Line 81 was fine...couldn't find anything.

I'm still hunting...any other suggestions?

[NogDog]

Did you remove the concatenation "." before the terminating ";" on that line?

PS: If your PHP configuration does not have the display_errors option turned on, you will not see parse errors in your output. You will either have to change the config (it will not help to turn it on within the script), check the error logs, or else use an editor that has a built-in PHP parse checker.

[falseharmonix]

NogDog;10904644 wrote:

Did you remove the concatenation "." before the terminating ";" on that line?

PS: If your PHP configuration does not have the display_errors option turned on, you will not see parse errors in your output. You will either have to change the config (it will not help to turn it on within the script), check the error logs, or else use an editor that has a built-in PHP parse checker.

Hmmm...I guess I should have caught that...

Thank you, did the trick. I hope to be sticking around here more.

[dalecosp]

falseharmonix;10904647 wrote:

Hmmm...I guess I should have caught that...

Thank you, did the trick. I hope to be sticking around here more.

Well, Welcome to Phpbuilder 🙂

I would heartily commend, if you have time and geek factor enough, installing a PHP CLI binary on your system. Now, I'm an old-phart UNIXY type guy, but all I had to do to catch the error was enter a terminal and type "php -l file.php". Very Handy.

[NogDog]

Or just use an editor with automated PHP parse-checking and catch them while editing. 🙂