I have a rather large code to be critiqued

Iank

its rather large common.php file and I want to see if anyone can help me find out why its crashing my server when several people play. I am a newbie and would like to ask any of you for help please. There are a couple things I want to do and cant figure out how to do them.

Iam not sire how to attach the file here. So if anyone is up for a little task it would be GREATLY appreciated.

Thanks

nrg_alpha

Well, when you test locally using <?php error_reporting(E_ALL | E_STRICT); ?> does it give you any kind of errors / warnings?

I would start be checking to see if/what's being reported locally, and start with that.

Iank

I have no idea how to do that. would you be able to show me please?

nrg_alpha

In your code, insert this line at the top within your php tags:

error_reporting(E_ALL | E_STRICT);

This will help out with debugging your page with regards to warnings / errors. If you are too new at PHP, I would recommend taking a step back and advance yourself through php books, online tutorials and other such resources.

Iank

ok I will do that, thank you very much. I will let you know how it goes

Iank

its not doing anything on my page. either I have no errors, or im doing something wrong. Can I show you the script?

nrg_alpha

sure.. just be sure to paste your script within [ php] [ /php] tags..(without spaces in those tags) when posting it here. Makes it all colour coded and easier to read.

bradgrafelman

Also, depending upon how large "rather large" is, it may be easier to simply attach the script in a .txt file to your post due to the character limit.

Iank

its, ehem 2000 lines long lol

bradgrafelman

Then yes, attaching it as a text file is probably your best bet.

Iank

Here is the file

NogDog

In addition to setting the error level, you may need to turn on error display:

<?php
ini_set('display_errors', 1);
error_erporting(E_ALL | E_STRICT);
// rest of script...
?>

I would recommend eschewing the use of the "<?" and "<?=" tags in favor of the more widely supported "<?php" and "<?php echo" options.

I would also recommend a lot of modularization, moving function definitions into separate include file to be required as needed by your script, separating output from program control logic and data, etc., so that you have files that are at most a few hundred lines long instead of one monster that is thousands of lines long. It will save you from many future headaches.

Iank

ok thank you very much I will try that. Just how to I get 4-5 include files to be read from the command.php file? How do I connect them all? also will that ease the server load?

NogDog

As a trivial example:

includes/hello.php:

<?php
function hello($name)
{
   return "Hello, $name";
}

index.php:

<?php
require_once 'includes/hello.php';
echo hello('World');

The include file could have any valid PHP in it. When you require/include it, it is as though its code were typed into the calling script right where the include is executed. If you have several related functions that are usually used together, you could group their definitions into one include file, while large functions or those only used occasionally might be put into separate include files and only called when needed in your main scripts. (For that matter, an include file can include another file, etc....)

Iank

ahhh ok. stuff like the login function is used once every 3 hours and the top scores are top 100 out of 400 users, stuff like that I can put into an include.php file?

This script you are looking at now crashes the server BIG time. When several players are playing at the sametime you see the server strain then it crashes.

now deciding what functions to put in the include.php file is another headache lol.

Listen, thanks for all your help. Iam a newbie as you can tell and need all the help I can get.

NogDog

One thing I see is that you do a lot of database queries, some of them in loops so that they may occur many times more. A little preg_match_all() on the file shows 51 separate SELECT queries:

[1]"SELECT id,unix_timestamp(date) as datets,uid_from,what,amt,what_req,amt_req,auth FROM $logtrade_table WHERE uid_to=$user and hide=0 and auth=0 ORDER by date DESC"
[2]"SELECT id,unix_timestamp(date) as datets,uid_from,what,amt,what_req,amt_req,auth FROM $logtrade_table WHERE uid_to=$user and hide=0 and auth=0 ORDER by date DESC"
[3]"SELECT id,unix_timestamp(date) as datets,uid_to,what,amt,what_req,amt_req,auth,hide FROM $logtrade_table WHERE uid_from=$user ORDER by date DESC limit 50 "
[4]"SELECT pic, name FROM user WHERE uid=$uid"
[5]"SELECT pic, name FROM user WHERE uid=$uid"
[6]"SELECT $col FROM $users_table WHERE uid=$user"
[7]"SELECT cup,unix_timestamp(date) as date,win FROM $history_table WHERE uid=$user ORDER BY date DESC LIMIT $num"
[8]"SELECT unix_timestamp(date) as date,uid_to,what,amt FROM $logsend_table WHERE uid_from=$user"
[9]"SELECT unix_timestamp(date) as date,uid_from,what,amt FROM $logsend_table WHERE uid_to=$user"
[10]"SELECT unix_timestamp(date) as date,reg_add,lj_bonus,ic_bonus,hu_bonus,rod_bonus,chr_bonus,val_bonus,bug_bonus,camp_bonus,ch_bonus,coin_bonus,bill_bonus,bd_bonus,bb_bonus,cookie_bonus,metal_bonus,gem_bonus FROM $bonus_table WHERE uid=$user"
[11]"SELECT unix_timestamp(NOW()) - unix_timestamp(last_logon_credit)
                                                        from $users_table where uid=$user"
[12]"SELECT sum($prize) FROM $users_table"
[13]"SELECT sum(new) FROM $cpa_table WHERE uid=$user and notified='0'"
[14]"SELECT uid_from,notified_to FROM $logtrade_table WHERE uid_to=$user and notified_to='0'"
[15]"SELECT id,uid_from,what,amt FROM $logsend_table WHERE uid_to=$user and notified='0' and trade=0"
[16]"SELECT sum(coupon1) FROM $users_table WHERE uid=$user and coupon1_notified='0'"
[17]"SELECT sum(survey1) FROM $users_table WHERE uid=$user and survey1_notified='0'"
[18]"SELECT count(id) FROM $refs_table WHERE ruid=$user and notified='0'"
[19]"SELECT iuid FROM $invites_table WHERE uid=$user"
[20]"SELECT uid FROM $users_table ORDER BY $type DESC"
[21]"SELECT uid, $type FROM $users_table ORDER BY $type DESC LIMIT $start,$offset"
[22]"SELECT uid, $type FROM $users_table where uid=$user"
[23]"SELECT uid, $type FROM $users_table WHERE uid IN ('"
[24]"SELECT cups_played FROM $users_table WHERE uid=$user limit 1"
[25]"SELECT cents FROM $users_table WHERE uid=$user limit 1"
[26]"SELECT money_bought FROM $users_table WHERE uid=$user limit 1"
[27]"SELECT regular_intervals FROM $users_table WHERE uid=$user limit 1"
[28]"SELECT invites FROM $users_table WHERE uid=$user limit 1"
[29]"SELECT invite_days FROM $users_table WHERE uid=$user limit 1"
[30]"SELECT impressions FROM $users_table WHERE uid=$user limit 1"
[31]"SELECT cpa_offers FROM $users_table WHERE uid=$user limit 1"
[32]"SELECT ref FROM $users_table WHERE uid=$user limit 1"
[33]"SELECT last_logon_credit FROM $users_table WHERE uid=$user limit 1"
[34]"SELECT last_logon FROM $users_table WHERE uid=$user limit 1"
[35]"SELECT active FROM $users_table WHERE uid=$user limit 1"
[36]"SELECT sid FROM $users_table WHERE uid=$user limit 1"
[37]"SELECT id FROM $users_table WHERE uid=$user limit 1"
[38]"SELECT created FROM $users_table WHERE uid=$user limit 1"
[39]"SELECT $param FROM $users_table WHERE uid=$user limit 1"
[40]"SELECT notifications FROM $users_table WHERE uid=$user limit 1"
[41]"SELECT notification_days FROM $users_table WHERE uid=$user limit 1"
[42]"SELECT app_installs FROM $users_table WHERE uid=$user limit 1"
[43]"SELECT country FROM $users_table WHERE uid=$user"
[44]"SELECT uid, unix_timestamp(date), city_province, name, comments from $winners_table where verified=1 order by id desc limit 1"
[45]"SELECT pic FROM user WHERE uid=$uid"
[46]"SELECT win_nothing,win_nothing_last from $users_table where uid=$user"
[47]"SELECT count(uid) FROM $users_table where unix_timestamp(NOW()) - unix_timestamp(last_logon) < $online_time"
[48]"SELECT id FROM $refs_table WHERE uid=$person and ruid=$referer"
[49]"SELECT active FROM $users_table WHERE uid=$user limit 1"
[50]"SELECT unix_timestamp(NOW()) - unix_timestamp(last_logon_credit)
                          from $users_table WHERE uid=$user"
[51]"SELECT iuid,uid FROM $invites_table WHERE uid=$user"

One thing that probably needs to be done is to figure out how much effort is being duplicated among them, and consolidating multiple queries into single queries. Even if an individual query becomes more complicated, 1 complex query that replaces 10 simple queries will likely save a lot of processing.

Now to ask me to wade through all that code and actually figure out what could/should be combined is a lot more effort than I'm ready to do [for free] at this time. 😉

Iank

thats understandable, its a huge code with lots of problems. I really appreciate the help you've given me so far. How much would you charge to go threw that code and streamline it and make it purr like a kitten?

Iank

is that alot of queries? could that cause my server crashes when I get to many people playing at once?

NogDog

Iank;10904734 wrote:
thats understandable, its a huge code with lots of problems. I really appreciate the help you've given me so far. How much would you charge to go threw that code and streamline it and make it purr like a kitten?

Job offers and discussion of actual charges/rates are not allowed on these forums.

I probably should not have worded my response in such a suggestive manner. I just wanted to point out that to really fix things would require someone to do some detailed analysis of the requirements and likely do some major rewriting.

As to whether that is what is causing the server to crash, there is no way at this point to be sure without doing some sort of code metering or otherwise figuring out in detail the root cause(s) of the crashes. But certainly if each access to the page is triggering dozens of database queries, it might be a cause, but that is pure speculation at this point.

nrg_alpha

NogDog;10904778 wrote:
Job offers and discussion of actual charges/rates are not allowed on these forums.

I probably should not have worded my response in such a suggestive manner.

Indeed not. I was about to suggest that you charge him double and give me half! :p But your response deflated my excitement in the matter all of a sudden...