multiple updates one form...

[johnworf]

Hi,

I used this tutorial....

http://www.phpeasystep.com/mysqlview.php?id=10

Unfortunately it doesn't seem to work...i get the records out no problem... but when i click the update it doesn't do anything - just comes back to the same page and the data is identical - anyone any ideas how to update multiple records in one go?

i tried to show one record and updated that ok - but i couldn't do multiple records - so it has nothing to do with priviliges.

this is the test data..

CREATE TABLE `test_mysql` (
`id` int(4) NOT NULL auto_increment,
`name` varchar(65) NOT NULL default '',
`lastname` varchar(65) NOT NULL default '',
`email` varchar(65) NOT NULL default '',
PRIMARY KEY (`id`)
) TYPE=MyISAM AUTO_INCREMENT=7 ;

-- 
-- Dumping data for table `test_mysql`
-- 

INSERT INTO `test_mysql` VALUES (1, 'Billly', 'Blueton', '[e-mail]');
INSERT INTO `test_mysql` VALUES (2, 'Jame', 'Campbell', '[e-mail]');
INSERT INTO `test_mysql` VALUES (3, 'Mark', 'Jackson', '[e-mail]');
INSERT INTO `test_mysql` VALUES (4, 'Linda', 'Travor', '[e-mail]');
INSERT INTO `test_mysql` VALUES (5, 'Joey', 'Ford', '[e-mail]');
INSERT INTO `test_mysql` VALUES (6, 'Sidney', 'Gibson', '[e-mail]');

and this is the update page...

<?php
$sql="SELECT * FROM $tbl_name";
$result=mysql_query($sql);

// Count table rows
$count=mysql_num_rows($result);
?>
<table width="500" border="0" cellspacing="1" cellpadding="0">
<form name="form1" method="post" action="">
<tr>
<td>
<table width="500" border="0" cellspacing="1" cellpadding="0">


<tr>
<td align="center"><strong>Id</strong></td>
<td align="center"><strong>Name</strong></td>
<td align="center"><strong>Lastname</strong></td>
<td align="center"><strong>Email</strong></td>
</tr>
<?php
while($rows=mysql_fetch_array($result)){
?>
<tr>
<td align="center"><? $id[]=$rows['id']; ?><? echo $rows['id']; ?></td>
<td align="center"><input name="name[]" type="text" id="name" value="<? echo $rows['name']; ?>"></td>
<td align="center"><input name="lastname[]" type="text" id="lastname" value="<? echo $rows['lastname']; ?>"></td>
<td align="center"><input name="email[]" type="text" id="email" value="<? echo $rows['email']; ?>"></td>
</tr>
<?php
}
?>
<tr>
<td colspan="4" align="center"><input type="submit" name="Submit" value="Submit"></td>
</tr>
</table>
</td>
</tr>
</form>
</table>
<?php
// Check if button name "Submit" is active, do this
if($Submit){
for($i=0;$i<$count;$i++){
$sql1="UPDATE $tbl_name SET name='$name[$i]', lastname='$lastname[$i]', email='$email[$i]' WHERE id='$id[$i]'";
$result1=mysql_query($sql1);
}
}

if($result1){
header("location:update_multiple.php");
}
mysql_close();
?>

[quaffapint]

Looks like it's assuming global is turned on, which it should not be. So, you need to first grab all the variables from the $_POST array - sanitize them and then you can use them. For example...

if (isset($POST['Submit'])){
$Submit = strip_tags($POST['Submit']);
}

...thats a simple example, probably better sanitization and such would be necessary.

[djjjozsi]

and $tbl_name is not set in your code.

[johnworf]

hi,

yep it was the globals needed turning on...i created a new php.ini file and put it in the folder is that the right thing to do?

where is the php.ini file located?

PS - I set the $tbl_name higher up in the code with the connection string - so i haven't listed that bit of code.

[djjjozsi]

yep it was the globals needed turning on..

I suggest do not enable the register globals, write your code suitable for php5+

you reach the variable from your link with $GET,
from your forms the variables with $POST
The session variables stored in $SESSION
the server variables you get from $SERVER superglobals.

[johnworf]

djjjozsi;10905410 wrote:

I suggest do not enable the register globals, write your code suitable for php5+

you reach the variable from your link with $GET,
from your forms the variables with $POST
The session variables stored in $SESSION
the server variables you get from $SERVER superglobals.

so are you saying the code would break down if my host went to a different php level?

also i'm not entirely sure how to encorporate this into my code as to be honest i'm a bit of a newbie.

[johnworf]

i was getting an error on the header file...

so i've deleted that and changed it to...

echo "<meta http-equiv=\"refresh\" content=\"0;URL=index.php\">";

it now works perfectly.