Coding for Enquiry Form

ched53

I'm having an absoloute nightmare trying to get an enquiry form to work on a website that I am designing. Firstly, let me point out I am a complete newbie with PHP so please pardon my ignorance on the subject, im a graphic designer not a programmer. The address for the page where the enquiry form is http://www.hairbykirbyblythe.co.uk/enquiries.html.

So far I am at a point where clicking the submit button correctly goes to the 'Thanks for your message' page, but no email is being received at all. Can someone please tell me what is wrong with my code?

This is the php on the enquiries page itself:

<?php
ini_set("sendmail_from", " kirby@hairbykirbyblythe.co.uk ");
mail($email_to, $email_subject, $email_message, $headers, '-fkirby@hairbykiryblythe.co.uk');
?>
      <?php

ini_set('sendmail_from', $email_from); 
$email_to = "kirby@hairbykirbyblythe.co.uk";
$name =$_POST['Name'];
$email_from =$_POST['email']; 
$email_subject = "Enquiry";
$comments = $_POST['message'];
$headers = 
"From: $email_from .\n";
"Reply-To: $email_from .\n";

$message= "Name: ". $name  . "\ntelephone: " . $telephone; "\nemail: " . $email;

$sent = mail($email_to, $email_subject, $message, $headers, '-f .$email_from');
	if ($sent)
		{
			header( "Location: http://www.hairbykirbyblythe.co.uk" ); 
		} else {
			/* If there is an error display an error message */
			echo 'There has been an error sending your enquiry. Please try later.'; 
		}
?>

And my sendmail.php file is as follows:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>Untitled Document</title>
</head>

<body>
<?php
ini_set("sendmail_from", " [email]kirby@hairbykirbyblythe.co.uk[/email] ");
mail($email_to, $email_subject, $email_message, $headers, '-fkirby@hairbykiryblythe.co.uk');
?>
<?php

ini_set('sendmail_from', $email_from);
$email_to = "kirby@hairbykirbyblythe.co.uk";
$name =$_POST['Name'];
$email_from =$_POST['email'];
$email_subject = "Enquiry";
$comments = $_POST['message'];
$headers =
"From: $email_from .\n";
"Reply-To: $email_from .\n";

$message= "Name: ". $name . "\ntelephone: " . $telephone; "\nemail: " . $email;

$sent = mail($email_to, $email_subject, $message, $headers, '-f .$email_from');
if ($sent)
{
header( "Location: http://www.hairbykirbyblythe.co.uk/thanks.html" );
} else {
/* If there is an error display an error message */
echo 'There has been an error sending your enquiry. Please try later.';
}
?>
</body>
</html>

The host of the account is Fasthosts on a Windows home package if this helps. All help and advice would be much appreciated. I've had this issue for months now and just want to get it sorted 🙁

djjjozsi

in a normal html file you can't run php codes.

as you see the source code on the posted url.

the action in the form is sendmail.php

in the sendmail.php you need to applicate the mail sender codes.

in first lines do not take tha mail function, becouse that will send empty mails (if you did not fill the forms.)

Always use the empty command to check if a variable has a value.

if(empty($_POST["value"]))
{
die("Ypi did not filled the value field");
}

look around your script where you use ; semicolumns, for example when you set the $header

If you use header function in your code, do not print anything becouse you will get a warning message:

The header already sent.

ched53

do i post that in the sendmail.php?

I've renamed the Enquiries.html to enquiries.php and now it's looking like this: http://hairbykirbyblythe.co.uk/enquiries.php

I apologize again for my lack of knowledge, to probably have to use kid talk with me as I'm lost when it comes to the terminology

djjjozsi

lets have a look at the typo mistakes in the code:

As a concate character you've used a ; character
"\ntelephone: " . $telephone; "\nemail: "

to the $header string you did not add the second line:
$headers =
"From: $email_from .\n";
"Reply-To: $email_from .\n";

s, '-f .$email_from'); if you use apostrofes, your variable will nor get into your $header variable perfectly.

$name =$_POST['Name'];

In your html form the Name variable name is Name:

anees_muhd

Try this Function to send

$email_to = "kirby@hairbykirbyblythe.co.uk";
	$name =$_POST['Name'];
	$email_from =$_POST['email'];
	$email_subject = "Enquiry";
	$comments = $_POST['message']; 


$message= "Name: ". $name . "<br>telephone: " . $_POST['$telephone']; "<br>email: " . $email_from."<br>Comments:".$comments; 

$result = mail_function('To Name',$email_to,$name,$email_from,$email_subject,$message,'','','','');

if($result)
	echo "Mail sent successfully";
else
	echo "mail sending failed";








function mail_function($to_msg,$to_email,$from_msg,$from_email,$subject,$message,$cc,$bcc,$reply,$file='')
{
	$semi_rand = md5(time());
		/*		Set MIME Boundary for multipart mail	*/
	$mail_boundary = "==Multipart_Boundary_x{$semi_rand}x";

	$headers = "MIME-Version: 1.0\r\n" .
		"Content-Type: multipart/mixed;\r\n" .
		" boundary=\"{$mail_boundary}\"\r\n";
	$mail_msg = "This is a multi-partmessage in
	MIME format.\r\n\r\n" ;

	/* additional headers */
	$headers .= "To: $to_msg <$to_email>\r\n";
	$headers .= "From: $from_msg <$from_email>\r\n";
	if($cc)
	{
		$headers .= "Cc: $cc\r\n";
	}
	if($bcc)
	{
		$headers .= "Bcc: $bcc\r\n";
	}
	if($reply)
	{
		$headers .= "Reply-To: $reply\r\n";
	}

	$mail_msg .= "--{$mail_boundary}\r\n" .
				"Content-Type: text/html;\r\n" .
				"Content-Disposition: inline;\r\n\r\n" ;
	$mail_msg .= $message."\r\n";

	if(file_exists($file))
		{
		//$ext = $this->Find_Ext($fname);
		$handle = fopen($file,'r');
		$file_data .= "--{$mail_boundary}\r\n" .
				"Content-Type: {$ext};\r\n" .
				" name=\"{$fname}\"\r\n" .
				"Content-Disposition: attachment;\r\n" .
				" filename=\"{$fname}\"\r\n" .
				"Content-Transfer-Encoding: base64\r\n\r\n" ;
		$file_data .= chunk_split(base64_encode(fread($handle,filesize($file))))."\r\n";
		fclose($handle);
		$mail_msg .= $file_data; 
		}

	$mail_msg .= "\r\n" . "--{$mail_boundary}--\r\n";


	if(@mail($to_email, $subject, $mail_msg, $headers))
	{
		return true;
	}
	else
	{
		return false;
	}
}

ched53

So here's where I'm at. It is sending me an email but with nothing but field names in the message. And I still have all that awful error messages on my enquiries page The PHP on my enquiries (http://www.hairbykirbyblythe.co.uk/enquiries.php) page is:

<?php
ini_set("sendmail_from", " kirby@hairbykirbyblythe.co.uk ");
mail($email_to, $email_subject, $email_message, $headers, '-fkirby@hairbykiryblythe.co.uk');
?>
      <?php

ini_set('sendmail_from', $email_from); 
$email_to = "kirby@hairbykirbyblythe.co.uk";
$name =$_POST['Name'];
$email_from =$_POST['email']; 
$email_subject = "Enquiry";
$comments = $_POST['message'];
$headers =
"From: $email_from .\n";
"Reply-To: $email_from .\n";

$message= "Name: ". $name . "\ntelephone: " . $telephone . "\nemail: " . $email . "\nenquiry: " . $nenquiry;

$sent = mail($email_to, $email_subject, $message, $headers, '-f .$email_from');
	if ($sent)
		{
			header( "Location: http://www.hairbykirbyblythe.co.uk/thanks.html" ); 
		} else {
			/* If there is an error display an error message */
			echo 'There has been an error sending your enquiry. Please try later.'; 
		}
?>

and my sendmail.php is:

<?php
error_reporting(E_ALL ^ E_NOTICE);
$email_to = "kirby@hairbykirbyblythe.co.uk";
$name =$_POST['Name'];
$email_from =$_POST['email'];
$email_subject = "Enquiry";
$comments = $_POST['message'];
$headers ="From: $email_from\r\nReply-To: $email_from\r\n";

$message= "Name: ". $name . "\ntelephone: " . $telephone . "\nemail: " . $email . "\nenquiry: " . $nenquiry;

$sent = mail($email_to, $email_subject, $message, $headers);
if ($sent) {
  header( "Location: http://www.hairbykirbyblythe.co.uk/thanks.html" );
} else {
  /* If there is an error display an error message */
  echo 'There has been an error sending your enquiry. Please try later.';
}
?>

I'm sorry if it appears I haven't taken notice of what some people have said, thats not true - its just that I havent understood (as I said, I'm completely alien to all this). If you could just highlight the areas that are incorrect and let me know what I need to change them to I would be so grateful.

Weedpacket

The <form> elements you're using do use the POST method, right and these files are named in the actions?

$headers =
"From: $email_from .\n";
"Reply-To: $email_from .\n";

You'll still only get one of these; djjjozsi pointed in this direction. ; doesn't join two strings together, it marks the end of a statement. Joining two strings together is .'s job. Or you could just do it the same way that you do it in sendmail.php 🙂

Immediately after the statement

  header( "Location: http://www.hairbykirbyblythe.co.uk/thanks.html" );

you should put an exit(). If you don't tell PHP to stop there it will just keep going until it gets to the end of the script.

ched53 wrote:
And I still have all that awful error messages on my enquiries page

You'll get those errors if you use variables that don't exist. Do you mean $email_from where you say $email? What is $nenquiry?

A big problem here is that you're trying to construct and send an email every time the page is loaded - which is going to be before anyone can have a chance to fill it out!

It's sendmail.php that does all the work of constructing and sending the email, enquiry.php is just displaying the form - it doesn't need any of that email stuff.

djjjozsi

This is not the very best you could solve this mailer, but this will send it for you.

SEE THE CODE HERE

in the form php page remove the mail function, you didn't need to send the mail!

when the user filled and submit the form, the user go to sendmail.php, that is the page where you need to check if all the fields has filled, and that is the page where you need to use the mail function, not in the form page!

// if the mailer program works gread, switch OFF ALL  PHP errors
error_reporting(0);

message variable name in your original FORM did not exists,
name variable name in your form is not exists.

you mean $_POST["name:"] : is in it!

and $POST["enquiry"] is the message variable name in your FORM, and not $POST["message"]

Weedpacket

There are other things involved, and it will be worth addressing them.

sendmail.php is probably unnecessary. Have the enquiries.php form have itself as its action. Now it's a matter of having it (a) display the form and (b) send the email, and have it do the appropriate thing at the appropriate time. Why do them in the same file? If we get all the details we need for an email, we can construct the email, send it, and go on to the thank you page. If we don't get all the details we need (perhaps because the page is just being loaded for the first time, or something necessary was left out), we can just redisplay the form - and even helpfully fill in the fields that were filled in.

For the sake of simplification, I'll just have two necessary fields: 'name' and 'email', and one optional field, 'telephone'. We need the first two to be filled in, but the last one can be left blank.

[man]empty[/man] and [man]isset[/man] are your friends when checking to see if something has been filled in. We'll use [man]empty[/man] because [man]isset[/man] thinks a blank string qualifies as being "set".

<?php
// Make sure these are *not* empty
if(!empty($_POST['email']) && !empty($_POST['name']))
{
    $email = $_POST['email'];
    $name = $_POST['name'];
    if(empty($_POST['telephone']))
        $telephone = ''; // Make sure $telephone exists even if it is empty.
    else
        $telephone = $_POST['telephone'];

// Build the email message, using $email, $name, and $telephone
// Send it
// If we're successful, redirect to the thank you page.
// If we're not successful, redirect to a navigable error page (this is nicer than just thumping the user over the head and stopping)
exit;
}
// If we get here, we didn't get everything we needed to try sending an email.
if(empty($_POST['email']))
     $email = ''; // email was empty
else
    $email = htmlspecialchars($_POST['email']);
// Incidentally, the above could be written more succinctly as $email = empty($_POST['email']) ? '' : htmlspecialchars($_POST['email']);
// htmlspecialchars because we'll be plonking it down in the middle of the HTML form and we don't want silliness breaking the HTML.

// Ditto to set $name and $telephone
?>
<html>
<head><title></title></head><body><!-- yadayadayada -->
<input type="text" name="name" value="<?php echo $name?>" />
<input type="text" name="email" value="<?php echo $email?>" />

Oh, and I think that complaint mentioning SMTP is attributable to this bit

'-f .$email_from'

needing to be in double quotes, not single. In single quotes, '$foo' is interpreted to mean just that: "dollar-sign eff oh oh".