delete folder with files help

tjburke79

Hello:

I am using the below script to delete a users folder where photos are stored. It works great, but I need to know if there is any sure fire solid way that I can make it so that the root folder where the photos are stored (user_photos) will not get deleted if the $user_id is blank.

public_html
- user_photos
-- user_id 1 folder
-- user_id 2 folder
-- user_id 3 folder
-- user_id 4 folder
-- etc

function remove_directory($dir) {
	if($dir == "../user_photos/") {
	} else {
  		if ($handle = @opendir("$dir")) {
   			while (false !== ($item = readdir($handle))) {
     				if ($item != "." && $item != "..") {
       					if (is_dir("$dir/$item")) {
         					remove_directory("$dir/$item");
       					} else {
         					unlink("$dir/$item");
       					}
				}
			}
			closedir($handle);
		rmdir($dir);
		}
	}
}


remove_directory("../user_photos/$user_id");

any input on this? i think what i have there is fine, i just want to know if there is a better way to do this so i have some security knowing that the user_photo directory will not get deleted somehow

scrupul0us

the path and uid and should be two sep variables passed to the function... it makes it more versatile

that being said:

function remove_directory($dir,$uid) 
{
	if(empty($dir) or empty($uid))
	{
		die('You must gimme a uid or dir');
	}
	else
	{
		if($dir == '../user_photos/') 
		{
			die('Invalid directory');
		} 
		else 
		{
			if ($handle = @opendir("$dir")) 
			{
				while (false !== ($item = readdir($handle))) 
				{
					if ($item != "." && $item != "..") 
					{
						if (is_dir("$dir/$item")) 
						{
							remove_directory("$dir/$item"); //you're using your function within the function
						} 
						else 
						{
							unlink("$dir/$item");
						}
					}
					else
					{
						//do what???
					}
				}
				closedir($handle);
				rmdir($dir);
			}
			else
			{
				//do what???
			}
		}
	}
}
remove_directory('../user_photos/',$user_id);

Weedpacket

Wandering a bit off to the right, there....

function remove_directory($dir,$uid)
{
    if(empty($dir) or empty($uid))
    {
        die('You must gimme a uid or dir');
    }

if($dir == '../user_photos/')
{
    die('Invalid directory');
}

if ($handle = @opendir("$dir"))
{
    while (false !== ($item = readdir($handle)))
    {
        if ($item != "." && $item != "..")
        {
            if (is_dir("$dir/$item"))
            {
                remove_directory("$dir/$item"); //you're using your function within the function
            }
            else
            {
                unlink("$dir/$item");
            }
        }
        else
        {
            //do what???
        }
    }
    closedir($handle);
    rmdir($dir);
}
else
{
    //do what???
}
}

remove_directory('../user_photos/',$user_id);

Weedpacket

Wandering a bit off to the right, there....

function remove_directory($dir,$uid)
{
    if(empty($dir) or empty($uid))
    {
        die('You must gimme a uid or dir');
    }

if($dir == '../user_photos/')
{
    die('Invalid directory');
}

if ($handle = @opendir("$dir"))
{
    while (false !== ($item = readdir($handle)))
    {
        if ($item != "." && $item != "..")
        {
            if (is_dir("$dir/$item"))
            {
                remove_directory("$dir/$item"); //you're using your function within the function
            }
            else
            {
                unlink("$dir/$item");
            }
        }
        else
        {
            //do what???
        }
    }
    closedir($handle);
    rmdir($dir);
}
else
{
    //do what???
}
}

remove_directory('../user_photos/',$user_id);

dagon

Weedpacket, everything you have posted lately has come through twice, its good stuff, but not that good :-)

Weedpacket

Still happening. Still unpredictable. And of course the page scrolls to the latest post. vBulletin is no help.