[RESOLVED] email form from page

Greg_BigPhpAmat

Hello.
Dont know why my email form doesnt work on one server. Its working (was working) on 2 others. This one is set on windows. I get comment thats message has been sent and .... nothing is coming.
Please help.

djjjozsi

let us show a source code about this problem.

lets enable all error reporting.

hello,jjozsi.

sneakyimp

"Email not working" could be due to almost anything. You might want to read our collected solutions thread on the matter.

Greg_BigPhpAmat


<HTML>
<HEAD>


<STYLE TYPE="text/css">
<!--
A:link  { color: black; text-decoration: none}
A:visited { color: black; text-decoration: none}
A:hover { color: red; text-decoration: underline;}
BODY { font-size:10; font-family: arial, sans-serif, tahoma, verdana;  }

<STYLE TYPE="text/css">
<!--
A:link  { font-size:12; color: #1156AE; text-decoration: none}
A:visited { font-size:12; color: #1156AE; text-decoration: none}
A:hover { font-size:12; color: #053258; text-decoration: underline;}

A.l:link    { color: #666666; text-decoration: none }
A.l:visited { color: #666666; text-decoration: none}
A.l:hover { color: #333333; text-decoration: none}
-->
</STYLE>


<a name="gora"></a>
<BODY oncontextmenu="return false" ondragstart="return false" ondrag="return false">

<?
function host_ip() 
{ 
global $HOST; 

// Zczytujemy zmienne srodowiskowe 
$cache = $_SERVER['REMOTE_ADDR']; 
$proxy = $_SERVER['HTTP_X_FORWARDED_FOR']; 

// Bawimy sie w rozpoznanie 
if($proxy == '') 
   { $HOST = @gethostbyaddr($cache); } 
else 
    { 
    list ($lok, $hos) = split('[,]', $proxy); 
    $czysty = ltrim($hos); 
    $hosti = @gethostbyaddr($czysty); 
    if($hosti == $czysty || $hosti == '') // Poprawka z 18 II po sugestii zg&#322;oszonej przez stera 
     { $hosti = @gethostbyaddr($cache); }; 
    $HOST = "$hosti ($lok)"; 
    }; 
}; 
host_ip();
 $hoscik=$HOST;
 $subject="Sent from website";
 $od=$_POST['firma'];
 $od1=$_POST['firma1'];
 $town=$_POST['town'];
 $state=$_POST['state'];
 $zip=$_POST['zip'];
 $email=$_POST['email'];
 $uwagi=$_POST['tresc'];
 $ip= $REMOTE_ADDR;
 echo('<b><br><br><center>
<div align="center" style="border-collapse: collapse; font-size:14; border: 1px solid #999999; width:400; background-color:#d8e4f0;"><center><br>Thank You.<br>
<br>Message has been sent.<br><br>

  </center></div>
  <A HREF="contact.html" target="_parent"><font style="text-decoration: none" face="Wingdings 3" color="#FF7405}">&nbsp;t&nbsp;</font>go back</a>
 </center>
');

 $tresc="\nHOST: $hoscik IP: $ip
 \nSender: \nFirst name: $od , Last Name: $od1
 \nAddress: \nTown: $town , State: $state
 \nEmail: $email\n\n -----------------------
 \nComment/Question: \n$uwagi";
 mail("email@gmail.com", "$subject", $tresc, "Reply-To: $email");
 ?> </h3>

</body>
</html>

There is no any error. Gives communicat that message has been sent. Its set on godaddy. server windows.

sneakyimp

That's because the 'message has been sent' text is output to the browser before you have even attempted to send the mail. This script will output that text NO MATTER WHAT HAPPENS SENDING THE MAIL. You need to try and send the mail first. You should also check to see if any error occurs while sending mail:

mail("email@gmail.com", "$subject", $tresc, "Reply-To: $email")
  or die("there was a problem sending mail");

You should also read that link I posted.

Greg_BigPhpAmat

There was a problem... what to do? How to read errors?

djjjozsi

$REMOTE_ADDR is undefined ?

use long php block in your php

set the email_from in your php code:

ini_set('sendmail_from', "xxxx@xxxxxxxxxx");

you did not used in your mail body $zip

what to do? How to read errors?

share with us, or use google about that error message.

You can have the error reporting with this:

 error_reporting(E_ALL);
 ini_set("display_errors", 1);

Greg_BigPhpAmat


$tresc="\nHOST: $hoscik IP: $ip 
\nSender: \nFirst name: $od , Last Name: $od1 
\nAddress: \nTown: $town , State: $state 
\nEmail: $email\n\n ----------------------- 
\nComment/Question: \n$uwagi"; 
mail("email@gmail.com", "$subject", $tresc, "Reply-To: $email"); 
error_reporting(E_ALL);
 ini_set("display_errors", 1);

?> </h3>

Is it correct? Beacuse doesnt display any error. Maybe will be easer to download another emailform -> why this form was working on another server few days ago. I am afraid that new form wont work either. Its makes more difficult that I am green in PHP🙂

djjjozsi

short open tag is <?

long open tag is <?php

Use the error reporting code on the top of your page, that will telling you what is the problem.

<?php
// code here
?>

Inside the host_ip function remove the @ character from the beginning of the gethostbyaddr functions ,while you troubleshoot.

Greg_BigPhpAmat

I put this on top of the page

<?php
error_reporting(E_ALL);
ini_set("display_errors", 1);
?>

I removed @ and here is what I have now.

if($proxy == '') 
   { $HOST = gethostbyaddr($cache); }  //@gethostbyaddr($cache);
else 
    { 
    list ($lok, $hos) = split('[,]', $proxy); 
    $czysty = ltrim($hos); 
    $hosti = gethostbyaddr($czysty);   //gethostbyaddr($czysty);
    if($hosti == $czysty || $hosti == '') // Poprawka z 18 II po sugestii zg&#322;oszonej przez stera 
     { $hosti = gethostbyaddr($cache); };  //@gethostbyaddr($cache);
    $HOST = "$hosti ($lok)";

...and no any errors

Greg_BigPhpAmat

...except this message 'there was a problem
from

mail("email@gmail.com", "$subject", $tresc, "Reply-To: $email")
or die("there was a problem sending mail");

sneakyimp

You should read the documentation on [man]mail[/man]. If it returns false then there's no way to find an error message as far as I know. There's no mail equivalent of error getting functions like [man]mysql_error[/man]. You'll need to check the server's mail log. There's also the possibility that your machine is not configured to send mail this way. Ask your sysadmin.

Greg_BigPhpAmat

ok. I tested it on other server. Eamil went through but I got these errors.

Notice: Undefined index: HTTP_X_FORWARDED_FOR line 40

Notice: Undefined index: zip line 62

Notice: Undefined index: tresc in line 64

Notice: Undefined index: HTTP_X_FORWARDED_FOR line 40

Notice: Undefined variable: REMOTE_ADDR in line 65

i removed all path from errors.

djjjozsi

if the message sent succesfully, do not stay the same page, becouse the user can refresh that page!
search on this forum, you will get good advice about it.

your mailer should look like this: (i've tested)

<?php
error_reporting( E_ALL );
ini_set( "display_errors", 0 );

?>
<HTML>
<HEAD>
<STYLE TYPE="text/css">
<!--
A:link  { color: black; text-decoration: none}
A:visited { color: black; text-decoration: none}
A:hover { color: red; text-decoration: underline;}
BODY { font-size:10; font-family: arial, sans-serif, tahoma, verdana;  }

<STYLE TYPE="text/css">
<!--
A:link  { font-size:12; color: #1156AE; text-decoration: none}
A:visited { font-size:12; color: #1156AE; text-decoration: none}
A:hover { font-size:12; color: #053258; text-decoration: underline;}

A.l:link    { color: #666666; text-decoration: none }
A.l:visited { color: #666666; text-decoration: none}
A.l:hover { color: #333333; text-decoration: none}
-->
</STYLE>


<a name="gora"></a>
<BODY oncontextmenu="return false" ondragstart="return false" ondrag="return false">

<?php
/*

Created functions:   message , host_ip , isempty

Used Functions , read more about the manual! :
empty:  http://hu.php.net/manual/en/function.empty.php 
ereg:  http://hu.php.net/manual/en/function.ereg.php 
error_reporting:  http://hu.php.net/manual/en/function.error-reporting.php 
gethostbyaddr:  http://hu.php.net/manual/en/function.gethostbyaddr.php 
htmlspecialchars:  http://hu.php.net/manual/en/function.htmlspecialchars.php 
ini_set:  http://hu.php.net/manual/en/function.ini-set.php 
isset:  http://hu.php.net/manual/en/function.isset.php 
ltrim:  http://hu.php.net/manual/en/function.ltrim.php 
mail:  http://hu.php.net/manual/en/function.mail.php 
split:  http://hu.php.net/manual/en/function.split.php 


*/

function message( $message )
{
		print '<b><br><br><center>
<div align="center" style="border-collapse: collapse; font-size:14; border: 1px solid #999999; width:400; background-color:#d8e4f0;"><center>
' . $message . ' </center></div>
  <A HREF="contact.html" target="_parent"><font style="text-decoration: none" face="Wingdings 3" color="#FF7405}">&nbsp;t&nbsp;</font>go back</a>
</center>
';
} 

function host_ip()
{ 
		// Zczytujemy zmienne srodowiskowe
		$cache = $_SERVER['REMOTE_ADDR']; 
		// Bawimy sie w rozpoznanie
		if ( empty( $_SERVER['HTTP_X_FORWARDED_FOR'] ) )
		{
				return @gethostbyaddr( $cache );
		} 
		else
		{
				list ( $lok, $hos ) = split( '[,]', $_SERVER['HTTP_X_FORWARDED_FOR'] );
				$czysty = ltrim( $hos );
				$hosti = @gethostbyaddr( $czysty );
				if ( $hosti == $czysty || $hosti == '' ) // Poprawka z 18 II po sugestii zg&#322;oszonej przez stera
						{
								$hosti = @gethostbyaddr( $cache );
				} 
				return ( "$hosti ($lok)" );
		} 
} 

function isempty( $postvar , $title , $required = 0 )
{
		global $error_message;
		if ( $required == 1 )
		{
				if ( empty( $_POST["$postvar"] ) )
				{
						$error_message .= "$title is required<br />";
				} 
		} 
		if ( isset( $_POST["$postvar"] ) )
				$_POST["$postvar"] = htmlspecialchars( $_POST["$postvar"] );
} 
$error_message = "";

if ( !empty( $_POST["email"] ) )
		if ( !ereg( "^[^0-9][A-z0-9_-]+[@][A-z0-9_-]+([.][A-z0-9_-]+)*[.][A-z]{2,4}$", $_POST["email"] ) )
		{
				$error_message .= "You have to add a valid email address<br />";
		} 

	/* set 1 to the 3th parameter if it is required field!
   set 0 if that field is not required field!
*/
		isempty( "firma", "firma", 1 );
		isempty( "firma1", "firma1", 1 );
		isempty( "town", "town", 1 );
		isempty( "state", "state", 1 );
		isempty( "zip", "zip", 1 );
		isempty( "email", "email", 1 );
		isempty( "tresc", "tresc", 1 );

	if ( empty( $error_message ) )
	{
			$hoscik = host_ip();
			$subject = "Sent from website";
			$od = $_POST['firma'];
			$od1 = $_POST['firma1'];
			$town = $_POST['town'];
			$state = $_POST['state'];
			$zip = $_POST['zip'];
			$email = $_POST['email'];
			$uwagi = $_POST['tresc'];
			$ip = $_SERVER['REMOTE_ADDR'];

			$to = "XXXXXXXXXXXXXXXXXXXXXX@gmail.com"; //specify recipient

			$tresc = "HOST: $hoscik IP: $ip\n
Sender: \nFirst name: $od , Last Name: $od1\n
Address: \nTown: $town , State: $state\nEmail: $email\n\n
-----------------------\n
Comment/Question: \n$uwagi";

			ini_set( 'sendmail_from', $email );
			$header = "From: " . $od . " <" . $email . ">\n"; //optional headerfields
			$maler = mail( $to, $subject, $tresc, $header );
			if ( $maler == true )
					message( "<br>Thank You.<br><br>Message has been sent.<br><br>" );
			else
					message ( "Error while sending the mail" );
	} 
	else
			message( $error_message );

	?> </h3>

</body>
</html>

Greg_BigPhpAmat

Thank You for your help. I dont know why but it didnt work on server. The only message -> there was a problem.....but......
I downloaded few other scripts and none of them have worked on that server (were working on my other one) so maybe its something with server settings. Its set on Windows. But dont know what should i looking for ina the dmin panel...
...any idea?

sneakyimp

Your windows machine may not have mail set up properly. Read that other thread. Ask your sysadmin. Read the mail log on your server.

Greg_BigPhpAmat

thx all. I switched server to linux and works OK now. Thx for script djjjozsi - yours is much better.