[RESOLVED] Sending mail

[edwinw]

I am new to PHP and i am trying to write a simple send mail piece of code using a popup as shown in the code below.

However the code is mailing me an old copy of the previous message everytime i load the page. AND i am getting an error with the code used to load the '$to' variable. please help.

<div align="right">

<?php
//session_destroy();
//unset($_POST['submit']);
$postdate = "";
$headers = "";
$message = $_POST["msg"];
$name = $_POST["fromid"];
$email = $_POST["emailid"];
$sub = "";
$to = "";
?>

 <form action="?do=msgdiv" method="post">
     <input type="button" name="button" value="Send a Message" class="submit_2" 
         onclick="document.getElementById('msgdiv').style.display = 'block'; document.getElementById('fromid').focus(); "/>
 </form>

<?php
    if(isset($_POST['submit']))
    {
        $postdate = date('Y-m-d H:i:s');
        $headers  = 'MIME-Version: 1.0' . "\r\n";
        $headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
        $headers .= 'From: '.trim($_POST['fromid']);
        $headers .= '<'.trim($_POST['emailid']).'>'."\r\n";
        $message = trim($_POST['msg']);
        $sub = 'Profile of the week response';
        $to = 'John Doe'.'<'.'[e-mail]'.'>'."\r\n";
        mail($to,$sub,$message,$headers);
    }
//--------------------------------------sent mail -----------------------------

?>
</div>

<div align="left" id="msgdiv" style="display:none;padding:10px; position:absolute;position:absolute; 
        top:1700px; left:150px; width:490px; height:400px; background-color:#FFCC00">
  <?php $_POST['submit'] = 1; ?>
  <form  action="?do=index" method="post" enctype="multipart/form-data">
    <ul>
      <li>
        <label><strong>   From :<strong/></label>
        <input type="text" name="fromid" id="fromid" value=" " style="width:260px;" maxlength="49"/> Enter your name.
      </li><br />
      <li>
        <label><strong>  Email :<strong/></label>
        <input type="text" name="emailid" id="emailid" value=" " style="width:260px;" maxlength="49"/> Enter your email.
      </li><br />
      <li>
        <label><strong>Type your message below:<strong/></label>
        <textarea name="msg" id="msg"  cols="30" rows="10" style="width:320px;"></textarea><br />
      </li><br />
      <li>
        <label>&nbsp;</label>
        <INPUT type="submit" name="submit" value="Submit"  style="height:25px" >
        <INPUT type="reset"  name="reset"  value="Reset" style="height:25px" >
        <input type="button" style="height:25px"  value="Cancel" onclick="document.getElementById('msgdiv').style.display = 'none';" />
      </li>
    </ul>
  </form>
</div>

[Krik]

Try

$to = 'John Doe <[e-mail]>';

However the code is mailing me an old copy of the previous message everytime i load the page

Do you mean it is sending you a message when you reload the page even when you don't click the submit button?

And what is this for

<?php $_POST['submit'] = 1; ?>

You cannot set $_POST variables in PHP.

[edwinw]

Yes ... on reloading the page it sends me an email.

<?php $_POST['submit'] = 1; ?> 

I was playing around with a number of things, but i thought i had removed it.

I am trying to figure out the order in which the code is being executed, because the mail() is always being executed ... even without pressing the "Send message" button.

[Krik]

The only reason mail would be executed is if $_POST['submit'] is set

Of course this comment makes me wonder

//-----------------------------------sent mail ---------------------------

Is there a chance there is some other mail() sending code there. Of course if there is where is it getting the data it is sending.

[edwinw]

You have all the code there ... i tried moving around things to see if the way the code flows would effect the out come. but it doesn't.

[djjjozsi]

You cannot set $_POST variables in PHP.

You can set the $_POST where/when ever you want.

[scrupul0us]

just a thought...

Krik;10905847 wrote:

Try

$to = 'John Doe <[e-mail]>';

be careful with that implementation as not all "platforms" support it (the usage of the < >) I can't remember where I read it so I can't cite the source but I've had issues in the past (probably IIS, go figure)

if you run into an issue try sending to just an regular email address

[edwinw]

The code successfully sends email, my problem is that it immediately sends an email when the page is loaded without clicking the "send a message" button.

This to me indicates that there is an error in the flow of code, but i can't figure it out, that is what i need help with.

[scrupul0us]

put this:

echo '<pre>';
print_r($_POST);
echo '</pre>';

at the top of your page and post back what it outputs

[edwinw]

Following is the output of the echo statement:

Array
(
)

[scrupul0us]

and it still submitted the email?

[edwinw]

When i inserted the code you gave me and reloaded the page, it did not send an email.

I then clicked "Send a Message" and it sent the message.

When i reloaded the page, it sent the same message again without me clicking "Send a Message".

[edwinw]

Below is the modified code:

<div align="right">

<?	
//$_POST = "";

echo '<pre>';
print_r($_POST);
echo '</pre>'; 

$postdate = "";
$headers = "";
$message = "";
$name = "";
$email = "";
$sub = "";
$to = "";

?>

  <form action="?do=msgdiv" method="post">
    <input type="button" name="button" value="Send a Message" class="submit_2" 
         onclick="document.getElementById('msgdiv').style.display = 'block'; document.getElementById('fromid').focus(); "/>
  </form>

<?
   if(isset($_POST['submit']))
	{
		$postdate = date('Y-m-d H:i:s');
		$headers  = 'MIME-Version: 1.0' . "\r\n";
		$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
        $headers .= 'From: '.trim($_POST['fromid']);
        $headers .= '<'.trim($_POST['emailid']).'>'."\r\n";
        $message = trim($_POST['msg']);
		$name = $_POST["fromid"];
		$email = $_POST["emailid"];
		$sub = 'Profile of the week response';
		$to = '[e-mail]'; //.'<'.'[e-mail]'.'>'."\r\n";
		mail($to,$sub,$message,$headers);
		unset($_POST['submit']);
    }
?>

</div>

<div align="left" id="msgdiv" style="display:none;padding:10px; position:absolute;position:absolute; 
		top:1700px; left:150px; width:490px; height:400px; background-color:#FFCC00">

  <form  action="?do=index" method="post" >  <!--enctype="multipart/form-data" -->
    <ul>
      <li>
        <label><strong>   From :<strong/></label>
        <input type="text" name="fromid" id="fromid" value=" " style="width:260px;" maxlength="49"/> Enter your name.
      </li><br />
      <li>
        <label><strong>  Email :<strong/></label>
        <input type="text" name="emailid" id="emailid" value=" " style="width:260px;" maxlength="49"/> Enter your email.
      </li><br />
      <li>
        <label><strong>Type your message below:<strong/></label>
        <textarea name="msg" id="msg"  cols="30" rows="10" style="width:320px;"></textarea><br />
      </li><br />
      <li>
        <label>&nbsp;</label>
        <INPUT type="submit" name="submit" value="Submit"  style="height:25px" >
        <INPUT type="reset"  name="reset"  value="Reset" style="height:25px" >
        <input type="button" style="height:25px"  value="Cancel" onclick="document.getElementById('msgdiv').style.display = 'none';" />
      </li>
    </ul>
  </form>
<?
echo '<pre>';
print_r($_POST);
echo '</pre>'; 
?>
</div>	  

On loading the page, an email is sent without clicking "Send a Message" and the following is displayed:

Array
(
[fromid] => this is a test
[emailid] => this is a test
[msg] => this is a test
[submit] => Submit
)

Send a Message (button)

Everytime page is refreshed, an email is sent, again without clicking "Send a Message"

Is there a way to unset the $POST variable so that it does not pass the isset "if test" everytime the page is reloaded/refreshed - or should i be using a different "if test" other than isset($POST)?

[djjjozsi]

start the session with with:
session_start() on the top of your php page.

<?php

if ( !empty( $_POST['submit'] ) )
{
		$postdate = date( 'Y-m-d H:i:s' );
		$headers = 'MIME-Version: 1.0' . "\r\n";
		$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
		$headers .= 'From: ' . trim( $_POST['fromid'] );
		$headers .= '<' . trim( $_POST['emailid'] ) . '>' . "\r\n";
		$message = trim( $_POST['msg'] );
		$name = $_POST["fromid"];
		$email = $_POST["emailid"];
		$sub = 'Profile of the week response';
		$to = '[e-mail]'; //.'<'.'[e-mail]'.'>'."\r\n";
		$ok = false;
		if ( isset( $_SESSION[$postdate] ) )
				print "You've sent this mail!";
		else
				$ok = mail( $to, $sub, $message, $headers );

	if ( $ok == true )
	{
			$_SESSION[$postdate] == 1;
			print "The mail has sent succesfully";
	} 
	else
			print "Problem with the email";
} 

?> 

[edwinw]

It did not send a message on loading, but it also did not send a message after clicking "Send a Message"

[edwinw]

The above statement is not correct.

On the initial loading of the page it did not send an email ... good

After clicking on "Send a Message" and email was sucessfully sent and the msg - "The mail has sent succesfully " was displayed on the screen.... good

However, on refreshing/reloading the page, another email was send ... bad

Please note in both cases the message and headers were empty.

[djjjozsi]

The above statement is not correct.

yep, you're right.

take the correct time into the form, call it date_time

if you send the mail, create a session variable with it:

before you send the mail, check if this has a variable.

if the user refreshed the page, the previous date-time will be posted.
schematic draft:

if(isset($_SESSION[$_POST["date_time"]]))
{
die("do not refresh the page!");
}
else
{
mail(.................);
$_SESSION[$_POST["date_time"]]=1;
}
 

[scrupul0us]

after the mail is sent, unset the $_POST array...or break this out into multiple pages

[edwinw]

The email message and header is being sent correctly, however, its still sending a copy of the last email when [F5] or the refresh logo is pressed. This does not happen when the page is reloaded by retyping the url. All of this even though the unset command was typed after the mail command.

if ( !empty( $_POST['submit'] ) )
{
	$postdate = date( 'Y-m-d H:i:s' );
        $headers = 'MIME-Version: 1.0' . "\r\n";
        $headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
        $headers .= 'From: ' . trim( $_POST['fromid'] );
        $headers .= '<' . trim( $_POST['emailid'] ) . '>' . "\r\n";
        $message = trim( $_POST['msg'] );
        $sub = 'Profile of the week response';
        $to = '[e-mail]'; //.'<'.'[e-mail]'.'>'."\r\n";
        $ok = false;
        if ( isset( $_SESSION[$postdate] ) )
                print "You've sent this mail!";
        else
                $ok = mail( $to, $sub, $message, $headers );
				unset($_POST) ;
        if ( $ok == true )
        {
                $_SESSION[$postdate] == 1;
                print "The mail has sent succesfully";
        }
        else
                print "Problem with the email";
}
?>

[edwinw]

Note the message ""You've sent this mail!" has never been displayed.