New member joining Confirm page sends errors

coinmagnate_com

My login page works but when I try to join as a new member I get an error that says line 12 on the confirm page has an error.
I can't see what is different about line 12 than any other line.
Any help would be appreciated.
Here is the link to my join form:
http://199.101.8.178/jgeiger/join.asp

Here is the code for my confirm page:

<?
ob_start(); //turn on output buffering
session_start(); //start session variables
ini_set('display_errors', 1); //display all errors

$Username = $POST("UserName"); //request user entered and validated user name
$Password = $POST("Password"); //request user entered and validated password
$EMail = $POST("EMail"); //request user entered and validated email address
Auth = 1: //security variable set to default of 1
$News = $POST("news"); //initialize your variables, assigning them with the $_POST

require ('includes/dbconnection.php');//include the database connection

$authorized = false; //set testing variable

While not (!$rs->EOF) {; //while not at the end of the file continue
if ($rs->Fields["UserName"]->Value=="$username" && $rs->Fields["Password"]->Value=="$password") {;
$SESSION['auth'] = $rs->Fields['Auth']->Value;
$SESSION['username'] = $rs->Fields['UserName']->Value;
$authorized = true;
}

$rs->MoveNext();
}

if (!$authorized) {;
header('Location: logininvalid.php');
$ob_end_flush();
exit();} else {;
header('Location: index.php');
$ob_end_flush();
exit();
}
//check for duplicate names, redirect to user taken page, otherwise keep going, check authorize.php code for the code to do this

strSQL = "INSERT INTO Login (UserName, Password, EMail, Auth, News)"&_
"VALUES ( '" & UserName & "' , '" & Password & "' , '" & EMail & "', '" & Auth & "', '" & News & "')"
set objRS = conn.Execute(strSQL); //your sql statement goes here to insert the values

//execute SQL statement

$session("username") = session("tUserName"); //assign username variable
$session("auth") = 1; //assign auth value for security
require ('index.php');//redirect user to index.php page
//close the connection
$rs->Close();
$conn->Close();

$rs = null;
$conn = null;
$ob_end_flush();
?>

djjjozsi

php has syntax rules:

$_POST["variable_index"] you have to use [ ] sings to use an array

use the point to concate strings, however you can embed the variables into a string:

$var1=1;
$var2=2;
$my_array["value"]="Something";
$my_array[2]="Something2";
/* how to concate new string*/
$resilT="result";
$new_string="This is my variables:";
$new_string  .=" Where var1 is ".$var1." , and variable2 is: {$var2} , and these are my arrays:" ;
$new_string.=" the first index is : {$my_array["value"]} and the second index is:" . $my_array[2]."<br />\n" ;
$new_string.=" Now i add two \" signs:  \"\"   and one apostrofe: ':   '   ";
print "The {$resilT} is<br />{$new_string}";

The result is:
This is my variables: Where var1 is 1 , and variable2 is: 2 , and these are my arrays: the first index is : Something and the second index is:Something2
Now i add two " signs: "" and one apostrofe: ': '

$session("username") you mean: $SESSION["username"]
which is not the same with:
$SESSION["username"]
$SESSiON["username"]
$SESION["username"]
$sESSION["username"]

coinmagnate_com

Sorry about the block of code.
I'll be more careful about posting code.

Thanks for explaining syntax.

djjjozsi

coinmagnate@com;10906165 wrote:
Thanks for explaining syntax.

your welcome.
One more thing:

if you use an if condition, never close it with a semicolumn.

While not (!$rs->EOF) {; //while not at the end of the file continue
if ($rs->Fields["Password"]=="$password")
{; <<--- this condition never processed becouse you closed it.

If you still have problems with this code, feel free to share with us.

Hello, jjozsi.

coinmagnate_com

I've got the error down to this part:

$insert = "INSERT INTO Login (UserName, Password, EMail, Auth, News)"& _;
"VALUES ('".$_POST['UserName']."', '".$_POST['Password']."', '".$_POST['EMail']."', '".$_POST['Auth']."', '".$_POST['News']."');
$add_member = mysql_query($insert); //your sql statement goes here to insert the values

As you can see, I tried to fix this part but it's the wrong color and it doesn't work.
I don't knowe how to fix it.

Thanks,
Janet

djjjozsi

How to embed your string, read the previous example.

Its a better way:

<?php

$UserName = mysql_real_escape_string( $_POST['UserName'] );
$Password = mysql_real_escape_string( $_POST['Password'] );
$EMail = mysql_real_escape_string( $_POST['EMail'] );
$Auth = mysql_real_escape_string( $_POST['Auth'] );
$News = mysql_real_escape_string( $_POST['News'] );
$query = "INSERT INTO Login (UserName, Password, EMail, Auth, News)
VALUES ('$UserName','$Password','$EMail','$Auth','$News')";
print "The query is for test in phpmyadmin: $query <br />";
?>

Before you write a new user into the table, check that if its already in the table.

coinmagnate_com

It makes sense to see if the username is already taken before you write it as a new user but I thought my previous if statement checked for doubles.
What does the "print query"? I mean I assume it will display the query but why would I want to do that in this intance?
When I added your suggested code the error jumped back up to 19 which is the "While not at the end of the file continue" statement.
I see this is wrapped around an If statement but I'm assuming there are syntax issues with this bit.
.
I'm having such a difficult time with this class, I really appreciate your help.
Here's what my code looks like now with the line 19 error:

<!--#INCLUDE FILE="includes/dbconnection.php"-->

<?
ob_start(); //turn on output buffering 
session_start(); //start session variables
ini_set('display_errors', 1); //display all errors

$Username = $_POST("UserName"); //request user entered and validated user name 
$Password = $_POST("Password"); //request user entered and validated password 
$EMail = $_POST("EMail"); //request user entered and validated email address 
$auth = 1; //security variable set to default of 1 
$News = $_POST("news"); //initialize your variables, assigning them with the $_POST

require ('includes/dbconnection.php');//include the database connection

$authorized = false; //set testing variable

 While not (!$rs->EOF)
 { //while not at the end of the file continue
 if ($rs->Fields["UserName"]->Value=="$username" && $rs->Fields["Password"]->Value=="$password") {
 $_SESSION['auth'] = $rs->Fields['Auth']->Value;
 $_SESSION['username'] = $rs->Fields['UserName']->Value;
 $authorized = true;
 }  

 $rs->MoveNext() ;


if (!$authorized) {;
   header('Location: logininvalid.php');
   $ob_end_flush();
   exit();} else {;
   header('Location: index.php');
   $ob_end_flush();
   exit();
   }
//check for duplicate names, redirect to user taken page, otherwise keep going, check authorize.php code for the code to do this

$UserName = mysql_real_escape_string( $_POST['UserName'] ); 
$Password = mysql_real_escape_string( $_POST['Password'] ); 
$EMail = mysql_real_escape_string( $_POST['EMail'] ); 
$Auth = mysql_real_escape_string( $_POST['Auth'] ); 
$News = mysql_real_escape_string( $_POST['News'] ); 
$query = "INSERT INTO Login (UserName, Password, EMail, Auth, News) 
VALUES ('$UserName','$Password','$EMail','$Auth','$News')";  //your sql statement goes here to insert the values
print "The query is for test in phpmyadmin: $query <br />"; 


$_SESSION("username") = session("tUserName"); //assign username variable
$_SESSION("auth") = 1; //assign auth value for security
require 'index.php'; //redirect user to index.php page

//close the connection
$rs->Close();
$conn->Close();

$rs = null;
$conn = null;
$ob_end_flush();
?>

djjjozsi

Its printing the query to know that the user input has arrived.
While you're troubleshooting:
- lets use breakpoints in your code,
- do not redirect the output with header or ob_start
- and always use the error reporting

In your code not just typo mistakes are, but mistakes without syntax error. (you're using too much ; signs.)

if($a==1);
{:
echo "a is $a";
};
else ;
{ ;
print "a is not 1";
};

Brackets in the arrays,
And you have to keep the syntax of a function before you use it.

Lets read the syntax and the examples about these commands, and compare with your code:
if
exit
flush
header
ini_set
mysql_real_escape_string
ob_end_flush
ob_start
session_start
while

And i can't decide that this is a register or a login check program, and thats a problem.

Hello, jjozsi.

coinmagnate_com

This code is the confirm page that users are redirected to from my new member join form which is here:
http://199.101.8.178/jgeiger/php/join.php

This code is supposed to check the database to make sure the username isn't already in use, and write the new user info to the database, then redirect the user to the member only area that you have to be logged in to view.

We did this site in ASP with VB and now have to do the same site with PHP. This is why my syntax is off because I'm trying to morph the VB into PHP. I'm learning it but it seems to be real slow.
I've only got one more week to complete the site. Fortunately I've got everything else to work but this confirm page.

I'll re-read about the functions you mentioned.

Janet

djjjozsi

coinmagnate@com;10906212 wrote:
I'll re-read about the functions you mentioned.

and the example are really helpful on that manual page.

I recommend you another useful page to learn, with examples and explanations:
http://www.tizag.com/phpT/

it has mysql-php section.

hello, jjozsi

coinmagnate_com

Thanks, I'll check it out.

Janet