Adding underscores to mp3 filename in download script

[AshleyQuick]

Hi,

Is there a way to have this script add underscores to mp3 filenames? E.G. If I rename I will follow.mp3 to "Iwillfollow.mp3" it works fine. Otherwise, I just get a file called "I" ...it ignores everything after the first space (doesn't even add the .mp3).

<?php

if (!@include_once("./inc/auth.php"))
include_once("../inc/auth.php");

include("../config.php");
include("../inc/functions.php");
include("../lang/$language.php");

session_save_path($session_save_dir);

if (isset($_GET['path'])) $path = validate_path($_GET['path']);
if (!isset($path)) $path = FALSE;
if ($path == "./" || $path == ".\\" || $path == "/" || $path == "\\") $path = FALSE;

if (isset($_GET['filename'])) $filename = basename(stripslashes($_GET['filename']));

if ($AllowDownload || $AllowView)
{
  if (empty($home_directory))
  {
    if (!empty($_SESSION['home_directory'])) $home_directory = $_SESSION['home_directory'];
  }
  if (isset($_GET['filename']) && isset($_GET['action']) && is_file($home_directory.$path.$filename) || is_file("../".$home_directory.$path.$filename))
  {
    if (is_file($home_directory.$path.$filename) && !strstr($home_directory, "./") && !strstr($home_directory, ".\\"))
    $fullpath = $home_directory.$path.$filename;
    else if (is_file("../".$home_directory.$path.$filename))
    $fullpath = "../".$home_directory.$path.$filename;

if (!$AllowDownload && $AllowView && !is_viewable_file($filename))
{
  print "<font color='#CC0000'>$StrAccessDenied</font>";
  exit();
}

if ($HTTPS)
header("Pragma:");

header("Content-Type: ".get_mimetype($filename));
header("Content-Length: ".filesize($fullpath));
if ($_GET['action'] == "download");
header("Content-Disposition: attachment; filename=$filename");

readfile($fullpath);
  }
  else
  print "<font color='#CC0000'>$StrDownloadFail</font>";
}

?>

[coldwerturkey]

str_replace(' ', '_', $string);

[AshleyQuick]

coldwerturkey;10906427 wrote:

str_replace(' ', '_', $string);

Like this? (Not able to try it at the moment)

if (is_file($home_directory.$path.$filename) && !strstr($home_directory, "./") && !strstr($home_directory, ".\\"))
    $fullpath = str_replace(' ', '_', $home_directory.$path.$filename);
    else if (is_file("../".$home_directory.$path.$filename))
    $fullpath = "../"str_replace(' ', '_', .$home_directory.$path.$filename);

[laserlight]

You could use [man]preg_replace/man to replace consecutive whitespace with a single underscore, or something along those lines.

[AshleyQuick]

Actually, seems this should take place during the upload.

Here's the upload code. Where should the str_replace be located?

if (@move_uploaded_file($_FILES['userfile']['tmp_name'][$i], realpath($home_directory.$path)."/".$_FILES['userfile']['name'][$i]))

and

print "<input type='hidden' name=path value=\"".htmlentities($path)."\">";