[RESOLVED] An Adding question

gotornot

Hi im having trouble adding values to variables it seems to be timesing the result by 2 and i dont kjnow how to stop it
the code is below:
$entq = "SELECT * FROM userstats WHERE userid='$userid'";
$entr = mysql_query($entq);
$entrow = mysql_fetch_array($entr);
$oldaccept = $entrow["accept"];
$oldreject = $entrow["reject"];
$oldentries = $entrow["entries"];
$oldaccept += $accept;
$oldreject += $reject;
$oldentries += $numbers;
$udq = "UPDATE userstats SET accept='$oldaccept', reject='$oldreject', entries='$oldentries' WHERE userid='$userid'";
$udr = mysql_query($udq);
The $accept figures can be any number they are whole numbers no decimals at all but it seems to be timesing the accept reject and entries by 2 then adding them to the all ready laid out figures any help please.

big_nerd

gotornot,

I don't see enough code to be 100% sure.. but.. if you read here you will see that:

$oldaccept += $accept means $oldaccept = $oldaccept + $accept;

You can try reversing $oldaccept & $accept, as well as $oldreject & $reject to read:

$entq = "SELECT * FROM userstats WHERE userid='$userid'";
$entr = mysql_query($entq);
$entrow = mysql_fetch_array($entr);
$oldaccept = $entrow["accept"];
$oldreject = $entrow["reject"];
$oldentries = $entrow["entries"];
$accept += $oldaccept;
$reject += $oldreject;
$oldentries += $numbers;
$udq = "UPDATE userstats SET accept='$oldaccept', reject='$oldreject', entries='$oldentries' WHERE userid='$userid'";
$udr = mysql_query($udq);

Another idea to try is where you are doing math, to print/echo the variables:

i.e.

$oldaccept += $accept;
$oldreject += $reject;
$oldentries += $numbers;

$udq = "UPDATE userstats SET accept='$oldaccept', reject='$oldreject', entries='$oldentries' WHERE userid='$userid'";
echo $udq;
// Commenting Out Query for Testing
//$udr = mysql_query($udq);

Or something to that effect - this way you can monitor what is happening, I would recommend not executing the query (as I pointed out) to rule out all variables, and work your way from there.

Good Luck!

shawty

Be carefull also with your variable type...

If PHP thinks the variable coming back from your database is a string, then the result of all you + operations will in-fact turn into true or false results.

To illustrate what i mean try the following :

$string1 = "1";
$string2 = "2";
$string3 = $string1 + $string2;

This will actually set $string3 to the numerical value 1 which is equivalent to 'true'

When adding strings you MUST use the . (full stop) operator

$string3 = $string1 . $string2

$string3 will then be "12"

If your taking data from your DB and PHP has reason to make it a string (Remember PHP auto-types it's variables) then you MUST prefix your variable with the desired type. So using the above

$string3 = (int)$string1 + (int)$string2;

will actually then have the desired effect and set the answer to 1 + 2 and save it in $string3 which will then be marked as an integer variable.

$string3 = (int)($string1 . $string2);

Will set $string3 to the integer 12

Hope that helps

Cheers

Shawty

harmor

An offtopic suggestion is to place the query inside of the mysql_query function.
This won't solve your problem but it will help you clean up redundant code.

Before

$udq = "UPDATE userstats SET accept='$oldaccept', reject='$oldreject', entries='$oldentries' WHERE userid='$userid'";
$udr = mysql_query($udq);

After

mysql_query("UPDATE userstats SET accept='$oldaccept', reject='$oldreject', entries='$oldentries' WHERE userid='$userid' ");

For UPDATING and DELETING you don't need to use a variable.

NogDog

harmor;10906947 wrote:
An offtopic suggestion is to place the query inside of the mysql_query function.
This won't solve your problem but it will help you clean up redundant code.

Before
$udq = "UPDATE userstats SET accept='$oldaccept', reject='$oldreject', entries='$oldentries' WHERE userid='$userid'";
$udr = mysql_query($udq);
After
mysql_query("UPDATE userstats SET accept='$oldaccept', reject='$oldreject', entries='$oldentries' WHERE userid='$userid' ");
For UPDATING and DELETING you don't need to use a variable.

I prefer to keep them separate, so that if there is a problem I can easily debug by logging or echoing the actual query that was used, e.g.:

$sql = "SELECT * FROM table";
$result = mysql_query($sql);
if($result == false)
{
   error_log(__FILE__.'['.__LINE__']: '.mysql_error()."\n$sql");
}

harmor

NogDog;10906948 wrote:
I prefer to keep them separate, so that if there is a problem I can easily debug by logging or echoing the actual query that was used, e.g.:
$sql = "SELECT * FROM table";
$result = mysql_query($sql);
if($result == false)
{
   error_log(__FILE__.'['.__LINE__']: '.mysql_error()."\n$sql");
}

Is that better then just appending "or die(mysql_error())" to the query?

NogDog

An "or die();" is a lazy way to get some immediate debug info (which is why we all do it when we're in a hurry), but a horrible solution in terms of usability, since the script does, in fact, die at that point, outputting stuff that no normal user is interested in (while malicious users might be very interested in it) if the various error-reporting settings allow its display.

In "real life" I'd probably have an error-handling function (or class/method) that would handle all the details, including redirection to or including of a standard error page if the problem is fatal. Then upon testing for a failure I would just call that function/method with the data I'd like logged, and perhaps the "reassuring" message I would like to be displayed to the user.

harmor

NogDog;10906955 wrote:
An "or die();" is a lazy way to get some immediate debug info (which is why we all do it when we're in a hurry), but a horrible solution in terms of usability, since the script does, in fact, die at that point, outputting stuff that no normal user is interested in (while malicious users might be very interested in it) if the various error-reporting settings allow its display.

In "real life" I'd probably have an error-handling function (or class/method) that would handle all the details, including redirection to or including of a standard error page if the problem is fatal. Then upon testing for a failure I would just call that function/method with the data I'd like logged, and perhaps the "reassuring" message I would like to be displayed to the user.

I suppose a custom message telling the users that the site is under maintenance is more non-amateurish than the error "mysql_error()" throws.

shawty

Definitely. Logging errors to a file is the production way to do it. You really don't want non-desirables reading the output of die on a mysql_error call especially if that error is caused by a dead connect statement.

Also if you follow harmor's advice, then not only can you log it, but you could also get the system to send the sysadmin an email telling them somethings broken.

To add my tuppence worth into the mysql joining above, here's how i normally do it...

$params = array();
$params['param1'] = "param1";
$params['param2'] = "param2";
$params['param3'] = "param3";

$queryparams = " ' " ; join(" ',' ",$params) . " ' ";
$query = "INSERT INTO table values(" . $queryparams . ")";
mysql_query($query);