Confused with queries

[mikawhat]

The following function was working but now for a reason is not working... Weird thing is that the first query, returns the wrong value.However, if i put the second query in comments and have only the select query, it returns the correct value! I can't really explain this...

function change_prod_visible($id) {
	$q = "SELECT prod_visible FROM tbl_products WHERE prod_id='$id'";
	$r = mysql_query($q);
	$row = mysql_fetch_array($r);
	if ($row[0] == 1) {
		$new_status = 0;
	} else {
		$new_status = 1;
	}
	mysql_free_result();
	$query = "UPDATE tbl_products SET prod_visible='$new_status' WHERE prod_id='$id'";	
	$result = mysql_query($query);
	if ($result) {
		return _PROD_SUCCESSFULLY_EDITED;
	} else {
		return _PROD_ERROR_OCCURED . mysql_error();
	}
}

[laserlight]

Actually, I think you could just do this:

function change_prod_visible($id) {
    $query = "UPDATE tbl_products SET prod_visible = NOT prod_visible WHERE prod_id='$id'";
    $result = mysql_query($query);
    if ($result) {
        return _PROD_SUCCESSFULLY_EDITED;
    } else {
        return _PROD_ERROR_OCCURED . mysql_error();
    }
}

[mikawhat]

laserlight;10907383 wrote:

Actually, I think you could just do this:

function change_prod_visible($id) {
    $query = "UPDATE tbl_products SET prod_visible = NOT prod_visible WHERE prod_id='$id'";
    $result = mysql_query($query);
    if ($result) {
        return _PROD_SUCCESSFULLY_EDITED;
    } else {
        return _PROD_ERROR_OCCURED . mysql_error();
    }
}

what should be the field type for using this method? i"m currently using INT(1) which is either 0 or 1...

[laserlight]

That should do.

[mikawhat]

laserlight;10907391 wrote:

That should do.

nothing happens... is there a possibility that the table could be damaged or something?

[laserlight]

Try changing NOT to !

[mikawhat]

nothing.... :/

[laserlight]

Are you sure that $id is correct? I have tested, and both my suggestions should work.

[mikawhat]

yes it's correct. No doubt your solution is working, but i'm pretty sure the one i was using should be fine too. So something else might be wrong...

[mikawhat]

I've just found what's wrong... I removed include("editor/wysiwyg.php") and it's working. It doesn't make any sense to me, but for a reason this was the problem...

could you explain your query? is this a standard way for changing flags?

[laserlight]

mikawhat wrote:

could you explain your query?

Logical negation: causes a field with value 0 to have value 1, and a field with a non-zero value (e.g., 1) to have the value 0.

mikawhat wrote:

is this a standard way for changing flags?

I suppose so, since it certainly is conventional in many mainstream programming languages.