datetime problem

[Thomas_P]

Hi all,

I'm having an issue with adding users to my database. I can add the users no problem but I'd like to have datetime updated on creation. (I thought auto-increment might work but I got lots of red nasty messages 🙂 )

Here is how I'm posting it, maybe someone out there in PHP land can save me?

$insert = mysql_query("insert into $table values ('', '".$_POST['username']."', '".$_POST['password']."', '".$_POST['email']."', '".$_POST['city_name']."', '".$_POST['country_name']."', '', '','')")
or die("Could not insert data because ".mysql_error());

As it sits right now datetime comes up all 0 (picture attachment)

Any and all help is appreciated!

Thomas

[bradgrafelman]

1. It's best to list the column names in your INSERT query, that way it's clear where the data is going but you also won't need to include things like '' in your VALUES() list for AUTO_INCREMENT columns.

2. User-supplied data should never be placed directly into a SQL query. Instead, you should first sanitize it with a function such as [man]mysql_real_escape_string/man.

3. Storing passwords unencrypted/unhashed is considered very insecure (and thus a bad practice). You might consider changing that.

4. Look at using a TIMESTAMP column; you can specify a default value of 'CURRENT_TIMESTAMP' which does what it sounds like.