Javascript Popup not receiving correct variable

[ashrobbins87]

Hi guys and girls, I was wondering if anyone could help me out with a little problem I'm having.

I have built a page which retrieves user details from a database and displays a list of names in a drop down list, this works fine. I then want the user to select a name and click a "View" button to display the details of that person in a pop up window. The pop up opens fine except the data which it displays is always for the last person in the drop down list, IOW the person that the loop finishes on.

Does anybody know what I'm doing wrong? My code is below.

<script type="text/javascript">
function eventWindow(url) 
{
	event_popupWin = window.open(url, 'event', 'resizable=yes,scrollbars=yes,toolbar=no,width=450,height=500');
	event_popupWin.opener = self;
}
</script>


<?php
$mysqli = mysqli_connect("localhost","root","root","opp_group");
//Get list of users in drop down

$getUsers_sql ="SELECT id, firstname, surname FROM cms_users ORDER BY firstname";
$getUsers_res = mysqli_query($mysqli, $getUsers_sql)or die(mysqli_error()); 

echo "<form method=\"POST\" action=\"\"  >
<select name=\"users\">";

while ($row = mysqli_fetch_assoc($getUsers_res)) 
{ 

echo '<option value="' . $row['id'] . '">' . $row['firstname'] . ' ' . $row['surname'] . '</option>'; 
$id = $row['id'];
} 
echo "</select>
<a href=\"javascript:eventWindow('../user.php?i=".$id."');\">
<input type=\"submit\" name=\"viewuser\" value=\"View\" />
</a>";
?>
</form>

[dotbob]

The line

<a href=\"javascript:eventWindow('../user.php?i=".$id."');\">

will only output the id of the last record in the loop seeing as the link is being created outside of your while loop.

what you need to do is reference the selected id via javascript instead.

give your select an id...

<select id=\"users\" name=\"users\">";

then change your href by removing the id querystring val:

<a href=\"javascript:eventWindow('../user.php');\">

then within your javascript function, insert the following:

<script type="text/javascript">
function eventWindow(url)
{
var sel = document.getElementById('user');
url+= '?i='+sel.options[sel.selectedIndex].value;

event_popupWin = window.open(url, 'event', 'resizable=yes,scrollbars=yes,toolbar=no,width=450,height=500');
event_popupWin.opener = self;

}
</script>

should work i think

oh and also, replace...

<a href=\"javascript:eventWindow('../user.php');\">
<input type=\"submit\" name=\"viewuser\" value=\"View\" />
</a>";

with:

<input type=\"button\" name=\"viewuser\" value=\"View\"
onclick=\"eventWindow('../user.php');\" />

you don't need an input type of submit as you're not using a form and it's kinda strange to wrap one in an href (as far as i'm aware at least)