Undefined index:

Bobk

just wondering why iam getting this error
iam guessing its giving me the error, as it cant find it ?
Undefined index: txtusername

im not good at php, so it was just a copy & paste job from hotscripts ?

also, if any1 knows if it can be "cleaned" up a bit ? please let me know
and iam new 🙂

thanks!

<?php
$username = "user";
$password = "pass";
if($_POST['txtusername'] != $username || $_POST['txtpassword'] != $password) {
?>

<form name="form" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
<label for="txtusername">Username:</label><br />
<input type="text" title="Enter your Username" name="txtusername" value="admin" size="10" /><br />
<label for="txtpassword">Password:</label><br />
<input type="password" title="Enter your password" name="txtpassword"  size="10"/><br />
<input type="submit" name="Submit" value="Login" />
</form>

<?php
}
else {
?>

<?php
header( 'Location: http://sitename.com' ) ;
?>

<?php
}
?>

NogDog

If you access the page directly rather than via the form being submitted, then the two $_POST array variables referenced in your if() condition are not set, thus the notice (it is not a fatal error, just a notice message letting you know something may be wrong in your code).

You can get rid of it by first checking if the variables are set via the [man]isset/man function, then do the checking to see if they have the values you're looking for.

Bobk

NogDog;10909843 wrote:
If you access the page directly rather than via the form being submitted, then the two $_POST array variables referenced in your if() condition are not set, thus the notice (it is not a fatal error, just a notice message letting you know something may be wrong in your code).

You can get rid of it by first checking if the variables are set via the [man]isset/man function, then do the checking to see if they have the values you're looking for.

lol. uhm iam really greatful for your help and all,
but im struggling to "follow" along, sorry'

Bobk

Bobk;10909851 wrote:
lol. uhm iam really greatful for your help and all,
but im struggling to "follow" along, sorry'

:quiet:

i just dont want it to show, as its annoying on a mainpage, is there a way to hide it ?

coldwerturkey

i just dont want it to show, as its annoying on a mainpage, is there a way to hide it ?[/QUOTE]

turn off your errors (google for how-to).

or, be smart, take another 30 seconds, re-read nogdogs post, and put a and b together..

if ( ... && isset($_POST['txtusername'])) //...

NogDog

if(!isset($_POST['txtusername']) || !isset($_POST['txtpassword']) || 
   $_POST['txtusername'] != $username || $_POST['txtpassword'] != $password) {

bradgrafelman

coldwerturkey wrote:
turn off your errors (google for how-to).

Funny you should mention that, since log_errors (or a custom error handler that tracks errors on its own) should always be used in place of display_errors in production environments...

gene99

I have a problem w/ the same code. I use a business directory program that allow custom input fields. I'm using the same code above to password protect a business listing page. I created custom fields for the username & password so a listing can enter their own user/pass but when I test it it won't work when I'm calling/echoing the fields. When I hardcode it w/ a user/pass it works. Any ideas on how I should recode this?:

<?php
// Define your username and password
$username = "<?php echo $custom_74; ?>";
$password = "<?php echo $custom_16; ?>";
if ($POST['txtUsername'] != $username || $POST['txtPassword'] != $password) {
?>
<h1>Login</h1>
<form name="form" method="post" action="<?php echo $_SERVER['REQUEST_URI']; ?>">
<p><label for="txtUsername">Username:</label>
<br /><input type="text" title="Enter your Username" name="txtUsername" /></p>
<p><label for="txtpassword">Password:</label>
<br /><input type="password" title="Enter your password" name="txtPassword" /></p>
<p><input type="submit" name="Submit" value="Login" /></p>
</form>
<?php
}
else {
?>

Thanks, Gene