new table format for page

underthegun

Hey guys,
The code im about to post displays images in one long single line. Basically if I have 20 items, then it spans the page down 20 items. Could anyone help me get this in a better format? like maybe 4 columns across per row?

<?
			$sql = "SELECT * FROM images WHERE user='$myuid'";
			$qr1 = mysql_query($sql);
			$rowcount = mysql_num_rows($qr1);
			$pagecount = ceil($rowcount / $limit);
			print "<table width=100%><td>Page No: " . ($pageno+1) ."</td><td align=right>
						<select onChange=\"gotocluster(this)\">\n
						<option>Select A Page</option>";
			for($x=0; $x<$pagecount; $x++){
				$p = $x + 1;
				$l = $x * $limit + 1;
				$u = $l + $limit - 1;
				if($u>$rowcount) $u=$rowcount;
				print "<option value='editimg.php?pageno=".$x."'>Page $p ($l - $u)</option>\n";
			}
			print "</select></td></table>";
			$l = $pageno * $limit;
			$u = $l + $limit-1;
			$count = -1;
			$i = 1;
			$domCount = 0;
			while( $a = mysql_fetch_object($qr1) ){
				$count++;
				$row = ($count % 2)+1;
				if ($limit && $count < $l ) continue;
				if($limit && $count > $u) continue;
				$filen = $siteurl."/".str_replace('./', '', $att_path)."/".$a->filename;
				$filen = str_replace('http://','%%',$filen);
				$filen = str_replace('//','/',$filen);
				$filen = str_replace('%%','http://',$filen);
				if( file_exists($att_path."/".$a->filename)	){
					echo "<a href='$filen' target='_new'><img src='$filen' width=100 height=100 border=0></a><br>";
				}else{
					echo "no image found<br>";
				}
				echo "<a href='getcode.php?img=".$a->id."'>get code</a> | ";
				echo "<a href='editimg.php?pageno=".$pageno."&del=".$a->id."'>delete</a><br>";
			}
			print "<table width=100%><td>Page No: " . ($pageno+1) ."</td><td align=right>
						<select onChange=\"gotocluster(this)\">\n
						<option>Select A Page</option>";
			for($x=0; $x<$pagecount; $x++){
				$p = $x + 1;
				$l = $x * $limit + 1;
				$u = $l + $limit - 1;
				if($u>$rowcount) $u=$rowcount;
				print "<option value='editimg.php?pageno=".$x."'>Page $p ($l - $u)</option>\n";
			}
			print "</select></td></table>";
?>

__berfuzz

You could do something like this. If theres always going to be 20 items you could go for something as simple as this. Otherwise the html-code may become faulted.

echo "<table>";
echo "<tr>";
$i = 1;
while( $a = mysql_fetch_object($qr1) )
{

echo "\n\t\t<td>".$row['item']."</td>";
if($i % 5 == 0)
{
	echo "\n\t</tr>\n\t<tr>";
}
$i++;
}
echo "\n\t</tr>";
echo "\n\t</table>";

underthegun

I hate to ask this but I've been looking and have no idea where to place this code. Could you tell me?

__berfuzz

I guess your braincells didn't want to fight today. 😉 The while-loop in my example is the same as in your code. Your code is all but a mess to my eyes, so I wouldn't tinker with it. Put the option-tags where I wrote $row['item']

underthegun

blllahhh I see that now that you've made it obvious. I'm sorry man, thanks a ton!

__berfuzz

OT: Now, may I ask what the code is doing? My guess is that the code would like some of Ockhams razor.

underthegun

It's displaying images that have been uploaded from a form. I will admit I'm no coder so sorry if it seems like im having trouble with this LOL but the only option tags in the code are to display the pages. I don't see where to display the image itself besides

echo "<a href='$filen' target='_new'><img src='$filen' width=100 height=100 border=0></a><br>";

the pages are to designate multiple photos uploaded. so if I have 100 it wont display 100 thumbnail images at once, it'll show 10? 20? at a time.

and yes I agree my code is terrible. Like I said, I'm not a coder, or at least a great one.

__berfuzz

Okej... Are you uploading the thumbnails to the server and saving the path in the sql-table?

Save the thumb in different maps. 1 to 20 in one, 21 to 40 in an other and so on. (You probably need to check and alter your upload script. Every user must have their own map with thumb-mapsetc)
Count thumbnail maps on the server for the user and use map-count to get the paging system.
Echo the urls with the maps.
Use urls, $_GET to muster the correct query. Default is 1 to 20.

Now you'll only have to query once and only 20 rows. $_GET should contain info about map, you stored user in the session-array, I guess. However, you might wanna read up a bit on stuff like [man]mysql_real_escape_string[/man].