Images not displaying

[bravo14]

Hi guys

I have got the following code

<?php
	include("admin/config.inc.php");

// initialization
$result_array = array();
$counter = 0;

$cid = (int)($_GET['cid']);
$pid = (int)($_GET['pid']);

// Thumbnail Listing

if( $cid && empty( $pid ) )
{
	$number_of_thumbs_in_row = 5;

	$result = mysql_query( "SELECT photo_id,photo_caption,photo_filename FROM gallery_photos WHERE photo_category='1'" );
	$nr = mysql_num_rows( $result );

	if( empty( $nr ) )
	{
		$result_final = "\t<tr><td>No Category found</td></tr>\n";
	}
	else
	{
		while( $row = mysql_fetch_array( $result ) )
		{
			$result_array[] = "<a href='gallery.php?cid=$cid&pid=".$row[0]."'><img src='http://www.projectrenovations.co.uk/admin/".$images_dir."/tb_".$row[2]."' border='0' alt='".$row[1]."' /></a>";
		}
		mysql_free_result( $result );	

		$result_final = "<tr>\n";

		foreach($result_array as $thumbnail_link)
		{
			if($counter == $number_of_thumbs_in_row)
			{	
				$counter = 1;
				$result_final .= "\n</tr>\n<tr>\n";
			}
			else
			$counter++;

			$result_final .= "\t<td>".$thumbnail_link."</td>\n";
		}

		if($counter)
		{
			if($number_of_photos_in_row-$counter)
		$result_final .= "\t<td colspan='".($number_of_photos_in_row-$counter)."'>&nbsp;</td>\n";

			$result_final .= "</tr>";
		}
	}
}

// Full Size View of Photo
else if( $pid )
{
	$result = mysql_query( "SELECT photo_caption,photo_filename FROM gallery_photos WHERE photo_id='".addslashes($pid)."'" );
	list($photo_caption, $photo_filename) = mysql_fetch_array( $result );
	$nr = mysql_num_rows( $result );
	mysql_free_result( $result );	

	if( empty( $nr ) )
	{
		$result_final = "\t<tr><td>No Photo found</td></tr>\n";
	}
	else
	{
		$result = mysql_query( "SELECT category_name FROM gallery_category WHERE category_id='1'" );
		list($category_name) = mysql_fetch_array( $result );
		mysql_free_result( $result );	


		$result_final .= "<tr>\n\t<td align='center'>
				<br />
				<img src='".$images_dir."/".$photo_filename."' border='0' alt='".$photo_caption."' />
				<br />
				$photo_caption
				</td>
				</tr>";
	}
}

// Final Output
echo <<<__HTML_END
<table width='100%' border='0' align='center' style='width: 100%;'>
$result_final		
</table>

__HTML_END;
?>

But when I load the page the images do not display

Where have I gone wrong

Cheers

[dagon]

view the page source and see if the img src is correct.

[bravo14]

It is not displaying the image src, but I would have thought that using the code that it would show

[dagon]

put print_r($row); inside the while loop to see what you have

[bravo14]

I am not getting anything displayed I entered the bit you told me to so the code looks like

<?php
	include("admin/config.inc.php");

// initialization
$result_array = array();
$counter = 0;

$cid = (int)($_GET['cid']);
$pid = (int)($_GET['pid']);

// Thumbnail Listing

if( $cid && empty( $pid ) )
{
	$number_of_thumbs_in_row = 5;

	$result = mysql_query( "SELECT photo_id,photo_caption,photo_filename FROM gallery_photos WHERE photo_category='1'" );
	$nr = mysql_num_rows( $result );

	if( empty( $nr ) )
	{
		$result_final = "\t<tr><td>No Category found</td></tr>\n";
	}
	else
	{
		while( $row = mysql_fetch_array( $result ) )
		{
			$result_array[] = "<a href='gallery.php?cid=$cid&pid=".$row[0]."'><img src='http://www.projectrenovations.co.uk/admin/".$images_dir."/tb_".$row[2]."' border='0' alt='".$row[1]."' /></a>";
			print_r($row);
		}
		mysql_free_result( $result );	

		$result_final = "<tr>\n";

		foreach($result_array as $thumbnail_link)
		{
			if($counter == $number_of_thumbs_in_row)
			{	
				$counter = 1;
				$result_final .= "\n</tr>\n<tr>\n";
			}
			else
			$counter++;

			$result_final .= "\t<td>".$thumbnail_link."</td>\n";
		}

		if($counter)
		{
			if($number_of_photos_in_row-$counter)
		$result_final .= "\t<td colspan='".($number_of_photos_in_row-$counter)."'>&nbsp;</td>\n";

			$result_final .= "</tr>";
		}
	}
}

// Full Size View of Photo
else if( $pid )
{
	$result = mysql_query( "SELECT photo_caption,photo_filename FROM gallery_photos WHERE photo_id='".addslashes($pid)."'" );
	list($photo_caption, $photo_filename) = mysql_fetch_array( $result );
	$nr = mysql_num_rows( $result );
	mysql_free_result( $result );	

	if( empty( $nr ) )
	{
		$result_final = "\t<tr><td>No Photo found</td></tr>\n";
	}
	else
	{
		$result = mysql_query( "SELECT category_name FROM gallery_category WHERE category_id='1'" );
		list($category_name) = mysql_fetch_array( $result );
		mysql_free_result( $result );	


		$result_final .= "<tr>\n\t<td align='center'>
				<br />
				<img src='".$images_dir."/".$photo_filename."' border='0' alt='".$photo_caption."' />
				<br />
				$photo_caption
				</td>
				</tr>";
	}
}

// Final Output
echo <<<__HTML_END
<table width='100&#37;' border='0' align='center' style='width: 100%;'>
$result_final		
</table>

__HTML_END;
?>

[Weedpacket]

print_r($row); not print_r($result). Are the <a> and <img> tags still being output?

[bravo14]

The <a> and <img> tags are not being dispalyed in the Source

[dagon]

have you checked if the query is actully returning anything?

[bravo14]

The query used

SELECT photo_id,photo_caption,photo_filename FROM gallery_photos WHERE photo_category='1'

does return a result.

[dagon]

then print_r($row) should be called but its not.

[bravo14]

Would there be anything wrong with the echo at the end, e.g. do I need to put brackets in there at all?

[dagon]

add

ERROR_REPORTING(E_ALL);

before the include

change your query to the below:

$result = mysql_query( "SELECT photo_id,photo_caption,photo_filename FROM gallery_photos WHERE photo_category='1'" ) or die(mysql_error());

[bravo14]

It is saying
Notice: Undefined index: cid in /home/sites/projectrenovations.co.uk/public_html/includes/sig_rooms_gallery.php on line 9

Notice: Undefined index: pid in /home/sites/projectrenovations.co.uk/public_html/includes/sig_rooms_gallery.php on line 10

Notice: Undefined variable: result_final in /home/sites/projectrenovations.co.uk/public_html/includes/sig_rooms_gallery.php on line 92

[dagon]

whats the site url?

[bravo14]

The URL to the gallery is www.projectrenovations.co.uk/gallery.php

Cheers

[dagon]

there should be a cid or pid var in the url

[bravo14]

How would I need to modify the code so that I do not need the variables in the URL?

[dagon]

define them on he page.

[bravo14]

I am getting there slowly but surely
The code now reads

<?php
	ERROR_REPORTING(E_ALL);
	include("admin/config.inc.php");

// initialization
$result_array = array();
$counter = 0;

$cid = 1;
$pid = (int)($_GET['pid']);

// Thumbnail Listing

if( $cid && empty( $pid ) )
{
	$number_of_thumbs_in_row = 5;

	$result = mysql_query( "SELECT photo_id,photo_caption,photo_filename FROM gallery_photos WHERE photo_category='1'" ) or die(mysql_error());
	$nr = mysql_num_rows( $result );

	if( empty( $nr ) )
	{
		$result_final = "\t<tr><td>No Category found</td></tr>\n";
	}
	else
	{
		while( $row = mysql_fetch_array( $result ) )
		{
			$result_array[] = "<a href='gallery.php?cid=$cid&pid=".$row[0]."'><img src='http://www.projectrenovations.co.uk/admin/".$images_dir."/tb_".$row[2]."' border='0' alt='".$row[1]."' /></a>";
			print_r($row);
		}
		mysql_free_result( $result );	

		$result_final = "<tr>\n";

		foreach($result_array as $thumbnail_link)
		{
			if($counter == $number_of_thumbs_in_row)
			{	
				$counter = 1;
				$result_final .= "\n</tr>\n<tr>\n";
			}
			else
			$counter++;

			$result_final .= "\t<td>".$thumbnail_link."</td>\n";
		}

		if($counter)
		{
			if($number_of_photos_in_row-$counter)
		$result_final .= "\t<td colspan='".($number_of_photos_in_row-$counter)."'>&nbsp;</td>\n";

			$result_final .= "</tr>";
		}
	}
}

// Full Size View of Photo
else if( $pid )
{
	$result = mysql_query( "SELECT photo_caption,photo_filename FROM gallery_photos WHERE photo_id='".addslashes($pid)."'" );
	list($photo_caption, $photo_filename) = mysql_fetch_array( $result );
	$nr = mysql_num_rows( $result );
	mysql_free_result( $result );	

	if( empty( $nr ) )
	{
		$result_final = "\t<tr><td>No Photo found</td></tr>\n";
	}
	else
	{
		$result = mysql_query( "SELECT category_name FROM gallery_category WHERE category_id='1'" );
		list($category_name) = mysql_fetch_array( $result );
		mysql_free_result( $result );	


		$result_final .= "<tr>\n\t<td align='center'>
				<br />
				<img src='http://www.projectrenovations.co.uk/admin/".$images_dir."/".$photo_filename."' border='0' alt='".$photo_caption."' />
				<br />
				$photo_caption
				</td>
				</tr>";
	}
}

// Final Output
echo <<<__HTML_END
<table width='100&#37;' border='0' align='center' style='width: 100%;'>
$result_final		
</table>

__HTML_END;
?>

I now have the following errors

Notice: Undefined index: pid in /home/sites/projectrenovations.co.uk/public_html/includes/sig_rooms_gallery.php on line 10

Notice: Undefined variable: number_of_photos_in_row in /home/sites/projectrenovations.co.uk/public_html/includes/sig_rooms_gallery.php on line 51

Notice: Undefined variable: number_of_photos_in_row in /home/sites/projectrenovations.co.uk/public_html/includes/sig_rooms_gallery.php on line 52

If I was wanting to view all photos in a category then there won't be a pid until a photo is selected, so not sure why I am getting that one

Any ideas

[dagon]

$number_of_photos_in_row is not defined
you could jsut add

$number_of_photos_in_row =99;