Parenthesis Issue

JessePHP

Hi all,

Getting an unexpected T_BOOLEAN_OR message and I know it's in the order of my parenthesis, but I think I need another set of eyes on this...

My code is:

If 	(($_POST["monday_closed"] != "on") && (($_POST["monday_start"] == "") || ($_POST["monday_finish"] == ""))) ||
				(($_POST["tuesday_closed"] != "on") && (($_POST["tuesday_start"] == "") || ($_POST["tuesday_finish"] == ""))) ||
				(($_POST["wednesday_closed"] != "on") && (($_POST["wednesday_start"] == "") || ($_POST["wednesday_finish"] == ""))) ||
				(($_POST["thursday_closed"] != "on") && (($_POST["thursday_start"] == "") || ($_POST["thursday_finish"] == ""))) ||
				(($_POST["friday_closed"] != "on") && (($_POST["friday_start"] == "") || ($_POST["friday_finish"] == ""))) ||
				(($_POST["saturday_closed"] != "on") && (($_POST["saturday_start"] == "") || ($_POST["saturday_finish"] == ""))) ||
				(($_POST["sunday_closed"] != "on)" && (($_POST["sunday_start"] == "") || ($_POST["sunday_finish"] == ""))) {
  // ... Stop
}

So, I'm basically trying to do that if the first condition is true, as well as the 2nd or 3rd condition is true, for each group. To shorten this:

If ((a = a) or ((b = b) or (c = d))) or ...

Can someone point out where I'm going wrong here?😕

Cheers,
Jesse

Weedpacket

The parentheses on each line all match. But there is no pair of parentheses enclosing the entire test.

Perhaps a function would help make it easier to read...?

function test_week()
{
	foreach(array('sunday','monday','tuesday','wednesday','thursday','friday','saturday') as $day)
	{
		if(($_POST["{$day}_closed"]!='on') &&
			(($_POST["{$day}_started"]=='') || ($_POST["{$day}_finished"]=='')))
		{
			return true;
		}
	}
	return false;
}


if(test_week())
{
	// Stop
}

JessePHP

A sound idea using the function to test, weed! Certainly makes it easier to read - but I'll have to try it tomorrow, it's late and I should sleep.

Also, I have used parenthesis to enclose the entire group, but then I get an "Unexpected {" which I found rather odd. . .

I'll let you know how I go.

Cheers,
Jesse.

Weedpacket

JessePHP wrote:
Also, I have used parenthesis to enclose the entire group, but then I get an "Unexpected {" which I found rather odd. . .

I'm guessing you went

 .... ($_POST["sunday_finish"] == ""))) { )

instead of

 .... ($_POST["sunday_finish"] == "")))) {

JessePHP

I'm afraid not, Weed...

I was cautious to not make that freudian slip - and for an insanity check, I did it again.

Weird... As you agreed with me, all of the parenthesis pair up...

Cheers,
Jesse.

JessePHP

Hey Weed,

Just a shout-out of thanks, no problems with that function, a great suggestion - cheers!

Jess.

Weedpacket

You're welcome. It's just a rule of thumb I have: if you're doing the same thing over and over again, you should probably get the computer to do it instead. It's good at doing the same thing over and over again.