[RESOLVED] Changed over to PHP5

bigfishtools

Man, I am one lost puppy

I have a script on a server which had php4. Host changed over to php5 and getting error on one page:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/motorper/public_html/inventory/cpanel.php on line 140

head Code as follows:

// get info from database
$link = mysql_connect($dbhost, $dbuser, $dbpass);

$query = "SELECT updated FROM $dbvin ORDER BY updated DESC";
$result = mysql_db_query($dbname, $query, $link);
$result = mysql_fetch_array($result);
$date = date('l M d, Y \a\t g:i a', $result[updated]);

$query = "SELECT COUNT(*) FROM $dbvin";
$result = mysql_db_query($dbname, $query, $link);
$result = mysql_fetch_array($result);
$count = $result[0];

mysql_close($link);
?>

Line 140

	<?
	$link = mysql_connect($dbhost, $dbuser, $dbpass);
	$query = "SELECT ccode, viewed, stock, vin, year, make, model, condition, mileage, price FROM $dbvin ORDER BY $sort $order";
	$result = mysql_db_query($dbname, $query, $link);
	$n = 1;
	while($data = mysql_fetch_array($result)) {
		if(!($n % 2)) { $bg = "class='fill_light'"; } else { $bg = ''; }
		echo "
		<tr $bg>
			<td class='text'>$data[stock]</td>
			<td class='text' align='center'>$data[year]</td>
			<td class='text'>$data[make]</td>
			<td class='text'>$data[model]</td>
			<td class='text' align='center'>$data[condition]</td>
			<!--<td class='text' align='center'>$data[mileage]</td>-->
			<td class='text' align='center'>$data[price]</td>
			<td class='text' align='center'>$data[viewed]</td>
			<td class='text' align='center'><a class='highlight' href='summary.php?ccode=$data[ccode]'>Options</a></td>
		</tr>
		";
		$n++;
	}
	mysql_close($link);
	?>

Any help would be great, and thank you inadvance

Alton

devinemke

use [man]mysql_error[/man] to see what's going on with your [man]mysql_connect[/man] and [man]mysql_db_query[/man] calls

foyer

Is this one script? Why are you connecting to mysql twice

bigfishtools

Yes it is the same script, why it tries to connects to the db twice I have no clue.

I have removed one and no workie.

Site ran fine until change to php5, front end of site is fine, just this error on any page in admin panel. All pages in panel display error:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in

bradgrafelman

bigfishtools wrote:
I have removed one and no workie.

Did you also remove the [man]mysql_close/man call after the first segment of code?

As devinemke suggested, [man]mysql_error/man is the way to debug SQL problems in PHP.

The common way (IMO) to debug a failing query is:

$query = 'SELECT foo FROM bar ...';
$exec = mysql_query($query) or die('MySQL error: ' . mysql_error() . "<hr>Query: $query");

Apply that concept to all of your SQL queries (specifically the one that's failing - the full PHP error message tells you which one) and let us know what the MySQL error message is as well as what the query was (from the debug output).

bigfishtools

Yes I removed the mysql_close() call and no change the error is:

MySQL error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'condition, mileage, price FROM $dbvin ORDER BY $sort $order' at line 1

Thanks for the help, like I said I am a lost puppy on this. 😕

foyer

This is an SQL error not PHP..

$query = "SELECT ccode, viewed, stock, vin, year, make, model, condition, mileage, price FROM $dbvin ORDER BY $sort $order";

You really need to be check these variables

echo your $query variable and try to enter it in MYSQL directly and I bet you'll find out what's going on.

foyer

As a matter of fact, I don't see those variables being defined in your script at all, so of course MySQL is going to output an error when you try to pass something like this:

SELECT ccode, viewed, stock, vin, year, make, model, condition, mileage, price FROM ORDER BY

bradgrafelman

The problem is that CONDITION is a MySQL Reserved Word. Escape it by surrounding it in backticks () so that MySQL knows that you meant the column namedcondition` instead.

bigfishtools

Ended up changing it to this and got it to work. Thanks for the effort.

// $link = mysql_connect($dbhost, $dbuser, $dbpass);

$query = "SELECT ccode, viewed, stock, vin, year, make, model, condition, mileage, price FROM $dbvin ORDER BY $sort $order";

$result = mysql_query($query);
$n = 1;

while($data = mysql_fetch_array($result)) {
	if(!($n % 2)) { $bg = "class='fill_light'"; } else { $bg = ''; }
	echo "
	<tr $bg>
		<td class='text'>{$data['stock']}</td>
		<td class='text' align='center'>{$data[year]}</td>
		<td class='text'>{$data['make']}</td>
		<td class='text'>{$data['model']}</td>
		<td class='text' align='center'>{$data['condition']}</td>
		<!--<td class='text' align='center'>{$data['mileage']}</td>-->
		<td class='text' align='center'>{$data['price']}</td>
		<td class='text' align='center'>{$data['viewed']}</td>
		<td class='text' align='center'><a class='highlight' href='summary.php?ccode={$data['ccode']}'>Options</a></td>
	</tr>
	";
	$n++;
}
mysql_close($link);
?>