Filter Price Bands

[iceomnia]

Okay - I am at this point and seem to have got quite far.

function findprices($low=0, $high=1000, $increments=6)
{
	// Highest Price
	$highest = rounddown($high);

// Lowest Price
$lowest = $low;

$difference = $highest-$lowest;

$amount_between = ceil($difference/$increments);

$price_to = $lowest+$amount_between;

$i = 1;
$output = array();
while ($price_to < $highest)
{
	//$output[] = $lowest;

	if ($lowest == 0)
	{
		$output[] = '0,'.$price_to;
	}
	elseif ($i == $increments-1)
	{
		$output[] = $lowest;
	}
	else
	{
		$output[] = $lowest.','.$price_to;
	}

	$i++;
	$price_to     = $price_to + $amount_between;
	$lowest     = $lowest + $amount_between;
}

return array_values($output);
}

Echoing out the result of this function gives you this:

Array
(
    [0] => 0,167
    [1] => 167,334
    [2] => 334,501
    [3] => 501,668
    [4] => 668
)

So it doesn't exactly work how it should.

Problems:

• Seems to always stop at 668

• I am looking for equal increments

• Say I have 6 increments, that would be 0-149, 150-299, 299-450 etc etc

Could someone help me out here?

[Weedpacket]

iceomnia wrote:

# Say I have 6 increments, that would be 0-149, 150-299, 299-450 etc etc

I'm not sure; if the high value is 1000, wouldn't you want 0-166, 167-332, 333-499, etc.?

But your problem may be you're rounding off too soon - the fact that you're always rounding up could cause problems as well (the bands will be too wide for them to all fit).

function find_price_bands($low=0, $high=1000, $bands=6)
{
	$range = $high-$low;
	$step = $range/$bands;
	$increment[0] = $low;
	for($i=1; $i<$bands; $i++)
	{
		$increment[$i] = round($step*$i);
	}
	$increment[$bands] = $high+1; // the range is inclusive but individual bands are not
	for($i=0; $i<$bands; $i++)
		$bandarray[$i] = array($increment[$i], $increment[$i+1]-1);
	return $bandarray;
}

[iceomnia]

Thank you so much!

You are an absolute STAR 😃

That works perfectly - exactly what I needed.

Now I look at what you've done, I can see where I was going wrong.

Thanks again! 🙂

[iceomnia]

Hi Guys,

I have come back to this thread because there seems to be a bug in Weedpacket's "find_price_bands()" function.

For example, this:

find_price_bands(254.15, 299, 5)

Returns this:

Array
(
    [0] => Array
        (
            [0] => 254.15
            [1] => 8
        )

[1] => Array
    (
        [0] => 9
        [1] => 17
    )

[2] => Array
    (
        [0] => 18
        [1] => 26
    )

[3] => Array
    (
        [0] => 27
        [1] => 35
    )

[4] => Array
    (
        [0] => 36
        [1] => 299
    )

)

Does anyone have any idea why it's doing this?

[iceomnia]

Right, got it.

function find_price_bands($low=10, $high=1000, $bands=5)
{
	$step = ($high-$low)/$bands;

$ol = $high < 1 ? 0.01 : 1;

$increment = array();

$increment = range($low, $high, $step);

for($i=0; $i<(count($increment)-1); $i++)
{
	$lowprice = $increment[$i];
	$highprice = (isset($increment[$i+1]) ? ($increment[$i+1]-$ol == $high-$ol ? $high : $increment[$i+1]-$ol) : $high);

	if($lowprice != $highprice)
		$bandarray[$i] = array($lowprice, $highprice);
}

$bandarray[count($bandarray)-1]['1'] = $high;

return $bandarray;
}

This works perfectly - no bugs at all - I have tested it exhaustively.

For anyone else, this has been tested on PHP Version 5.2.9 and works perfectly.

Thanks, Weedpacket for your help previously.

🙂