[RESOLVED] imagejpeg(); Help

phildiggle

Hi Guys,

Just signed up to the forum, but have addiquate experience in PHP coding. However, this one's throwing me.

Just downloaded PlainCart from phpwebcommerce.com so you can find the original source file on there. Problem lies within the directory admin/library/functions.php

Had a couple of problems but managed to iron them out - however, one has been persistant. This is that when I create a category through the Admin pages I get an error thrown out of:

Warning: imagejpeg(): Unable to open '/www/shoptrial/images/category/df3b73b51a50b6b4259a18b1bd843b2e.jpg' for writing in /vhost/vhost7/p/h/i/phildiggle.co.uk/www/shoptrial/admin/library/functions.php on line 254

Warning: Cannot modify header information - headers already sent by (output started at /vhost/vhost7/p/h/i/phildiggle.co.uk/www/shoptrial/admin/library/functions.php:254) in /vhost/vhost7/p/h/i/phildiggle.co.uk/www/shoptrial/admin/category/processCategory.php on line 50

Now, I've sorted out the WEB_HOST and SRV_HOST problems that first occured, so I know directories are fine. The images folder has been set to 777 as have the sub folders Catergory and Product. Still no luck though.

Offending lines are:

switch($size[2])
    {
       case 1:
       case 2:
           imagejpeg($dest,$destFile,$quality);   // Line 254
           break;
       case 3:
           imagepng($dest,$destFile);
    }

I've checked with phpinfo(); that GD support is fully enabled for all image types, and is version 2.0.28.

Let me know if you need the rest of the page code.
Regards,
Phil

sneakyimp

I'm not certain but it looks to me like you are using a path that is not correct:
/www/shoptrial/images/category/df3b73b51a50b6b4259a18b1bd843b2e.jpg

Are you certain that you have permission to write /www/shoptrial/images/category/ ??

I'd be willing to bet you really want to write something else, maybe /home/user/var/www/html/shoptrial/images or some other folder.

You might try this in your PHP script to find out the path where your files really live:

echo "current working directory is " . getcwd() . "<br>";
// or perhaps this one
echo "this file is " . __FILE__ . "<br>";

Once you see what comes out of that script, you might want to check where $dest and $destFile are getting defined. You may need to edit a configuration file or something or if you are defining these variables yourself then you might want to change them.

phildiggle

Hi,

Thanks for the reply.

I've just made a php script with the line you quoted and it gave me:

current working directory is /vhost/vhost7/p/h/i/phildiggle.co.uk/www/shoptrial/admin/library

I made sure I put the file in the exact same folder as the functions.php file.

Im sure I have permission to write, I've CHMODed the folders to 777. I've used an alternative script before on the server as an image uploader and havent had troubles uploading images to the server.

Theres a config file that comes with the script with a bunch of code, but two related to server files etc, such as:

define('WEB_ROOT', '/shoptrial/');
define('SRV_ROOT', '/root/www/shoptrial/');

Where the "readme" states that WEB_ROOT should be the name of the folder and SRV_ROOT is as implied.

However, combining that knowledge with what getcwd() gave, it solved my problem. And for that, I take my hat off to you sir. Thank you very very very much!

I now have to iron out several other problems but for now - no functions seem to be giving me trouble.

bradgrafelman

Don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu.

phildiggle

Right,

I think this is partially solved.

The imagejpeg(); warning doesnt appear anymore, and I can upload images fine. With one exception.

I can only upload small images. I.E. those less than 1mb in size. Anything over the 1mb size and I get a "page cannot be displayed" message. Would imagejpeg() make this happen?

I've checked all through the code and there's nowhere in the code that I can see that limits the user on filesize being input. The only code to do with file size is within the config.php file which lets the user choose the size in pixels of the thumb width and image width to be displayed. Nothing about user input.

// all category image width must not 
// exceed 75 pixels
define('MAX_CATEGORY_IMAGE_WIDTH', 75);

// do we need to limit the product image width?
// setting this value to 'true' is recommended
define('LIMIT_PRODUCT_WIDTH',     true);

// maximum width for all product image
define('MAX_PRODUCT_IMAGE_WIDTH', 300);

// the width for product thumbnail
define('THUMBNAIL_WIDTH',         75);

And the text in caps is called like this:

// check the image width. if it exceed the maximum
		// width we must resize it
		$size = getimagesize($image['tmp_name']);

	if ($size[0] > MAX_CATEGORY_IMAGE_WIDTH) {
		$imagePath = createThumbnail($image['tmp_name'], $uploadDir . $imagePath, MAX_CATEGORY_IMAGE_WIDTH);
	} else {
		// move the image to category image directory
		// if fail set $imagePath to empty string
		if (!move_uploaded_file($image['tmp_name'], $uploadDir . $imagePath)) {
			$imagePath = '';
		}
	}

and

list($width, $height, $type, $attr) = getimagesize($image['tmp_name']); 

	// make sure the image width does not exceed the
	// maximum allowed width
	if (LIMIT_PRODUCT_WIDTH && $width > MAX_PRODUCT_IMAGE_WIDTH) {
		$result    = createThumbnail($image['tmp_name'], $uploadDir . $imagePath, MAX_PRODUCT_IMAGE_WIDTH);
		$imagePath = $result;
	} else {
		$result = move_uploaded_file($image['tmp_name'], $uploadDir . $imagePath);
	}

Hmm.
Is this related, or would this stop me uploading files larger than 1mb (files directly from camera etc)

sneakyimp

It is never a good idea to allow users to give arbitrarily large inputs. In fact, allowing users to do so is a major reason that software can be exploited. If you supply enough input, you can sometimes inject code instructions into a place in memory where it should not exist. See wikipedia for more info if you are curious.

That said, PHP has a number of limits that might be relevant:
there is a limit in the php INI file that puts a cap on how big uploaded files can be. See here.
there is a limit in the php INI file that puts a cap on how large a POST input can be. See here.
you can limit the maximum uploaded file size by adding an extra input in your html form:

<input type="hidden" name="MAX_FILE_SIZE" value="30000" />

* The php INI file specifies a memory limit. If your script exceeds this usage during operation, it will be halted. See [man]memory_get_usage[/man], [man]memory_get_peak_usage[/man], and memory_limit.

phildiggle

hmm.

The sizes arent set as the user by such, its hard coded into the script and not actually accessed by someone who doesnt know what they're doing... if that makes sense?

As for the limit, I can't see anywhere in the script that gives a hidden value, or any sort of value to the upload file memory size. I dont have access to a php.ini file since my site is hosted with a web host rather than being hosted by myself. Would there be a way to overwrite any limits set from my end, or would it be something I'd have to ask the host about?

I don't particularly want to limit the file size upload since the photos being added are likely to not be processed once taken from the digital camera, so a 10megapixel file being uploaded if you will, at a possible size of ~2mb.

sneakyimp

Although you may not see these values in your scripts, you are still bound by them. Try running this script and you'll get a better idea of what your limitations are:

<?php
echo 'memory_get_usage:' . memory_get_usage() . "<br>\n";
echo 'memory_limit:' . ini_get('memory_limit') . "<br>\n";
echo 'upload_max_filesize:' . ini_get('upload_max_filesize') . "<br>\n";
echo 'post_max_size:' . ini_get('post_max_size') . "<br>\n";
?>

As for the 'page cannot be displayed' message, I'm not sure what that message means. It would be much more helpful to have a real PHP error.

One other thing is that you should read up on [man]move_uploaded_file[/man]. You should always check to see if it === FALSE because if it does then no files were moved. in your script you just set your imagePath to the empty string. That doesn't sound particularly useful.

phildiggle

Thanks for the help,

The code above shows the following when ran:

memory_get_usage:11272
memory_limit:8M
upload_max_filesize:2M
post_max_size:8M

So I guess maxium upload is 2MB? But doesn't solve why I can only upload anything less than 1MB...

phildiggle

New development, if its of any help....

If I open my jpg in Photoshop and resave it, it will upload but not output the image. (in other words, the script thinks no image has been uploaded and as such defaults the product to display no image) This will hold true for files over 1MB.

I did this with a picture from my SLR, from the camera the file was 2.3MB but out of photoshop with no editing, the file came to 3.3MB... Neither uploaded but the one from photoshop didn't make the error occur.

However, running the script multiple times and using an image straight from the SLR it will run the script but not upload. Which is where it confuses me.

As far as I can tell, this is the code to do with uploading the images and resizing them etc:

/*
	Create a thumbnail of $srcFile and save it to $destFile.
	The thumbnail will be $width pixels.
*/
function createThumbnail($srcFile, $destFile, $width, $quality = 75)
{
    $thumbnail = '';

if (file_exists($srcFile)  && isset($destFile))
{
    $size        = getimagesize($srcFile);
    $w           = number_format($width, 0, ',', '');
    $h           = number_format(($size[1] / $size[0]) * $width, 0, ',', '');

    $thumbnail =  copyImage($srcFile, $destFile, $w, $h, $quality);
}

// return the thumbnail file name on sucess or blank on fail
return basename($thumbnail);
}

/*
    Copy an image to a destination file. The destination
    image size will be $w X $h pixels
*/
function copyImage($srcFile, $destFile, $w, $h, $quality = 75)
{
    $tmpSrc     = pathinfo(strtolower($srcFile));
    $tmpDest    = pathinfo(strtolower($destFile));
    $size       = getimagesize($srcFile);

if ($tmpDest['extension'] == "gif" || $tmpDest['extension'] == "jpg")
{
   $destFile  = substr_replace($destFile, 'jpg', -3);
   $dest      = imagecreatetruecolor($w, $h);
   imageantialias($dest, TRUE);
} elseif ($tmpDest['extension'] == "png") {
   $dest = imagecreatetruecolor($w, $h);
   imageantialias($dest, TRUE);
} else {
  return false;
}

switch($size[2])
{
   case 1:       //GIF
       $src = imagecreatefromgif($srcFile);
       break;
   case 2:       //JPEG
       $src = imagecreatefromjpeg($srcFile);
       break;
   case 3:       //PNG
       $src = imagecreatefrompng($srcFile);
       break;
   default:
       return false;
       break;
}

imagecopyresampled($dest, $src, 0, 0, 0, 0, $w, $h, $size[0], $size[1]);

switch($size[2])
{
   case 1:
   case 2:
       imagejpeg($dest,$destFile, $quality);
       break;
   case 3:
       imagepng($dest,$destFile);
}
return $destFile;

}

and

function uploadImage($inputName, $uploadDir)
{
    $image     = $_FILES[$inputName];
    $imagePath = '';

// if a file is given
if (trim($image['tmp_name']) != '') {
    // get the image extension
    $ext = substr(strrchr($image['name'], "."), 1); 

    // generate a random new file name to avoid name conflict

$random_id_length = 10; 
$rnd_id = crypt(uniqid(rand(),1)); 
$rnd_id = strip_tags(stripslashes($rnd_id));
$rnd_id = str_replace(".","",$rnd_id); 
$rnd_id = strrev(str_replace("/","",$rnd_id)); 
$rnd_id = substr($rnd_id,0,$random_id_length);

    $imagePath = "$rnd_id" . ".$ext";

	// check the image width. if it exceed the maximum
	// width we must resize it
	$size = getimagesize($image['tmp_name']);

	if ($size[0] > MAX_CATEGORY_IMAGE_WIDTH) {
		$imagePath = createThumbnail($image['tmp_name'], $uploadDir . $imagePath, MAX_CATEGORY_IMAGE_WIDTH);
	} else {
		// move the image to category image directory
		// if fail set $imagePath to empty string
		if (!move_uploaded_file($image['tmp_name'], $uploadDir . $imagePath)) {
			$imagePath = '';
		}
	}	
}


return $imagePath;
}

Sorry if thats a lot of code to sift through, but its abit purplexing as to why lower sized files will work ok, yet its hit and miss when the file exceeds ~500kb...

sneakyimp

There's a couple of things you might be having problems with.

The first is that you should not be using number_format on the height and width of the image. All that does is add commas. If you are trying to cast them as integers, use [man]intval[/man]. Another thing is that you don't check for errors much. If getimagesize doesn't work (like when the file is not actually an image) then it returns false.

        $size        = getimagesize($srcFile);
        if ($size === FALSE) die('getimagesize failed!');
        $w           = number_format($width, 0, ',', '');
        $h           = number_format(($size[1] / $size[0]) * $width, 0, ',', '');

You don't necessarily have to die() but you could report an error or something. You should also be checking the results of imagepng or imagejpeg for failures.

Another thing is that both createThumbnail and copyImage are calling getimagesize. Ideally, you'd only be doing that once.

Another thing is that you don't bother to see if you are going to overwrite an existing file.

And lastly, just because your original image is only 1MB doesn't mean that you have enough memory. JPEGs and PNGs are highly compressed. When you decompress them and load them into memory, they can consume quite a bit more. I think truecolor images are at least 3 bytes per pixel and probably 4 while they are in memory. It doesn't take a very large image to surpass that--especially when you are creating a destination image and also loading the original image.

If this code isn't working, your first step is probably to add more error reporting so you can see what is going wrong. Check for FALSE values getting returned and think about using [man]error_reporting[/man] to crank up the error messages. If you are running out of memory, it should tell you.

phildiggle

To be honest, not quite sure what number_format or intval has to do with the image functions, all that I know is that the code does actually work for the images, I'm just more concerned about the size of images being uploaded.

Would there be an alternative way of altering the upload part to try and adapt it for larger images? Ultimately, I want to take the source image, create a thumbnail of it and a smaller version of it, without uploading the original file to the server.

error_reporting is turned on and set to E_ALL, and as such no errors are being produced by the script anywhere in the function of the program.

EDIT: Forgot to say, thank you for your help so far and for being patient with me 🙂

sneakyimp

number_format does absolutely nothing in your code but possibly break it. in fact, try uploading an image that is only 1 pixel in one dimension and 1000 or more in the other. It'll be small enough to not cause memory issues but will still be screwed up. For instance, $v2 in this code has a value of 1:

$v = number_format(1999, 0, '', ',');
$v2 = intval($v);

take number_format out.

As for error reporting, re-read my last post. It's not just a matter of turning on error reporting. YOU NEED TO CHECK FUNCTIONS THAT YOU CALL TO SEE IF THEY RETURN BAD VALUES. Some examples: imagecreatetruecolor, imagejpeg, imagepng, getimagesize, imagecopyresampled. Perhaps the worst one is move_uploaded_file. If it returns false then you just set imagePath to the empty string. Don't you think you should be producing an error for someone to see at that point?

As for conserving memory, I think you are out of luck. You have to create two image resources to use imagecopyresampled. There's no way around it.

phildiggle

Sorry, but I'm gonna be a bit arogant here...

The script is a shop, and the images uploaded through this will be taken from a camera, with little or no processing involved. So the image dimensions will be pretty much 3:4 or 16:9 portrait and landscape.

I've altered my config script which is called in almost all php files to set memory_limit quite high using ini_set function. Which whilst I understand is a brute force attempt at covering the china under the carpet - but for me, it satisfys my needs.

If I had time to sit down and play with the script properly I would probably have a go at re-writing the image upload part of the script.

I had a play with a blank image like you said with those odd dimensions, and yes I did get errors - but like I said, in reality terms of the script - the code functions fine without me trying to mess about with other functions for $w and $h

I'm not going to mark this thread as resolved just yet because I haven't finished playing with the script. So rather than sparking up a new thread, this one should be ok to stick with.

I am used to PHP programming, but not done anything as intense as this for quite some time so I'm showing my rusty side! Plus, studies are forcing me to cut corners with the quality of scripting. Needs must though.

As I say, I know ini_set('memory_limit') is a kind of brute force attack, but in theory this limit is only achieved when the script is run rather than altering the php_ini directly (which I don't have access to)

sneakyimp

If you are permitted, ini_set('memory_limit') is fine. You should absolutely, definitely, without any doubt take out the number_format calls. They literally don't do anything that you need.

oneplace

You might have this fixed already, but I found if i deleted all the old images out like df3b73b51a50b6b4259a18b1bd843b2e.jpg' and made sure my permission was correct I got rid of that error