terrible luck with move_uploaded_file

marcnyc

Hello I am having a really hard time with move_uploaded_file
I am trying to output an error when the uploaded file is too big. My server max upload is set to 100Mb and I am trying to set the limit to 10Mb. If I upload a smaller file it works, if I try to upload a bigger file the file doesn't get uploaded (as expected) but I am unable to output the error I want to output.
It seems that $_FILES is empty and because it is empty I can't check for the existence of the upload with is_uploded_file or file_exists (I have no argument for the two functions).
I read the manual and all the comments... somebody commented that if the file is too move_uploaded_file will just die and not return an error and that is what seems to be happening.
Does anyone know how to work around this?

Here's my code so far:

			if ( $_POST && empty($_FILES['tbs_mp3']['name']) ) {
				// nothing to upload
				echo '<br /><br /><span style="background-color:orange;">'.$tbs_lng['upld_not'].'</span>'.$rn;
			} else if ( $_POST && strtolower(substr($_FILES['tbs_mp3']['name'],-3)) == 'mp3' ) {
				// correct extension
				if ( move_uploaded_file($_FILES['tbs_mp3']['tmp_name'], $target_path.str_replace(' ','_',$_FILES['tbs_mp3']['name'])) ) {
					// file uploaded succesfully
					echo '<br /><br /><span class="approved">'.$tbs_lng['upld_ok'].'</span><br /><br />'.$rn;
					echo 'The file you just uploaded is now called: <b>'.str_replace(' ','_',$_FILES['tbs_mp3']['name']).'</b><br />';
				} else {
					// file too big
					echo '<br /><br /><span class="error"><b>'.$tbs_lng['upld_err1'].' '.($_POST['MAX_FILE_SIZE'] / 1000000).'Mb '.$tbs_lng['upld_err2'].'</b></span><br />'.$rn;
				}
			} else if ( $_POST && strtolower(substr($_FILES['tbs_mp3']['name'],-3)) != 'mp3' ) {
				// wrong extension (no upload takes place)
				echo '<br /><br /><span class="error"><b>'.$tbs_lng['upld_mp3ext_err'].'</b></span><br />'.$rn;
			}

bradgrafelman

What is PHP's post_max_size directive set to?

marcnyc

it's set to 8Mb... i guess that is my problem, right?
I didn't know about post_max_size, I had looked in my phpinfo and saw that upload_max_filesize was set to 100Mb and I thought that's all I needed to know

does my code look fine other than that? can I just set my limit to 8Mb and it will work?

bradgrafelman

It should work, I would say. Note that post_max_size includes all POST'ed data, so if you uploaded a file that was exactly 8Mb, then any extra data (e.g. the submit button, text fields, etc.) would set the POST operation over the limit.

Unfortunately, PHP doesn't handle this situation very well; there's no error message to trap or anything... you're just left with empty $POST and $FILES arrays.

Weedpacket

This doesn't have anything to do with move_uploaded_file .... if the file was disallowed because it was too big you wouldn't be trying to move it as an uploaded file anyway.

bradgrafelman wrote:
Unfortunately, PHP doesn't handle this situation very well; there's no error message to trap or anything... you're just left with empty $POST and $FILES arrays.

But like you say, it's a situation that's easily enough remedied - there's just no mechanism for PHP to report the condition. The XDebug extension traps it, but that's unsuitable for a production environment.

post_max_size is referred to on the POST Method Uploads page, and its relevance is described on the file upload Common Pitfalls page.

marcnyc

I lowered my limit to 7Mb (since the server max is 8Mb) and even uploading a 6.5Mb file doesn't work and it just dies... now that I am at or below the server limit, is there a way for me to find out whether this file has been uploaded or not so that if it hasn't I can tell the user that it is because it's too big? is there ANY way I can find out whether the file is too big?? Thanks