newsletter

[adam2326]

I have been trying to set up a newsletter sign up system so that a user can register their email and the admin can send a newsletter from the actual web site. However, the problem is that the newsletter does not send to the email address.

here is my code:

the form

<form NAME="newsletter" onSubmit="return ValidateForm()" METHOD="POST" ACTION="newsletter.php">
                        	<p class="clearfix"><label for="email">Your E-mail</label>
                            <input name="email" id="email" type="text" value="" /></p>
                            <p class="clearfix check">&nbsp;</p>
                   	        <span class="clearfix check">
                   	        <input type="Submit" value="Submit" name="SubmitButton" />
                   	        </span>
  </form>

newsletter.php

<?php

include ("connection.php");

$status = "OK";
$msg = "";
if(!stristr($email,"@")OR !stristr($email,".")){
	$msg = "Your email address is not valid<BR>";
	$status = "NOT OK";}
	echo "<br><br>";
if($status=="OK"){
$query=("INSERT INTO newsletter (email,status) VALUES ('$email','subscribe')");
$result=mysql_query($query);
echo "<center>THANK YOU <br>Thanks for subscribing to our newsletter. At any time you can unsubscribe by clicking a link in your newsletter</center>";
          }
else {echo "<center>$msg </center>";}  

?>

form to send newsletter

<form name="booking" action="postmail.php" method="post">
<label><span>Subject of Message</span>
<input type="text" name="subject" id="subject" class="input-text"/>
</label>
<label><span>Message Body</span>
<textarea name="body" id="body" cols="35" rows="10"></textarea>
</label>
<input type=hidden name=sendmail value=yes>
<div class="spacer"><input type="submit" value="Send"  class="green"></div>
</form>

postmail.php

<?php
include ("connection.php");
$pt2="http:// $hostname$databaseName";
$pt2= substr($pt2,0,strlen($pt2)-21);  

$query="select email from newsletter where status='subscribe'";
$result=mysql_query($query);
while($rowdata=mysql_fetch_array($result))
{
$msg2=$msg."<BR>To unsubscribe <a     href=$pt2"."unsub.php?email=$rowdata[em]>Click HERE</a>";
mail($rowdata[email],$subject, $body, $msg2,"$mail_type");
}
?>

Any help would be much appreciated. 🙂

[dagon]

you need to narrow down where the error is, are the emails added to the db?
Does your postmail.php select query retrieve them?

[Kudose]

Also, you should use single or double quotes when accessing associative array elements.

i.e.

$rowdata[email]

Should be

$rowdata['email'] or $rowdata["email"]

You should only use double quotes when you need variable interpolation in the array subscript as well.

[adam2326]

The database called newsletter contains users email addresses. The admin then types up a newsletter and once submitted, the postmail.php script is supposed to select all the email addresses where the status is subscribe and send them the newsletter.

[dagon]

your mail() function is wrong,$msg2 should be added to the body and i dont know what $mail_type is.

try it with just 3 parameters and see if it works.

[adam2326]

Still does not work. But I have just noticed that I have not specified my own email address which is obviously where it will be sent from. How do i do this? Do you think that will make it work?

[dagon]

does

mail('YOUR EMAIL ADDRESS','test','test');

work?