Function within a class method? Valiable problem

[iceomnia]

Hi Guys,

Here;s the simplified code:

<?php

class feeds
{
	function __construct()
	{

}

function process($data)
{
	$db = db::getSingleton();

	$map_fields = fields::getMapFields();

	// INNER FUNCTION
	function save($rows)
	{
		global $db, $map_fields;

		foreach ($rows AS $row)
		{
			$db->save($row[$map_fields]])
		}

		return true;
	}

	Parser($data, 'save');

	return true;
}
}
?>

So basically the "process" method calls a function called "Parser" which in turn calls the "save" function.

Works perfectly. Except:

The "$map_fields" valiable does not import into the scope of the "save" function BUT the "$db" variable does.

Anyone any adea why this is?

Is it because the "$map_fields" is in the scope of the "process" function? I would have thought the the "global" keyword refers to anything from it's current scope upwards?

Tricky... Any clues anyone?

[Weedpacket]

Um, why are you doing it that way at all? Why the inner function (which would mean the process() method could only be called once during the entire execution of the script)?

I would have thought the the "global" keyword refers to anything from it's current scope upwards?

No, it refers to the global scope (where there may be a $db variable declared - I don't know: the code as given is untestable).

$b = 17;

function a()
{
	$a = 42;
	$b = 'something other than 17';
	function b()
	{
		global $a, $b;
		echo "[\$a=$a],[\$b=$b]";
	}
	b();
}

a();

What you're after is a PHP 5.3 thing:

function process($data)
{
    $db = db::getSingleton();

$map_fields = fields::getMapFields();

$save = function($rows)use($db,$map_fields)
{
    foreach ($rows AS $row)
    {
        $db->save($row[$map_fields]]);
    }
    return true;
};

Parser($data, $save);

return true;
}

[iceomnia]

Unfortunately - I don;t have PHP 5.3 🙁

Here is a better example of what I am trying to achieve - I have rewritten my example.

<?php

error_reporting(E_ALL);

header('Content-Type: text; charset=utf-8');

// Functions!

function print_d($obj) { echo '<pre>' . print_r($obj, true) . '</pre>'; }

function dataparser($filename, $datahandler_function)
{
	// UNPACKS FILE AND PUTS IT INTO THIS ARRAY:
	// EXAMPLE!
	$array = array();
	//$array = file($filename);
	$array['name'] = 'TEST NAME';
	$array['description'] = 'TEST DESCRIPTION';

$datahandler_function($array);
}

// Class!

class feeds
{
	public $counter = 0;
	public $error = array();
	public $info;

public function __construct()
{
	$this->info = new stdClass;
	$this->info->id = 1001;
	$this->info->namefld = 'name';
	$this->info->descfld = 'description';

}

function process()
{
	$filename = '';
	// create data handler function!
	function save($data)
	{
		// SAVE DATA TO DATABASE!
		$dbSaveRecord = array();
		$dbSaveRecord = $data[$this->info->namefld];
		$dbSaveRecord = $data[$this->info->descfld];

		print_d($dbSaveRecord);
		// Custom global function
		//mysql_insert_array($dbSaveRecord);

		$this->counter++;

		unset($dbSaveRecord);
	}

	// call global function dataparser..
	dataparser($filename, "save");
}

public function error($message='')
{
	if(!empty($message))
		$this->error[] = $message;

	return $this->error;
}
}

$feed = new feeds();

print_r($feed);

?>

In the "SAVE" function I can't access the "$this" variable. I have tried everything. Making a copy of the "this" variable from the "feeds" class.

Making that global didn't work either as I would have to make a reference to it and you cannot reference a class variable from outside the scope of a class - besides which - that's just a bodge.

Any more ideas?

[iceomnia]

Well, it seems that when you gopy the "$this" variable, it's actually copied by reference.

I've got this code working...

Try it...

<?php

error_reporting(E_ALL);

header('Content-Type: text; charset=utf-8');

// Functions!

function print_d($obj) { echo '<pre>' . print_r($obj, true) . '</pre>'; }

function dataparser($filename='', $datahandler_function)
{
	//die('dataparser');
	// UNPACKS FILE AND PUTS IT INTO THIS ARRAY:
	// EXAMPLE!
	$array = array();
	//$array = file($filename);
	$array['name'] = 'TEST NAME';
	$array['description'] = 'TEST DESCRIPTION';

$datahandler_function($array);
}

// Class!

class feeds
{
	public $counter = 0;
	public $error = array();
	public $info;

public function __construct()
{
	$this->info = new stdClass;
	$this->info->id = 1001;
	$this->info->namefld = 'name';
	$this->info->descfld = 'description';

}

function process()
{
	global $feedsObj;
	$feedsObj = $this;

	$filename = '';
	// create data handler function!
	function save($data)
	{
		global $feedsObj;
		// SAVE DATA TO DATABASE!
		$dbSaveRecord = array();
		$dbSaveRecord['name'] = $data[$feedsObj->info->namefld];
		$dbSaveRecord['description'] = $data[$feedsObj->info->descfld];

		print_r($dbSaveRecord);

		$feedsObj->counter++;
	}

	// call global function dataparser..
	for($i=0; $i<2; $i++)
	{
		dataparser($filename, "save");
	}
}

public function error($message='')
{
	if(!empty($message))
		$this->error[] = $message;

	return $this->error;
}
}

$feed = new feeds();
print_r($feed);
$feed->process();
print_r($feed);