form to database error

opethrice1

Hello people, Below is the my code linked to my database. When I run it, The form comes up but it shows this error

Notice: Undefined index: Submitform in /Applications/MAMP/htdocs/Register.php on line 93

When I enter the registration information, it doesn't get passed on to the database. Can anybody please advise. My code is displayed below

<html>
<body>

<?php
  // If the user wants to register
  //if (isset($register)) 
?>



<table width="500" border="3" align="center" cellpadding="0" cellspacing="5" bgcolor="#CCCCCC">
<tr>
<FORM ACTION="register.php" METHOD=POST>
<td>
<table width="100%" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
<td colspan="3"><strong>Register New Member </strong></td>
</tr>
<tr>

<td width="78">First Name</td>
<td width="6">:</td>
<td width="294"><input name="Fname" type="text" id="Fname"></td>
</tr>
<tr>
<td>Last Name</td>
<td>:</td>
<td><input name="Lname" type="text" id="Lname"></td>
</tr>

<tr>
<td>Email Address</td>
<td>:</td>
<td><input name="Email_Address" type="text" id="Email_Address"></td>
</tr>

<tr>
<td>Username</td>
<td>:</td>
<td><input name="User_name" type="text" id="User_Name"></td>
</tr>


<tr>
<td>Password</td>
<td>:</td>
<td><input name="Pass_word" type="text" id="Pass_word"></td>
</tr>



<tr>
<td>&nbsp;</td>
<td>&nbsp;</td>
<td><input type= SUBMIT name="Submitform" value=" SUBMIT"></td>

</tr>


</table>
</td>
</form>
</tr>
</table>



<?php

//else:

// Connect to the database server

$dbcnx = mysql_connect('localhost', 'root', 'root') or die("cannot connect");

if (!$dbcnx) {
  echo( "<P>Unable to connect to the 'Things Booker' database server at this time.</P>" );
  exit();
} else {
  echo "DB connection: " . $dbcnx;
}

echo '<pre>';
print_r($_POST);
echo '</pre>';

mysql_select_db("Things_Booker", $dbcnx);

 // Select the Things Booker database

if (! @mysql_select_db("Things_Booker") ) {
  echo( "<P>Unable to locate 'Things Booker' database at this time.</P>" );
  exit();
}

 // If User Details Is Submitted,
    // add it to the database.


  $sql = "INSERT INTO Things_Booker SET " .
         "UserID='$User_Name', " .
         "FirstName='$Fname', " .
         "Surname='$Lname', " .
         "Email='$Email_Address', " .
         "Password='$Pass_word', " ;


if (mysql_query($sql)) {
    echo("<P>Your registration is complete.</P>");
  } 
else {
    echo("<P>Error submitting registration: " .mysql_error() . "</P>");
  }



?>



</body>
</html>

bradgrafelman

Hi there, and welcome to PHPBuilder. First, note the following few general bits of advice:

Try to use a descriptive title for your post. "HELP ME PLS ITS URGENT" is not descriptive and is likely to cause the opposite effect - drive people away from even reading your thread.
Speaking of posting, don't hijack others' threads with your own problem. If it's a separate issue, post a new thread.
When posting PHP code, please use the board's [noparse]
[/noparse] bbcode tags as they make your code much easier to read and analyze.

Now, on to your problem:

You should wrap the form and processing code into an if/else statement so that only one or the other is processed. An example control structure would be:
```
if(empty($_POST)) {
    // display form
} else {
    // process form
}
```

This code:

mysql_select_db("Things_Booker", $dbcnx);

// Select the Things Booker database

if (! @mysql_select_db("Things_Booker") ) {
  echo( "<P>Unable to locate 'Things Booker' database at this time.</P>" );
  exit();
}

will try to select the database twice. If you want to leave the error message in, remove the first call to mysql_select_db().

Speaking of the above code, you should never use the '@' error suppressor.

My reasoning on this is that the code will be used in only two settings: 1) development environment - this is where you are building and testing the code, thus you would want to see every error message PHP produces in order to fix the cause; 2) production environment - this is where your script is live, thus you should be logging (not displaying, e.g. display_errors is set to Off) every error that occurs so that you can fix the cause.
Where is $Fname ever defined? Or any of the other variables? Take a look at this manual page for more information about how to process data coming form external sources (e.g. an HTML form): [man]variables.external[/man].
Your code is vulnerable to SQL injection attacks; user-supplied data should never be placed directly into a SQL query string. Instead, you must first sanitize it with a function such as [man]mysql_real_escape_string/man.
When you've finished debugging this script, get rid of the [man]mysql_error/man function call from the error message displayed to the user; this is the type of information that should be logged but not displayed (it was never designed for the user - only you, the developer).