Need a fresh eye please

tinyang

I have this script which ideally will take info from a form and update a table with the form data. But when I hit the submit button on the form, all I get is a blank white page. I'm pretty sure that means there is a syntax error, but as hard as I've been looking at this for days, I can't find it. I also stepped away for a few days and came back to it and still not finding the problem. I'm hoping a fresh set of eyes here can help me out. Thanks for looking!

<?php
session_start();

if (!(isset($_SESSION['login']) && $_SESSION['login'] != '')) {
header ("Location: login.php");
}

$email = $_REQUEST['email'];
$website = $_REQUEST['website'];
$gender = $_REQUEST['gender'];
$age = $_REQUEST['age'];
$location = $_REQUEST['location'];
$favbirds = $_REQUEST['favbirds'];
$favplaces = $_REQUEST['favplaces'];
$favguide = $_REQUEST['favguide'];
$favequip = $_REQUEST['favequip'];
$favfest = $_REQUEST['favfest'];
$orgs = $_REQUEST['orgs'];
$sum = $_REQUEST['sum'];
$wint = $_REQUEST['wint'];

//Connect and select database
    mysql_connect("192.168.254.000", "username", "password") or die(mysql_error());
    mysql_select_db("tutorial") or die(mysql_error());

// Check matching of username
$result=mysql_query("select * from profiles where username = '$_SESSION['username']'");
if(mysql_num_rows($result)!='0'){ // If match.


//update record
    $query="UPDATE profiles SET email = '$email', website = '$website', gender = '$gender', age = '$age', location = '$location', favbirds = '$favbirds', favplaces = '$favplaces', favguide = '$favguide', favequip = '$favequip', favfest = '$favfest', orgs = '$orgs', sum = '$sum', wint = '$wint' WHERE username = '$_SESSION['username']'"; 

mysql_query($query) or die(mysql_error());

header("Location: profile.php");
//    $message="Profile updated successfully";

}else{ // If not match.

//insert data into table
    $query="INSERT INTO profiles (email, website, gender, age, location, favbirds, favplaces, favguide, favequip, favfest, orgs, sum, wint, user) VALUES ('".$email."', '".$website."', '".$gender."', '".$age."', '".$location."', '".$favbirds."', '".$favplaces."', '".$favguide."', '".$favequip."', '".$favfest."', '".$orgs."', '".$sum."', '".$wint."', '".$_SESSION['username']."')";

mysql_query($query) or die(mysql_error());

header("Location: profile.php");
//    $message="Profile updated successfully";

}
?>

coldwerturkey

turn your errors on

ini_set('display_errors', 1);
error_reporting(E_ALL);

the problem is improper escaping of the server var in $result and $query

bradgrafelman

coldwerturkey;10914684 wrote:
turn your errors on
ini_set('display_errors', 1);
error_reporting(E_ALL);

Actually, since the problem is a parse error, using [man]ini_set/man won't work; to enable error reporting, tinyang, you'll have to either use a .htaccess file (assuming you're running Apache with PHP installed as an ISAPI module) or modify the php.ini file.

Either way, note that you should always have some type of error-catching solution. For example, in your production environment you should enable error logging, and in your development environment you should simply enable display_errors.

tinyang

Thanks coldwerturkey! It's working now thanks to your advice. You were able to tell me the problem area so I was able to effectively google for a solution from there. 🙂

I still have not figured out the proper formatting for the session variables, can you please provide an example or a link to an example for my learning?

Here is the script code that works for me now:

<?php
session_start();

if (!(isset($_SESSION['login']) && $_SESSION['login'] != '')) {
header ("Location: login.php");
}

$email = $_REQUEST['email'];
$website = $_REQUEST['website'];
$gender = $_REQUEST['gender'];
$age = $_REQUEST['age'];
$location = $_REQUEST['location'];
$favbirds = $_REQUEST['favbirds'];
$favplaces = $_REQUEST['favplaces'];
$favguide = $_REQUEST['favguide'];
$favequip = $_REQUEST['favequip'];
$favfest = $_REQUEST['favfest'];
$orgs = $_REQUEST['orgs'];
$sum = $_REQUEST['sum'];
$wint = $_REQUEST['wint'];
$username = $_SESSION['username'];

//Connect and select database
	mysql_connect("192.168.254.000", "user", "pwd") or die(mysql_error());
	mysql_select_db("tutorial") or die(mysql_error());

// Check matching of username
$result=mysql_query("select * from profiles where username = '$username'");
if(mysql_num_rows($result)!='0'){ // If match.


//update record
	$query="UPDATE profiles SET email = '$email', website = '$website', gender = '$gender', age = '$age', location = '$location', favbirds = '$favbirds', favplaces = '$favplaces', favguide = '$favguide', favequip = '$favequip', favfest = '$favfest', orgs = '$orgs', sum = '$sum', wint = '$wint' WHERE username = '$username'"; 

mysql_query($query) or die(mysql_error());

header("Location: profile.php");
//	$message="Profile updated successfully";

}else{ // If not match.

//insert data into table
	$query="INSERT INTO profiles (email, website, gender, age, location, favbirds, favplaces, favguide, favequip, favfest, orgs, sum, wint, user) VALUES ('".$email."', '".$website."', '".$gender."', '".$age."', '".$location."', '".$favbirds."', '".$favplaces."', '".$favguide."', '".$favequip."', '".$favfest."', '".$orgs."', '".$sum."', '".$wint."', '$username')";

mysql_query($query) or die(mysql_error());

header("Location: profile.php");
//	$message="Profile updated successfully";

}
?>

Also, thank you bradgrafelman, I will follow your advice for enabling error reporting.

Weedpacket

tinyang wrote:
I still have not figured out the proper formatting for the session variables, can you please provide an example or a link to an example for my learning?

Plenty of examples can be found in the manual's chapter on session handling. There's nothing unusual about their format; the $_SESSION array looks exactly like any ordinary array.